From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 8B0E7A0543;
Thu, 15 Dec 2022 10:45:04 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 74C3840684;
Thu, 15 Dec 2022 10:45:04 +0100 (CET)
Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31])
by mails.dpdk.org (Postfix) with ESMTP id AD3D240223
for <dev@dpdk.org>; Thu, 15 Dec 2022 10:45:01 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1671097502; x=1702633502;
h=date:from:to:cc:subject:message-id:references:
content-transfer-encoding:in-reply-to:mime-version;
bh=QBVWlplrp+91PKsRaLTY156Cu3d4NXFsXamE8MGN2oE=;
b=E3kSiYQI6Rqy2jLhwUs8tHsbBKTXoyVShGmqa8WZ8LDefA911NE8h3Iy
F5EpcpGfBgHNp0e7tUP1v44kmCPPUSDSzyJuNZFdfeoMldK0SEo0F/Mkg
I/RK5UjoKTQI2FmX+AKbjOQBEVhRynE9fEA73X51c0p3kU0w43DOlOTcy
Mgjw0gFA0gpBrO2USQnoBT0bqFlq40hIoXmszhSJzCogVnMQYpCKKkPbD
gfJLcOpsC8REfzgCiCvZgQkVJiJccMmEobhr84v28tzz1UssCIDMHX6Eu
OnHZF8/F747/xwnwlKEk7m0y4aPm2i/NN8gs2fmc/l9AKbdt0gJQ9mubp g==;
X-IronPort-AV: E=McAfee;i="6500,9779,10561"; a="380831531"
X-IronPort-AV: E=Sophos;i="5.96,247,1665471600"; d="scan'208";a="380831531"
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
15 Dec 2022 01:45:00 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=McAfee;i="6500,9779,10561"; a="738038307"
X-IronPort-AV: E=Sophos;i="5.96,247,1665471600"; d="scan'208";a="738038307"
Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81])
by FMSMGA003.fm.intel.com with ESMTP; 15 Dec 2022 01:45:00 -0800
Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by
fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.16; Thu, 15 Dec 2022 01:44:59 -0800
Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by
fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.16; Thu, 15 Dec 2022 01:44:59 -0800
Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by
fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.16 via Frontend Transport; Thu, 15 Dec 2022 01:44:59 -0800
Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104)
by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2507.16; Thu, 15 Dec 2022 01:44:59 -0800
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=Tgb2g8BJ7Gy81NFdBPoimWbR06GWr6vkzcNOjvUcBHuR1aLhHfBl1pPAJSgkMAwSxaaxuTjoNYrWQqQkU7MvqwuaDA+8wSxtUHBvd0Wtuf4Py0bFzbCsaiWqaRr3XLkvDbCccIBxff7jKW6vmnIrcVHqmksF5/m2+6ps9DB3AaT3aizHPm6rr+I8LRY0eEg+oRkNHa56h6jko8EksoUzYm978xAE3tq0/ZtieAEAN/wmVKdD1NcW+N/XZzFCaSdzLqfkpo8/D3To+UPuiRxlfItVMUsCRntehCtxuCTt+kPzirHTfAiJh3ed7bnVDYwx488bnqVq2nEdXK3rNZ/AvA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=T61e5w6ULAI3YtXETjdoVpYO6TTYf1WeIk6ntrqCsGY=;
b=Bs08AX5AV30xlNpfwarl8ouUxIg98quZUYHMtqrYA8hBNr3/SVrhvbIky5Sp5/wP1jQ0hFRyOXXaxGBJhqBarJNzBKe2jexShPjfEtx+yLbdWa2HkGsT+/IhQZgDgTMEefOLw8XJ8ndOSnfIrcfly7pkcKokc40jw/xddDMFIr3RKvKej7nqHUSRgvT+Lhr4+K+t0eqiwEsRurWm6apeTrXUAnIBu1DWnVCCTrcALN/czqjmOuMnHwgL18g/aUVit0hjg1sM36sR4DigmBESjqBrsFzRDHx/L1MM5lR6MOrj0AVulvitIyT1ImGt2u/Bc9a9CS/chLXd4Ttvi6ilmQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
Authentication-Results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=intel.com;
Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21)
by SA0PR11MB4527.namprd11.prod.outlook.com (2603:10b6:806:72::17) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.12; Thu, 15 Dec
2022 09:44:57 +0000
Received: from MWHPR11MB1629.namprd11.prod.outlook.com
([fe80::18bd:edae:ad31:a228]) by MWHPR11MB1629.namprd11.prod.outlook.com
([fe80::18bd:edae:ad31:a228%3]) with mapi id 15.20.5924.011; Thu, 15 Dec 2022
09:44:57 +0000
Date: Thu, 15 Dec 2022 09:44:49 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
CC: <dev@dpdk.org>, Morten =?iso-8859-1?Q?Br=F8rup?=
<mb@smartsharesystems.com>, <thomas@monjalon.net>,
<david.marchand@redhat.com>
Subject: Re: [RFC PATCH 2/7] telemetry: add uint type as alias for u64
Message-ID: <Y5rskfAIjxxlptSy@bricha3-MOBL.ger.corp.intel.com>
References: <20221213182730.97065-1-bruce.richardson@intel.com>
<20221213182730.97065-3-bruce.richardson@intel.com>
<20221214173845.GC31935@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20221214173845.GC31935@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
X-ClientProxiedBy: LO2P265CA0015.GBRP265.PROD.OUTLOOK.COM
(2603:10a6:600:62::27) To MWHPR11MB1629.namprd11.prod.outlook.com
(2603:10b6:301:d::21)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|SA0PR11MB4527:EE_
X-MS-Office365-Filtering-Correlation-Id: 9def5e9c-ebda-4e29-8c40-08dade810682
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: CXqRxNw/ztk1aQaFIOnUpkdizgRKyglYD7XS0n3txTet1vlmZ/K0Az8TdNrFVHJiXLLsMSZINk3CE2i/0hl48pMD2o4/q+OjGztDllsIpTAIYeGNb7jY+yynUyyaKxjQAGjq0hGp+DJM3mbWYz4BcQlK+egbhtihZv4riOrBFsh/vakFQqqjtgrRGrxgIToUvxWR0utbP6h8IdeSb5e4k8alANwS4o62Fn1ffdZjLlf3AgalxP4rojcwQ4G9PttSIfWc89z1CVyQm1KD5yiZL87d/wJUZ7VyryW9K58V5S53lD3kieaYTgY/C9wu9KUyxka67MPHcSMi6T8bxmPczIB+Whl0L2PEb4h5IwWSntX3hKNnYAMe6ygaxXI16rPBU356X6m8RKnX+O7dE3daJqZq7FlSzJ+vDnYvZjiwP7hx8gUsSmN0Z4aUjOLpNAT4CVFNFJHzLMhjEjCfl19jnEOcw35eO1rV2vJV+Hpfvy+vX642U9EWVLLdd8F4L6ZpWlh46TtY4JvRPlcxdvj5K83EHSoaghuV+i68zBI4cQw544Ej2QXcnG3OMvZPkWQFEZ3O2VEfZFw7kyjZFcFZji+3vAylhEBo2VuHidMEA1v/flraqU6htOEtrLWtSz5n7YZQ5qD3Ia4CG5CMyCQXhA==
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230022)(366004)(39860400002)(396003)(376002)(346002)(136003)(451199015)(82960400001)(2906002)(8936002)(5660300002)(41300700001)(6916009)(83380400001)(66574015)(38100700002)(86362001)(478600001)(6486002)(44832011)(6506007)(4326008)(6666004)(66476007)(316002)(66946007)(8676002)(66556008)(186003)(26005)(6512007);
DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?kYfkb0nO3AV50vA26c5XuXMrNI9G8pasv1+/AiNUlDNlh2LX1oOex1W++k?=
=?iso-8859-1?Q?oCOkVVTpUWkVdTiJ7tZm89iDAYGhtepdmHJG26D3fgQ7vlqx39Ajuenwt4?=
=?iso-8859-1?Q?N75D+NmYbNhyODIqLNxK98nPFKvKvRhQgUcvmA30zEqaWP2fTakY0j6ing?=
=?iso-8859-1?Q?11zU7zAgMxJjp1GjZjmQmo4D41xvU+mY5+6H6syPOmU9aod9qlAvHPfhbH?=
=?iso-8859-1?Q?jW/uGPW92AVBRuO5ZhBlHaTXc/80G81OOJtME9ZoBysPTaMqWQWBpgRmCQ?=
=?iso-8859-1?Q?SXtY3j46fAzdHSSR2NrXtULw6pyhRIxu5p+E7JP1Vwh1vDCC5gibsem/Xh?=
=?iso-8859-1?Q?vK3IxHmc/jyEvG8PLB+kmqxv9ORN/YVp+gEzdVxhsDYUC5zA0/vgtnKEde?=
=?iso-8859-1?Q?Izy8+3ZHgNVd4W5c3j8tU4VCAXgyyugqEW46V5uRdrQAdiSMRR6kUbSQYo?=
=?iso-8859-1?Q?zCXKfQrFJZk3Ai1Ib8QXqmZMESgDMpKlVXJRk6Iu1oP/O7mFzZ5AehRNn7?=
=?iso-8859-1?Q?Gw/Xj5x0sWrboNEYu5/iQjNlAD2t6056WB2oFQuT4kwxwXNWuOYU0XK86P?=
=?iso-8859-1?Q?dBdPXqYNlav9BCCHT0uLJwjv7qVhTbwHlt1ybHQOJfs9hHFNN2Lj4kFSM1?=
=?iso-8859-1?Q?2cfzMwXGd0D1SxHpj1HZPLGUJuO78NtxSzY1Ui3i7FhF5oHb1rHsiLmACi?=
=?iso-8859-1?Q?Tl68pv2ni/VFVWgV7LEXaNKTKYthnm6oegz4tR9G0BOVWaARsTI4M6BHqA?=
=?iso-8859-1?Q?+Wtdn+rUAf7n0+FVRhB6YqZq35vYOAN4YotuqV/BQ7PA55THF9PEh5lEqN?=
=?iso-8859-1?Q?HDUrX/w3ppvluQUFHgpJ6DjwtBm+Mu8Eho+mqavzPCXCJn6YQqJUOHcsKH?=
=?iso-8859-1?Q?EEaei99zIqoaEAtgLakeulJxNQlE8fgfRGynKYH04wMoZqHRUpyJDXizqt?=
=?iso-8859-1?Q?p2e1i9b1tTl+7ZiH8p0Ac3AoxQrdHTk4M8/aD8w6l803rKOdaugaVM/x0f?=
=?iso-8859-1?Q?RGry2t768aKC6/n8S8ugRZ+Tkp8qCvLr13i1HMkXe2rTUwI//n2NtJjwqr?=
=?iso-8859-1?Q?Hi36c3vBb87fiFPt3O0hRuJzreE/MjDJpCRQMGZd3dLeC3r1wtxBcf/SjF?=
=?iso-8859-1?Q?+5DmooCrUWu4G8RYrqjGDB28su7Q5pXOLqLMhvK6W+Bxw7kvwUZOfLhLPy?=
=?iso-8859-1?Q?8yVx7RY8eIUY8cUe/ZNcabsX7+DYdVNSB7Vw6DPABVE9iwGFpUrU4G9/oo?=
=?iso-8859-1?Q?wtF6zCwSp1tdUll+/huE9qwXk6yQaw/jSCxaODP7i9fNBC2UY8LumtAAIF?=
=?iso-8859-1?Q?6O/p5CE9Xd/Q61Z3ocI8p3VbQwFMnA+z94LXkzqLvDBEtjqqr70FD9CEsn?=
=?iso-8859-1?Q?5H9O2kgcX2cbgWoXQ5LRcDL3RxOn7Nbl0uf0lWiWlXnvRo7TchBxzuQLnm?=
=?iso-8859-1?Q?QYfyNTVeePPTFwTGFOjI11Sr0uURo7aR6I4vToNWOzsnzh67JAljTuEMrp?=
=?iso-8859-1?Q?K2o6KkB/AftkIH7+VK50wCU6KbNYONeyLfm5n1paqAy1l/EoQOjqFtCgka?=
=?iso-8859-1?Q?korPI+x0qUq1RICTdDRo4G/AiZwXZ6yUT92wMszlQsv3HzANTW/eNY9VDp?=
=?iso-8859-1?Q?f3RwX2rX4qRJSViYyNeb4MQ/fycNxUCd1C8P1/Z43bfKOHyYVwMJk/aQ?=
=?iso-8859-1?Q?=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9def5e9c-ebda-4e29-8c40-08dade810682
X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2022 09:44:57.0212 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VyGGGZFPmZi/rwW9hpfaS3l/dQFD6psz1SgKwaKNlVkP8xdfZ5HESSs5bG2NMOZfWeKEOiWHOrLrExfPVKqp9fMx9l2iJhSZehvURU/cH6Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4527
X-OriginatorOrg: intel.com
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Wed, Dec 14, 2022 at 09:38:45AM -0800, Tyler Retzlaff wrote:
> On Tue, Dec 13, 2022 at 06:27:25PM +0000, Bruce Richardson wrote:
> > For future standardization on the "uint" name for unsigned values rather
> > than the existing "u64" one, we can for now:
> > * rename all internal values to use uint rather than u64
> > * add new function names to alias the existing u64 ones
> >
> > Suggested-by: Morten Brørup <mb@smartsharesystems.com>
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > lib/telemetry/rte_telemetry.h | 36 ++++++++++++++++++++++++++++++++++
> > lib/telemetry/telemetry.c | 16 +++++++--------
> > lib/telemetry/telemetry_data.c | 28 ++++++++++++++++++--------
> > lib/telemetry/telemetry_data.h | 4 ++--
> > lib/telemetry/version.map | 7 +++++++
> > 5 files changed, 73 insertions(+), 18 deletions(-)
> >
> > diff --git a/lib/telemetry/rte_telemetry.h b/lib/telemetry/rte_telemetry.h
> > index c2ad65effe..60877dae0a 100644
> > --- a/lib/telemetry/rte_telemetry.h
> > +++ b/lib/telemetry/rte_telemetry.h
> > @@ -8,6 +8,8 @@
> > #ifndef _RTE_TELEMETRY_H_
> > #define _RTE_TELEMETRY_H_
> >
> > +#include <rte_compat.h>
> > +
> > #ifdef __cplusplus
> > extern "C" {
> > #endif
> > @@ -121,6 +123,22 @@ int
> > rte_tel_data_add_array_int(struct rte_tel_data *d, int x);
> >
> > /**
>
> when adding __rte_experimental api i have been asked to add the
> following boilerplate documentation block. i'm not pushing it, just
> recalling it is what i get asked for, so in case it's something we do?
> see lib/eal/include/rte_thread.h as an example
>
>
> ```
> * @warning
> * @b EXPERIMENTAL: this API may change without prior notice.
> ```
>
Ok, thanks for the notice.
Actually, related to this, since we are adding these functions as aliases
for existing stable functions, I would like to see these being added not as
experimental. The reason for that, is that while they are experimental, we
cannot feasibly mark the old function names as deprecated. :-(
Adding Thomas and David on CC for their thoughts.
/Bruce