From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F644A00C5; Mon, 19 Dec 2022 10:33:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ECE2440146; Mon, 19 Dec 2022 10:33:15 +0100 (CET) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 77D54400D4 for ; Mon, 19 Dec 2022 10:33:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671442394; x=1702978394; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=KDImT1kO8yXtr5dTdHhyvDwJp3+IrKCRCG8L7Ti8vwo=; b=QPNF+zFW5XbsXtZovRs/TqAhyJYNAr9Th1Asp7R2PX/WNFuFF8uezxbj omKytaRWolyxduqgXDcsZ2T++A/9jS1I0QS+LPJJSZY5H3YGQyIZInAbp SQvbyq3W1OP/gCalLuAWPnujoXOgsDaVfR+oYvkPbntoVq7zbQcGZ2kL0 +7YcNpJr7u23r3G4vHib8IqssUQnPYjfNHFZxSTm+V8+shjHANUka4drj e9/3UczZ4TaOyAgpHMdSAHqsdjFpP1Jloc0rEWO5R9rn6jbCaz4krXiSy YbD25EXK21I86WgfNOr6qrNkDsqXUfa0gq4mA9HNGkHR+Li42N/zTJxSd g==; X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="381535548" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="381535548" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2022 01:33:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="652632184" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="652632184" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga007.fm.intel.com with ESMTP; 19 Dec 2022 01:33:12 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 19 Dec 2022 01:33:12 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 19 Dec 2022 01:33:12 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 19 Dec 2022 01:33:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GZhV+8ohjjWgQz10M6u0EO+nulsfyF6+0IVRA61pbiYnhdW6d9QnTEeqTuqYa1YyOaOOQYXNVBCEKaaEx0NAGplG3ewCMtSQl9i87ACtyeOsoLuPFdFnVxBwStyKx68REloauKm8KYdXn49P6e9uazlKCNOoPIL2UoiNJR07TASG41zVv1+98CdyjaXTzOXnxvF0ZNVklRFS91+ohBseI2yu1ts7Y/4S/QnsjodikXaPsztIqshl/9c2X+L2IJWCZgLEewRyKr/+5iJ/VWhNnpJOYa8DHj6rFtmf3PDUNAUwfACr6awvw6hogWbsfsHhz5TFIGL8cBjPCDpBU9LdYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TJZOV2YoLH5PoIQRtpWIvvWllVrjJ/vklC9FfwN1Jh0=; b=mWgzaZCbXW+EHxmwPIkvU1au3FHhafS0FYTNYAoJOE5TWgs5m4Vb4kpzDfL/65UDffc7Gq14NzcwgZMDMwLb4MgBErfJ5K0K4MuXjIL4FtdPPoYMejOkh+WDXLosvJ6GLErlC2XjUmHYzuuu8tT9TE3S7mA1JTJ/T5EO3XoL/yVCHtLdpo2A0IC4cpOLfuy2/IBMxjenlk4oVXQk9qqwmdHrkZSI7t7MyamnP8wzBP84jRHr6fu6eWcTZZCFC24vGzYxIPmDd3sXOjHWdQKRUuMQJfXBNIWeowctjAyZUnUEc8thcq879JhtDalcR1Y4rg+fuX129gbYM79hNFG49Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by DM8PR11MB5574.namprd11.prod.outlook.com (2603:10b6:8:39::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Mon, 19 Dec 2022 09:33:10 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5ce5:e8ac:70b0:6908]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5ce5:e8ac:70b0:6908%9]) with mapi id 15.20.5924.016; Mon, 19 Dec 2022 09:33:10 +0000 Date: Mon, 19 Dec 2022 09:33:04 +0000 From: Bruce Richardson To: Chengwen Feng CC: , , , , , Subject: Re: [PATCH v5 2/5] telemetry: fix repeated display when callback don't set dict Message-ID: References: <20221219090723.29356-1-fengchengwen@huawei.com> <20221219090723.29356-3-fengchengwen@huawei.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20221219090723.29356-3-fengchengwen@huawei.com> X-ClientProxiedBy: LO4P265CA0166.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:312::10) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|DM8PR11MB5574:EE_ X-MS-Office365-Filtering-Correlation-Id: 99322180-0826-4976-554b-08dae1a40aeb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bXfj69d/+PSsZJf8JBMln0adLC+d4BzctS2xYv207X3F68lhJEsKp5OTjBsYWYUiljtWqSmHO2uSCo9gUis/ojlKzcbzLvdghzHkqods5j0U3IA6CRxAhsssTLEr/dKu3xpeG390tSHhPmh5G8DxRQw/SiF2LR/S+1GsYqTd/J1Aqr18tq7+vHj7PY6K0Z9RO8qKmOS71hldzrl33z4J+9Sy+Z8T+O5LbWNp1Fpv2hHn1Q7Bl5ymzgAiZdYvGhroSHx6/H+mStYJC9vSsimVZNEESbd+K/td1f22DtdStq75TtwFTSR0hoNYoMpXz0vDZNDoVq0UYZYvd/pd8RTVISqhw4hUEE+USyes0Sx9JQNshdVS40tQDv7FWIIVUAN5GD5KjD9gREz23Dt60cu60h1JV4TnOtJviZZetNz9vwXo89jNnivPwU5wAPvBOQkCIVqZtjdKBMJqR/iX9e+Gha4+NmkJPVS6X9pEJl9nV97QVM5cX/pBzQLhE9J+rRQYuC8papjiMUmn/I14Sbu2RupWqVzLxY8TSo2uUMgArWCbtA1011gf6v5Z2V1K1l6+/1kds3+uDpV5lv2YCTwMJxXCOaJvj66rplZMXOkQL2m7JUmsDDWXozKouFyLqms6IIO4YiS0g+tozoaDsPh9Rg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(366004)(136003)(376002)(39860400002)(396003)(451199015)(8676002)(5660300002)(6916009)(4326008)(4744005)(44832011)(66946007)(66556008)(66476007)(2906002)(6506007)(6486002)(478600001)(6512007)(107886003)(6666004)(26005)(186003)(41300700001)(86362001)(38100700002)(82960400001)(8936002)(316002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nVBPzvX5enC2Iu5U+KmjxqngS5MCrD7BWAOsXWGeXOElqZIu+WWIqsYXt2YW?= =?us-ascii?Q?CC2+tKW3T088LT1qaMmLs+/Akne7+XIHDW9g8T7OHJkN702nkXW6ypuAdpcY?= =?us-ascii?Q?/bVjeNn2ZjOYusx5+5UTCUzLhZs+YVYf8fcxJyeqPO9MW/tq5bofDValkbHm?= =?us-ascii?Q?H74r20x0bqGuwR+dr7xO50PU9j9/E0mSSanpq/XSCNNAGycAVnM1N8YLDdAy?= =?us-ascii?Q?k6rHIV/tuQDIQ/axNLr4KdfefsX9XwBkPw/PBkS6Sp9aGA6kQX/79rP2Uhhl?= =?us-ascii?Q?19JaVslos5sU6FRTKUDf0gzDST9axx1fVbecz+ztZTotEA8eHzV7RPUS6mRc?= =?us-ascii?Q?FuYxIzU4gZPNw57EjNEbh3jGV+l/9kvJTtTtOY53imsKSzGbN1rWzVtB8arc?= =?us-ascii?Q?X91ppeUc6vAeR/5/zhx46gEacIxtgKucFsO6orFAXvaQTCTGB4uru62KkGsN?= =?us-ascii?Q?MIQI0mrkDVcI1OoT/k8ijikzcNnymb9dfk8DauwO59flC4cAZzg7l/1vOzqb?= =?us-ascii?Q?lVTdYStYwEIWioleQzIklWwsFQar4yTyzQ3O+pjwYp9QLlWC2emqrG03wtYa?= =?us-ascii?Q?rTW/E4+eY3IkIQJJ9nnTTORA74OKYFLOEl46wYqv34w3IV5fMIeHjU1m1dc/?= =?us-ascii?Q?sqQmIPMLkrYsoId8zD7v0EfbYkK0wpczHVZFkkb3GYTcjZnPuruFjvnuWpuE?= =?us-ascii?Q?0k/LnO+WtdUiNWX+TchjiRc5EIS/2AG14OR9jvaE3Rx+FBHjJYGtDtZ6Uf5Y?= =?us-ascii?Q?yh1oUgpgtpO+O1uVYtUswrdEk/6UsVefsoOTNyZgU28g32pOptTaj+rSuBzf?= =?us-ascii?Q?rCiqBgniNQwTfz4AxBMDCqp6rwWO+Wf2MLaxtxlkIz7fEIhlN33g0bVtW4ih?= =?us-ascii?Q?4kZpIUhgwTRoTA7z5+bwlTWpWyBS6emK0UQGA/Ezz7df4T7n9vyo72sFtpT7?= =?us-ascii?Q?tizi6iplvq8IY7Zk+3RvTvDcrqNvlhy/iME2znBUuYZgRuwpzmAzWxr0hOIQ?= =?us-ascii?Q?JzgBifTNykyCEssTJLyxlYoSWWsAbrcSZvHcysDun85wC5792RwvzUD7Wd2q?= =?us-ascii?Q?gi2qD7zgUF4x1DBw51w904hfggrNx8QiDpdH9OpRHt+pedw7DTp5C9A3cdH8?= =?us-ascii?Q?a0m2bYi5t1V1pXVyGlJZitmg1qJkiJU9Bx7sS7woxXZS+jmjWEQFzp+1MuEq?= =?us-ascii?Q?SM/03vJaREQN6uhIU+zput2J48Td3ACgqftjNRtq8vGOo9Y/CzZG5gFinOX/?= =?us-ascii?Q?lkhrws2eaVoUfVqO2wTjtAkfsHSxR2rYmETSf+maQU6+dGkDyUagkfcZij7/?= =?us-ascii?Q?1hhwhkrjpSi9iscAYEjzBEw3ngkB5TTdxhWHlR/Uz3Ei7kItOVSnLDhWa9s4?= =?us-ascii?Q?1v3+hXHsx3RjPjmsV/gVdUJBcg4vIQQg3udgjjk7AriOpXN1oYkMk48MXhWO?= =?us-ascii?Q?OsuefOQiZzhfv2ftmyI699SR40iEPgR2tYzOIxvZpPusUyWvpr1MWGf5Og9I?= =?us-ascii?Q?dfuqBe4UkR0DIZuaXOpZsA2nSQs584M8iMjv5c61v6zPSridXV3zmMVVqy1p?= =?us-ascii?Q?ZjyjzC8+1VsVviGGGC+A2pZay6xLD8faDb3uZX5HDqDEcC4yqxoJDEMIM2dD?= =?us-ascii?Q?Fg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 99322180-0826-4976-554b-08dae1a40aeb X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2022 09:33:10.1833 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0VIAje7xYzBPeBs6cZifIyuGpj4Wbsvd4YHbl+gdA5xnGYueS8ZPg/uKPyRwK3w6ZceP0stlK7j+3xjj4CwocPCef98KIrdQuAKXNWKhj2A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5574 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Dec 19, 2022 at 09:07:20AM +0000, Chengwen Feng wrote: > When telemetry callback didn't set dict and return a non-negative > number, the telemetry will repeat to display the last result. > > Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality") > Cc: stable@dpdk.org > > Signed-off-by: Chengwen Feng > --- Hi Chengwen, I'm a little curious about this bug. Can you describe some steps to reproduce it as I'm curious as to exactly what is happening. The fix seems a little strange to me so I'd like to investigate a little more to see if other approaches might work. Thanks, /Bruce