From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC278423AC; Wed, 11 Jan 2023 12:56:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F3FA40691; Wed, 11 Jan 2023 12:56:58 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id E22864014F for ; Wed, 11 Jan 2023 12:56:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673438217; x=1704974217; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=fJbDsvj1ZzTnmDottq89l2hiSH/o6Sfo9DfToThs+po=; b=BqSgfHc75zJu9Rw05o1WAjPf27/wLHufJzRLqvYAyktXThOkDfg7/FBm 1rXg8n475YFuJ5zsMYjYngQgaZWSbFnrtA81FYLUTi2BBDYR2oh+PI5n6 +JzZwZXxMzSSkaoH/QecCvG5xDgT5ySLg8sNQbegDh004R8uX1HJKQ5tL 5fnTHNjUGm2CSPl6YHruEliFKtVOrRIT8DS6YPT+XmKRm+45cSU41BoAZ FvqULussub6ReMQmDUGe/vOOVQQVi1Ns2MosTa8bIL51pvlYFzBYffUUr eKynE9K9kqIJiUsEarCrNA5PQrWlPTcDd6a4UTZjbIQQK+dSkG5rJBjAU Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="306911784" X-IronPort-AV: E=Sophos;i="5.96,315,1665471600"; d="scan'208";a="306911784" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2023 03:56:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="831340018" X-IronPort-AV: E=Sophos;i="5.96,315,1665471600"; d="scan'208";a="831340018" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga005.jf.intel.com with ESMTP; 11 Jan 2023 03:56:55 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 11 Jan 2023 03:56:55 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 11 Jan 2023 03:56:55 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 11 Jan 2023 03:56:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FG99SpZtrmoUH8Br+ecJN5olDgn9eYUNmPEHXRRehJPslmpsNwXJu5A1E5SeH1KV8TWtRl1NzQ9PJgcFx29YsLBSxd4DZ4P8wTtwuoSpJNban0RjPlegp58oSVpV6ePO4wrWrQU0fh+ESbSv/BqvT8RWtMycWIXadA5w+YtFJsynQTg9QUbkGGxRhkOc9FRX2PRpH/phQLwtWQgmw0uKCj6sQsncUx74at3mGtfZMPWH8KRXtxgCFdb1TSCYSYG1f0DSFcroBnTsSB77rWoN8WFBun20tvlnkER9KfPCZKk9xOQ0r1mc7yWCc6/Riu88zPnwiPqRCmnnfmKjZydUXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s8NFfQRMjzo346PdzBL3R1sC8c56VZv4JkuJARJaDeE=; b=RARosorwuEVx0NqXty2+m2imtOEmAYxb/STYqotO0FuwshTAoTefTvcaAy0n+iQb9yRmb01hnTPkBRRl7ZSEz9Kg54arkFdhJ1zuyx+upRIWbpgn1r6CFKQpJplki7C+RHH5f/dYjIYy+W4R0WYD6NDSTR8bcNpFvg+Bo35KX9P+4RESsnoB7/Yi516XqnPtdnT0qh82VWElMoomILAtSoP4eO1gM5digDEtDhTPUx2Y28qk2Oq7T7OjuJBzBy+u2xfDrwlmvVfLBUeVVFUwIDB7rl3e7bsEOmjupW8qnSFT+57StTwIg1s8Du9dB6KjokACEdPjldJr96UjFh4znQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA3PR11MB8023.namprd11.prod.outlook.com (2603:10b6:806:2ff::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 11:56:53 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4d9f:6867:2d53:9ee]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4d9f:6867:2d53:9ee%8]) with mapi id 15.20.5986.018; Wed, 11 Jan 2023 11:56:53 +0000 Date: Wed, 11 Jan 2023 11:56:47 +0000 From: Bruce Richardson To: Morten =?iso-8859-1?Q?Br=F8rup?= CC: Tyler Retzlaff , Subject: Re: RFC abstracting atomics Message-ID: References: <20230109225604.GA25566@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20230110201033.GC21476@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <98CBD80474FA8B44BF855DF32C47DC35D87651@smartserver.smartshare.dk> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87651@smartserver.smartshare.dk> X-ClientProxiedBy: LO2P265CA0311.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::35) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA3PR11MB8023:EE_ X-MS-Office365-Filtering-Correlation-Id: 10e17cdc-b678-4754-9aec-08daf3caee54 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0Xmag/E/s83ZJMrqOnb1xuLibbb1rkTimpAkUStlXsaV3rHzvkr+a7hEVPtiCMWfoJRA6Zoqltfgi/Ra1isXr5FFKxjc1dFPx8/PN3iGjmg8d53ymIoXcjkuirqvgz3/LD3EK2GHjFb9q8xsyEBDQAdMxhoj5YJdnlVDWDq71kiW23UUcySlVzgDTDNEowUIV3YDu+jY4Oqz7HsC2aeEzttdYKqA1cpqu3tZsCs0hxBj316B1VdsHpT8nzKYVgA2mtFZm8x6Pi8FzFnafUhNGIZ709ndTSjBfYqx0p4G8RNRB/nB0xcWkhY49kHcvibLyot2Onm42kn1rFRPLcniI7Mevahz9GS70k6N5Q/2F13PsNmodWZlxXzVmDKiAabbJ1IQAdcTctEfHl0WTMfHlombWH3RSfGg+JwmMA1EnwhCXccivDzSJfOTszh6eFgeGmMmViJs3iS4d5/kPzo156igmnVaW3IQ9FLNZdaoeMicutIwomsgykp18mv2UBUHIXWPSLznMuw05QsOC5JjUC/tnF5WF6TXvu6QRsK0qCayW8jXqngA8c0D9bJ34M9irGOiDvzz3wmAxjMjR7tAB56oFRykwKAy40RAHwD5xdUUaToAyRyA85F1AvN8QKpbUI31IO5PgK8FpItbVqPTXg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(136003)(39860400002)(366004)(376002)(396003)(451199015)(41300700001)(66476007)(4326008)(8676002)(7116003)(6916009)(66946007)(66556008)(86362001)(82960400001)(8936002)(44832011)(38100700002)(5660300002)(316002)(2906002)(3480700007)(6506007)(186003)(6486002)(26005)(6666004)(478600001)(6512007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?ElXLQ1g5d90veuduuVN3LXFmIC4dIziS6M2JkEccXDNH3A+RVZULueP6EN?= =?iso-8859-1?Q?7t8bibA5i4L03q4gt+GFHDAjwKy0QnDRZ9Kt9FX1MQEEfHWJ6l23YID6qw?= =?iso-8859-1?Q?ezZpjpRMCzqgRPG5qCA9uNpryVmEwvfMvEwEN3or8firTA2IvhDLtLqqCu?= =?iso-8859-1?Q?b0ZhDK3CAeKu7Oh94hm9SDa8c/tYfJrdp0niHVnbMpHYKjW1qapRLS1meR?= =?iso-8859-1?Q?GujjpD+HvWnc81jf5i2UfW5m/dpAg+D+Cg6H6CVYps9M8puPhrMtHFDBIp?= =?iso-8859-1?Q?Vl1szyhYzdFV21ulMAqsN7dZyvneC3fh/X7UWfqhdIMYTWdrmpSwMdvvzj?= =?iso-8859-1?Q?XpPYrma6lwmdAMs+cHDVsr31N45msn0B9LdLonVEs61fjsBfhsY1DgHa0w?= =?iso-8859-1?Q?nuYzhD+oBcxkfDsykgPOvp7dKK1PF8aREKt9M5KoEwz/aQ0d7P4/PRV3Ue?= =?iso-8859-1?Q?ezlZ5sNElZW5nRnxjAX+vCiyrltgQDytQ5fexyRniRtp7eXF+id42GW1ba?= =?iso-8859-1?Q?sGztm2vPBbKAjvRTU+4Xs9Qx7VtrgML96PulpXr3QKuhZVwHiT757bR9mF?= =?iso-8859-1?Q?CXz5rmtZAsAhgWmS5KV6SQJj9BJjYkWqEtxER44/rdAk1NQ6aQ+y4OKQeo?= =?iso-8859-1?Q?7CcS+tb1GjknCibqbeOaqYD36zihMinX5UgwwAdxpIPovoqTjaR/XamRSQ?= =?iso-8859-1?Q?PvdIJpU1auVK8NhOCzt+negGbHmmRDumoK0Qd9T6lzxRGpN6vJKwIxYqhg?= =?iso-8859-1?Q?OGHQoOCybaislZF++lgN55HSYEyU7yuy0SEd7u9THevfg6BbirY3X4/Zwc?= =?iso-8859-1?Q?pXZjZ7TebZE0B1INfLOPMGww6rTQtb7E1vrvti567V6rVmLx1mIMXeguUb?= =?iso-8859-1?Q?vI5spV70tSdZKsBTF1DYO+IB6nWPAc8Kf/ms1qlvxBXT+G5iieHJNQxrPF?= =?iso-8859-1?Q?1v4UZG3p9umr/W8hRvEpg2SJRUV/FNsFzX4W5vD7LSGhXHZIyDB1FNlVnH?= =?iso-8859-1?Q?JqbjKiMu3SENLWlKSoA2OBuNNmZQxdew3XCuracpyyP2cf6BZlNpSlNLIr?= =?iso-8859-1?Q?17kl+cQmCYqeo/ohxVWABKQd37y5yrlVcVZECe+Y5+JNtODyRHSZnEte+M?= =?iso-8859-1?Q?Pgq8BK26G8HiHbtJ9i0B9yWOMw+QfNSoIwBV1gwUcdEQ6hTfqO9JOZ++rG?= =?iso-8859-1?Q?TpZ04x8p7iA4bDXqQKRqmOYH2yCHIQA+qXr7LgkQqjGn2h1auZILpcerNp?= =?iso-8859-1?Q?4N2ogWS+XKrS80Lru+LmACNAybQezaqzDYH69H0h1nqJtQemkebBhoxCp0?= =?iso-8859-1?Q?oP/eVC16pxIFk4sYpWALzjjEGzzm6DSSOWx/tiUo7yueTG+Fke10xdvVeT?= =?iso-8859-1?Q?clHRL2j+bbanb6jqHWjTcZD2HpiyufGrTlKplVF67wB/1u45CHMBfmWXb/?= =?iso-8859-1?Q?rF2GO4gU6ogqWAJYJ6rNvcFCPeYywy3idyua6a1XkPj9DuHrzUJQugZVC1?= =?iso-8859-1?Q?BpG07nrYxe59sDs0I2KTGZqn2R/UGOaAq4fGOPz067K7u51I9639fA6Kwo?= =?iso-8859-1?Q?1rwLZ5hT0FCae2bF55jKnm+TpRLW9kSr+z3FdH9XbegRl3trbbK6mxpUK0?= =?iso-8859-1?Q?Irn5pyvdhfE2ydIadRApgnfCMcoe5M5kRVVU0by5yzXmq1jUPNGS9v8A?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 10e17cdc-b678-4754-9aec-08daf3caee54 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 11:56:53.5812 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yRGaqqE0fWxHv6OKaqjx2dUD5Ei6F1ZLH5ZOlBxQlwm0ZsqTlEZD66aPdjBeFFVQoMLSSu+QBel9or/3IBsMxXkSGywJSkA7oi/G+xJ8cOg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB8023 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jan 11, 2023 at 11:23:07AM +0100, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > > Sent: Wednesday, 11 January 2023 11.10 > > > > One additional point that just became clear to me when I started > > thinking > > about upping our DPDK C-standard-baseline. We need to be careful what > > we > > are considering when we up our C baseline. We can mandate a specific > > compiler minimum and C version for compiling up DPDK itself, but I > > think we > > should not mandate that for the end applications. > > Why not? > > And do you consider this backwards compatibility a build time or run time requirement? > > > > > That means that our header files, such as atomics, should not require > > C99 > > or C11 even if the build of DPDK itself does. More specifically, even > > if we > > bump DPDK minimum to C11, we should still allow apps to build using > > older > > compiler settings. > > > > Therefore, we probably need to maintain non-C11 atomics code paths in > > headers beyond the point at which DPDK itself uses C11 as a code > > baseline. > > Am I misunderstanding your suggestion here: Code can be C11, but all APIs and header files must be C89? > > Wouldn't that also prevent DPDK inline functions from being C11? > Yes, it would. Now, perhaps we don't need to ensure that our headers have strict C89 compatibility, but I think we need to be very careful about mandating that end-user apps use particular c standard settings when compiling their own code.