From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3C9E4246E; Mon, 23 Jan 2023 15:24:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 60748400EF; Mon, 23 Jan 2023 15:24:46 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 56955400D4 for ; Mon, 23 Jan 2023 15:24:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674483884; x=1706019884; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=ESMVolBedbSPx4s3SEDcmONIbDyhUgRRlVhLsUEdBcM=; b=LThoG8neJLMqq+xckTGeCkUo95wIH7tpYnOTEiJaZAWZBHOopHFCI3Zu rCg5ADLXYBhY8oTwmjaALDgsbcdD7L/RuLwb/DlHAMm+5w4pXK9DZlvLH PBV7Aw9Eh2w8qAXFn0wF1Q59OA4MXxu7ekSS68qvg/ozYifmyz0ERrDnV oUHF2Ei7Hh3vUnH+ctzqaW3CaByjWW/jo4Zj0mTjujEvViDsLBGefPaxL KhCrOcih5lulJ5UJ5wpk4MeBGWSMUfCZVr87D+Q8YCGgvual+7Y3oKEdU 6ffEziT710g5/d5llOiye5mlkrjefgp69q502A7t+qfiyz6jSnymxq1NC w==; X-IronPort-AV: E=McAfee;i="6500,9779,10598"; a="326082945" X-IronPort-AV: E=Sophos;i="5.97,239,1669104000"; d="scan'208";a="326082945" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2023 06:24:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10598"; a="769833780" X-IronPort-AV: E=Sophos;i="5.97,239,1669104000"; d="scan'208";a="769833780" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga002.fm.intel.com with ESMTP; 23 Jan 2023 06:24:39 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 23 Jan 2023 06:24:39 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 23 Jan 2023 06:24:39 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 23 Jan 2023 06:24:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HY6BLRVy2qVI7v9Tvu+Q905U5/JQjyvLlRp4QH/UC99yIs07lWOqgKe/ePAhZl5bdE4N7fwcxu4yRZXhBmE3idQusQ7pHfEF5lN7OES46bASoCWTY49dj/RGQzpHqJDwA688oFusnQbXGdXYyF5fmniGD6fkGhiDZJTzx/J2oc9qUcmVc5i+sgARYJhQmjG0RgaIu2dQpxHhW2LmbXcS5wg9WblL+7vhA+tmEUdFibPmexZ3Fpf27rQ+r0v2QuZQJRZ0OWMdzbN7ZLp6mOTHUZ+bghVnIeSKFZuvzQ94XMhBWoaip8k+BujrJjKj48H5N+j2EycY9LmZvUVJN9OGXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QhsdnDyBk4fWcBvbAaCT89G1bPosExS0Az7HtnAyXvA=; b=kdoHOyWEP4dVQY6MQz26GxY5RyK4Xzh8mwE1khSxBrdDc8h8sIWMdwSeIW70daOI2pTCTAoTTp7d0twcbYU4I0QW2K74+xbtYyAW3X8YGlNW+yhm0OCXhnXongoqmYcMNqllinyIM1iKa6mxfdWo1FjsVymQdoykUT4PTirno+CcjzJxJKW9X3GL2Sdq9QEvhW8IAo66TTMScsRcJWK769eO/M/9Z3N6ztTvPgto8YuUvl+XLSw9I6YRfZh83DQwrGDynFcNoFAHpusyxSw/CdCTArq6Pc98VBeO2eTY7RWasxkBWyT9ggfAQm8Mg0qfSCWHeHRAKvmNmm78nL/YwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by IA0PR11MB7211.namprd11.prod.outlook.com (2603:10b6:208:43f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Mon, 23 Jan 2023 14:24:36 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4d9f:6867:2d53:9ee]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4d9f:6867:2d53:9ee%7]) with mapi id 15.20.6002.027; Mon, 23 Jan 2023 14:24:36 +0000 Date: Mon, 23 Jan 2023 14:24:30 +0000 From: Bruce Richardson To: David Marchand CC: , Thomas Monjalon , Dodji Seketeli Subject: Re: [PATCH v4 0/3] Split logging functionality out of EAL Message-ID: References: <20220829151901.376754-1-bruce.richardson@intel.com> <20230120182154.481039-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P123CA0581.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:276::11) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|IA0PR11MB7211:EE_ X-MS-Office365-Filtering-Correlation-Id: 61519921-46e5-4c80-aca7-08dafd4d8e0c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pPShL24nrt9in/XzO5X5bU6kblBU26JtfuyHUyNeM+JW1VVER6s0hpNFLRmzHs28HSrbPqafx3vVg7n4znfvaL5yzWWGlQ91XpjkV+6avQFep9BcgyHNNVlTGVGM61ApVe3WJ2QvwmUkaJ2raveIFtjMwv3rQkj3wbvk17XG1hNkN6KQit+RI2B1Y3sKaU/x4BL/gpKT696jBvZjoEqCVgI4PyDF7vmxS6P67xlMHitufwRurHtzXnX3O8DRGuWTMpuME5Hc8+WGjkL6q1mF6Khq7NBgk2olQRQSYhRT2twRC+SJCOebD1gr9Aa4BQ7Lx8Yd98UlykyoGmhTQbljZdsRCu2QmVTIdi2VMuBcDCOo7gYfpRZPfwe2HgDAjcp/5P1cCuKYccJKQdTGOGOP8uaT1YEx6h29drMqC+aDwECsKKKk6yPUNiw6rHC+e6rw1e2c28qSj2dxqoybrgeyUkxpnMpW2XEU4GRoJCd3+Y8R8A6W7o6mNRa70IrSvQs09pJ2Mpt1yrEOYmVMI3qTJyTbrqrQGUbd5NzULv2iEX65VzsYEqFMDMhUrSCT3HPIB7B/jCLX1jq4yR9/7lInHWJGVZS5kVhgMf8LmXryTZ/6EtvgaSPTIN7JOxQ48ZtAMTm86IPm+cKSRBAdTa4Cbw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(396003)(39860400002)(376002)(136003)(346002)(451199015)(83380400001)(38100700002)(82960400001)(41300700001)(86362001)(44832011)(2906002)(8936002)(5660300002)(4326008)(6916009)(8676002)(26005)(53546011)(186003)(6512007)(6506007)(6666004)(66476007)(316002)(54906003)(66946007)(66556008)(478600001)(6486002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Sgw37UfiH4wBOybawkvngzBaitL2enU8cFjO4ST5a6ZaWOUOiS/D3pWnH9HC?= =?us-ascii?Q?aB5WAzRlOAWdv5ldAHNOn85ZZpi+OvxZDWoebPXD4g5ujswESasc7y8ZMC1n?= =?us-ascii?Q?lzt7xHSCJnCYlLmPyr4M+NbgpwSzLqS9EmpV2pwExg1O91pGKe01aAMIumsy?= =?us-ascii?Q?MMsSW1WL//vBXjlhFDbU6NIyFBAZotPqgyAmlIIvPpsCbOT/CJsRoV0gLfeK?= =?us-ascii?Q?/3LNOu22jQ14y4uVkSQ0GCteYKM/ROjEnc14O2UV9LQdYrgrJJHHASf4/qmb?= =?us-ascii?Q?Npu+48xoWXPbLgk3nyY5SCO8kHrOyV3noLv/WkFLrmdgolVGgxF0UviV4Fee?= =?us-ascii?Q?cdE+DSMD74jVyovG/wxxJw1TOWNUbrEFJT0a4U10AqTKeqLLcmZnw3xghoHb?= =?us-ascii?Q?7r7mZtaJmMeLDTVsjFU3+ohqX/oSlTkW4hR7jOkaGZdP3diYRwSQu3fpp4Mt?= =?us-ascii?Q?o6zmUwCtN7njXDQ85oVVqevkoXs9N5QXIp/WxI+sRpQJiIkd5mvp5if9X82m?= =?us-ascii?Q?dF3DeGvIrCzj3Y1RXrCdZ7GDXSsJduKUN9TM0TcC0tU4Oeb8juM3oEkz3zg3?= =?us-ascii?Q?yWhtE/fon/qU9pSydeXKSKr4Niu2szcMPaNbN3YywPkj/efLykj6YB4Gn4d2?= =?us-ascii?Q?FBjGiMjzct+NiHdakYCLgLmNNYWvx5QnJ24UHFCjQrYwuWzfzPA81XUjtBBN?= =?us-ascii?Q?pLs7g9mpo0d1p46uA58OvpyXP3EXZbso9FKET3LqSqifHLQxp+fXumdg3Iwb?= =?us-ascii?Q?o1QHVv3nqz7x/OP+Wnxxg45D+SUrT4YGNhTKAxE0O58uPSPZVdb+FKmSoqSI?= =?us-ascii?Q?krdG1Lhf7y0YlUGDd+5SoeXAtQ+aQSrCNC0TgezfEyzMDx/FdZjtlusFJwhM?= =?us-ascii?Q?YlFHwYJRW5XF6lWuOCkaosY7x3UBM0t4jVRNvcalajuIQMB9zWoHj2ehMd/y?= =?us-ascii?Q?EqkjrkFTULSYKUCGhJYLKeHr3dALuVUJmqLr1jbayhIpFEolgHYkoGAcB1Si?= =?us-ascii?Q?4Kt0rhoJRBb1PTLzhcFM1KuiPBHrUWUWz8/gOcOkW9FzNDFKsdj5Mt/hKjiU?= =?us-ascii?Q?FtoO1DtUF+1m3rXL0u7vq0wDKTmjvqFwTmfYpnsvn4Yo/rU78clhh2bWradZ?= =?us-ascii?Q?DW2mTnoVUJ/wYzswt3V6zbJZVIIqdIDxyrMQe0ttQkFfjhMX6AcTW2ZFs7fj?= =?us-ascii?Q?wRSYtKpKlb3x8n5WCE32YJ/txGUgNPSVj3mTehbhjcJWSH+eyYFN0lpeDG9U?= =?us-ascii?Q?GZb34t/3M1Rma95Rd6rxQ6pS23LHijZn/d1hGZLlE08vdv4WNC4wiX1x0w3o?= =?us-ascii?Q?2UwRC5U1s3EtPiWSGbQz4GNxZIVKFQ5tNKBCO1Yia2sJ1oZMACB2oQct0n1E?= =?us-ascii?Q?Bi+gissjVXt9qXqZYILbbWft20itNKzfpOcdoqC585aeZOk21KL24jl+1Zzt?= =?us-ascii?Q?TQCAou7+K19HpDCKV8sAWD7sj/Nq/DnpBNQsYfcVigqgpcY78JsNFIyIRIT4?= =?us-ascii?Q?xZTDx2e64ISgo9hgFNw/pRXzWE6arFZJMn4oycVB6K25AaBlPxjcba7lmyNQ?= =?us-ascii?Q?axZaPEWX5pWnK00+9ZcU8qbZeokjxOdxDDay+Yp8WSo6yBtyQA0XO3AwoOI6?= =?us-ascii?Q?wA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 61519921-46e5-4c80-aca7-08dafd4d8e0c X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2023 14:24:36.6038 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: t6Hmz+7Olk/nRoj1xacH2VJM3X8opg3hET6bcgz88Zwb2j4wOguvZ3A2sSOpMnWRTsqEKEC0R5MP3KKd54860gvDvw5JN9Tjhx9RIBJjwtQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7211 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, Jan 22, 2023 at 03:56:12PM +0100, David Marchand wrote: > Hi Bruce, > > On Fri, Jan 20, 2023 at 7:22 PM Bruce Richardson > wrote: > > > > There is a general desire to reduce the size and scope of EAL. To this > > end, this patchset makes a (very) small step in that direction by taking > > the logging functionality out of EAL and putting it into its own library > > that can be built and maintained separately. > > > > As with the first RFC for this, the main obstacle is the "fnmatch" > > function which is needed by both EAL and the new log function when > > building on windows. While the function cannot stay in EAL - or we would > > have a circular dependency, moving it to a new library or just putting > > it in the log library have the disadvantages that it then "leaks" into > > the public namespace without an rte_prefix, which could cause issues. > > Since only a single function is involved, subsequent versions take a > > different approach to v1, and just moves the offending function to be a > > static function in a header file. This allows use by multiple libs > > without conflicting names or making it public. > > > > The other complication, as explained in v1 RFC was that of multiple > > implementations for different OS's. This is solved here in the same > > way as v1, by including the OS in the name and having meson pick the > > correct file for each build. Since only one file is involved, there > > seemed little need for replicating EAL's separate subdirectories > > per-OS. > > There is another complication. > > The ABI check is not handling properly the case where symbols are > moved to the new log library (even though the dependency to librte_log > is explicit in librte_eal elf). > For now, I don't have a good way to handle this. > > A workaround to pass the check is to suppress those symbols wrt the eal dump: > [suppress_function] > symbol_name_regexp = rte_log > [suppress_function] > symbol_name = rte_openlog_stream > [suppress_function] > symbol_name = rte_vlog > > But this is not a good solution because we would be losing checks on > them for the rest of the v23 ABI life. > Right, I got error messages from the CI job for this too, but I also have no idea how to work around this. Perhaps we only get to move content between libraries when we do an ABI bump? Seems a bit restrictive, though. /Bruce