Re: [RFC PATCH 1/1] build: increase minimum C standard for DPDK builds

[Bruce Richardson <bruce.richardson@intel.com>]

On Thu, Jan 12, 2023 at 01:42:48PM +0100, Morten Brørup wrote:
> > From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> > Sent: Thursday, 12 January 2023 12.36
> > 
> > Set the default C language standard to be used for DPDK builds to C99.
> > This requires no actual code changes to build successfully.
> 
> Great!
> 
> > 
> > To ensure compatibility is kept for external apps using DPDK headers,
> > we
> > explicitly set the build parameters for the chkincs binary to the old
> > minimum standard of "gnu89". [NOTE: DPDK code does not compile and has
> > previously not compiled for pure c89 standard, so that stricter
> > requirement need not be checked.] By adding this additional check, we
> > can separately manage C standards used internally in DPDK builds and
> > that required in the build flags for external apps using DPDK.
> 
> It seems I have to accept this techboard decision for now. ;-)
> 
There is no techboard decision here - certainly not yet. There is plenty of
discussion still to be had. However, for now this RFC is being very
conservative - perhaps overly so.

/Bruce