From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A95AA423B5; Thu, 12 Jan 2023 13:47:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47BE242D22; Thu, 12 Jan 2023 13:47:43 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 7086B40E25 for ; Thu, 12 Jan 2023 13:47:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673527661; x=1705063661; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=2fdS/8YuojMLoe0QwxVb+2qHAiij77owOSxTmsN4EHY=; b=Rm8RSPVIznFCdh2YeN67aJajKKl0gKhTZfDjMAdXa89nQnldW8Vddc2X od1htPhY4YJ4rW1M96oZeNaYvWSJdBdGNmxbiWVRz6VjKBUl5IN7GfBII 0CjitG37Pk2COakbbwHKvzefXjavq1yPgrULgsj1LOe2E1/iaFMxSw6+z PiFs9EKclaVCnf/km5cnMjTaKpX8Z1HhhVfm87Y3fWToFAKVHWRMepQKF yw/cLHUO5PrEetWH6RW3w1E8WUr/hHJLdgBfvCEuNRBqPI/bvsZINWtr9 /5Iertg9uJi4dRfbfRoIaLL5U0PQ0aquQcbWLnnx0gQsFglG7okHFmz5s A==; X-IronPort-AV: E=McAfee;i="6500,9779,10587"; a="304071652" X-IronPort-AV: E=Sophos;i="5.97,319,1669104000"; d="scan'208";a="304071652" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2023 04:47:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10587"; a="986541433" X-IronPort-AV: E=Sophos;i="5.97,319,1669104000"; d="scan'208";a="986541433" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga005.fm.intel.com with ESMTP; 12 Jan 2023 04:47:40 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 12 Jan 2023 04:47:40 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 12 Jan 2023 04:47:39 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 12 Jan 2023 04:47:39 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 12 Jan 2023 04:47:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n4Q6BL+lIRIcHzk7Zh0ApVQLEA1ltepD10ZSWrBOf1EbJhKHjB4d8rMt/p/MV0mNeGk71UPrgB97walp5uMCd2YVamWAlPOYHdApunSe9ZJmzY7gd8+luQZR/eK4lA1l0TRePthhz+doVP4sKZapmDOLJCjXCshn7kysxazMdwWxE0rkHgUtr1ggxFDmWC3m/Dyi6r9tmbA5nH80Gt7lYqxG7N++DwI7bYvGod+4rlHRuMpgqVcJESxwGYeqmaC7PotS1nhHiQUc7auO1yDFYhfuv8nNPF974unxWMrMWwxdRoDCXAYB1uigVnB6QB/wMo6rs/qD3T+6PV5F9s8MBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JxhNQTVq1B/SOoG6aoT28C2MlZ/iDaTcT5NVH6mwZdQ=; b=nt1hzyd0IOt4+HwstBYmhDIJusvSzVyEBnaANZMMrA00cW/weR8L2w2B5bHp4oN9qndGcWqH5lTooBMBXhoffmcXKjCyEglz4QhHa8EnA2ztQUAsxLuEzbGwFNKLx+BwH/4ZO34/47lQDcxQds/21n6ewHYcyRWXOJ9q2F8e1IxMkeEyWQHXiWW+Sg60rBfFHyDUokn6A7W45a7nTphSQxFpQtD39A3F7tc1ltjRn22B97Cj49MldPQ9hn57ADgcSK/ohNzYLRKrue1sBU5LBn1c925X4Ypa5uqe2k1AJdBGHAALWGch+3i/xOIpcxfFRuPcKXaw1vtPQwV646QUIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MW4PR11MB6572.namprd11.prod.outlook.com (2603:10b6:303:1ee::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 12:47:31 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4d9f:6867:2d53:9ee]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4d9f:6867:2d53:9ee%8]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 12:47:31 +0000 Date: Thu, 12 Jan 2023 12:47:25 +0000 From: Bruce Richardson To: Morten =?iso-8859-1?Q?Br=F8rup?= CC: , , , Subject: Re: [RFC PATCH 1/1] build: increase minimum C standard for DPDK builds Message-ID: References: <20230112113556.47485-1-bruce.richardson@intel.com> <20230112113556.47485-2-bruce.richardson@intel.com> <98CBD80474FA8B44BF855DF32C47DC35D8766A@smartserver.smartshare.dk> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D8766A@smartserver.smartshare.dk> X-ClientProxiedBy: LO4P265CA0206.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:318::18) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MW4PR11MB6572:EE_ X-MS-Office365-Filtering-Correlation-Id: 9174d806-8b05-4869-6d9e-08daf49b2b8b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 82qTXDzOgWN2tvdx3tKHU1uEaR/h/efWMozX7kI+jjoyBA1CnjLi2IVAOGDlPc4IJz36v5JY4p1NEqfVrNEE46/rb4wwFK9MC3UTiDLamolvu8gpCKGbqADlQjA5hOxt/4waZo1wpW64YH6id9JHsDXFzW2iGQ0LKdrPN1/OqD69HoU4OB31DEFF0BqBVE2R3vHF33Z4lOWRuLUmKy5LzHGahhscn6PrmvkqbSZfa/1xcPT/F9m4+8nAoEXLgaOHYQDzdA7GB0J6jwdcBbP1itX90rDa8VODGuRWA+VHTl/ftfs/TPiSvJj1D2B/IOlfKKsH/52JMKbAhe9JkxiDG6C+UXbe8Xc4mNZS9TBrsXZ9hZ/GxVrlb9U4xE+gjcYLYT5UVJ+GYkEP8kC/OMGNsrS63l15R2x6BDQkv/TOMKi/4ytox74d7J4rbuVpSOAH4DOJPXnmzvUy2V0cHoESQtUYducMAnYPTLe556xbYV2sjRlx5vz/6tOx12Oj3Y3L059G6VtltxDx0EQvHmBf0U/0sD/1M/bKHNGYzYqCPSdVIn3mEpAa0U7/hyb2uPUd3PuBJDOy5i9k+x0d9myL3KD0b5Ei0RECF11i9lmjJkPpjb1eAa+ne+Oax7yguVw9w1Yve/YQKrF/57VvQY73JA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(396003)(136003)(346002)(376002)(39860400002)(451199015)(26005)(8936002)(5660300002)(2906002)(41300700001)(66556008)(4326008)(316002)(8676002)(6916009)(66946007)(66476007)(6512007)(38100700002)(86362001)(44832011)(186003)(6506007)(82960400001)(478600001)(6666004)(6486002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?mdB9R9oteRbeVcWaE4BrBo5JDc34UyzH7T+lN896jlZB9ya4co985ps+aD?= =?iso-8859-1?Q?ogf1waQ6DNfipsQDAc/IRInfawWv/EQgaZsLKf0ESH32Xdbqtgjqm/vjSr?= =?iso-8859-1?Q?/pAWrBzAXQWvssjyh3X36b1eruKNofjt1BiepTnJjvZ0FANZI+O2ezY5hk?= =?iso-8859-1?Q?uuIYohoRhgyMoTgTcmA2qsMjrbLxq1e/sd2LK+NBdbivfFluXAat/yKK1T?= =?iso-8859-1?Q?1C5rD747eVBYwnfRvaT/EX5vqYMeg+pK5rSe09eN5dBFXSnOIFOaT6DJi0?= =?iso-8859-1?Q?9jUhMrm0gkliHoTw5ANKj5QiyL3PJkoq61uck+3gffSmppVo5QHPXjiHAS?= =?iso-8859-1?Q?Q26ejP/0GAjoDnF2TsJ+QuzW4Sc/gsKvJwrT9YMtruXGVFyuFl76M11NFT?= =?iso-8859-1?Q?b/nqEvP5Eeptmoacm7/ZUiY/tJAXRI99XJh64LgZmPTk0pFjaQa//d1whS?= =?iso-8859-1?Q?Tlrm7n910GbOBezmXNdqPOmqhTUdNmsqqziSeYoJWognkTRmtTTD/ceQNj?= =?iso-8859-1?Q?I6SeJQN5CdEChH4NPZyLaOwmW36BepKI//XOf4Hv+JBjqWSHomGXQ3lBcq?= =?iso-8859-1?Q?CFN9zLJddnQ/Be5nSzm6/KR16r1Yl0jJ7oR30NPwyH/TK45fCPRVcIU/M6?= =?iso-8859-1?Q?CU9wgtL7xw4jv5rRfMBK9Q2D8RW+Fy1O7M2X6laJb9XynHJDB1tQTWLdSc?= =?iso-8859-1?Q?WnDRlBupH1kCw2qwXAU5Oj9wof7qp6/8V0waPNZMBdtI16mbuZb9uK7+J5?= =?iso-8859-1?Q?T1+5GpMc5oxa7KZPFB8JpM41faXorsWR90TI6iTftn7AigMFsCMzJealzJ?= =?iso-8859-1?Q?LugagM4XxpVrffNRkfxYkqq8gKxzkUECpGoTKiGlXPOw2oY9Zzo4O3ZwF2?= =?iso-8859-1?Q?AEEF/flZmXrsAcXOO13mCErpuzw4vDZDYUWWuC5iC/B9yUdKAfaPlipJQw?= =?iso-8859-1?Q?TsEcVbzWe1C5mLStWlHL+F1+2khRmgxkF80qe2yFJM1IfkPXO9tw4GHA6Y?= =?iso-8859-1?Q?DXJe2PDbZCmnMWdWU0UP06AywR2r6mukT5CLWJe44TpIGGLPkHAzgySHcM?= =?iso-8859-1?Q?BLocODLcQJu/jl41WP8QK9Q7+EP2Nz1YM6uiW8ndXPQeiz1n4PO4qtRunY?= =?iso-8859-1?Q?HD+/7/dYl/wGLqO9ykqBl27+rZN6UFdzEIU/xTGu+Eq5Wq5vcjb9V6WeAQ?= =?iso-8859-1?Q?MPlXQ19/LxYDIcRvG7/jX7Y1g2uDN5fnZypxEiDjX18lvYdnBjaIicoqNP?= =?iso-8859-1?Q?HFMKvnm0LZWCxoVAw2aw1FDtgXvXxvFzv28Ufw6UQFASa8hhqwjQ2eqeS0?= =?iso-8859-1?Q?wcWyOl+FmP3qyYJKdyGr1fQiAPqkA3zI6wvWgoHxc07W6/ZrXJuJiPePrz?= =?iso-8859-1?Q?0RgpFXRV/hFR9uEwFbe9hUgD0NV7JgobXffDqzx9pIQggd1CSJxcfXefW6?= =?iso-8859-1?Q?QM8p7/2nRP7aZZmKntan5KOW8MKKQ0S7iXvFFMCbOsSYt0A/AcYH7+fZ9o?= =?iso-8859-1?Q?UrcRVdaY9jWvSqhjtnQIB7CZ53jzts178TCXJSnXLukRYR0bksErJfZ7Bi?= =?iso-8859-1?Q?njxCVftFzyv2Q7Z1iay/OVhgSONrd6F3u8DJN6o5DnmxbtF87hSiJkTDdD?= =?iso-8859-1?Q?ayFD5ZkBcYXIarLbFx0p7rGO8NDPVcN3TnB2Z1aDhUzN0bxK9Z1bz80w?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9174d806-8b05-4869-6d9e-08daf49b2b8b X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 12:47:31.5418 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1WJ9Zg0IV2+OvivLWFKMgDybDpZ6qcZHuJX0maZVd6a3wwgcgd5GCCgG7DjHtlDa2CKkULvm4vxLCnKs1AMI6CDyin4k7P4ySxvbwUqlcAE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6572 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jan 12, 2023 at 01:42:48PM +0100, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > > Sent: Thursday, 12 January 2023 12.36 > > > > Set the default C language standard to be used for DPDK builds to C99. > > This requires no actual code changes to build successfully. > > Great! > > > > > To ensure compatibility is kept for external apps using DPDK headers, > > we > > explicitly set the build parameters for the chkincs binary to the old > > minimum standard of "gnu89". [NOTE: DPDK code does not compile and has > > previously not compiled for pure c89 standard, so that stricter > > requirement need not be checked.] By adding this additional check, we > > can separately manage C standards used internally in DPDK builds and > > that required in the build flags for external apps using DPDK. > > It seems I have to accept this techboard decision for now. ;-) > There is no techboard decision here - certainly not yet. There is plenty of discussion still to be had. However, for now this RFC is being very conservative - perhaps overly so. /Bruce