From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF984423FD; Tue, 17 Jan 2023 15:04:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 92ECD400EF; Tue, 17 Jan 2023 15:04:44 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 6820D400D4 for ; Tue, 17 Jan 2023 15:04:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673964282; x=1705500282; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=s2RSlTqXz6pmhxZnkpUF5i56pdG8MtX+L543H0+Z8hY=; b=Rv5Ya/hljZW9yKzZTYlSrQ/iMUpelMVBYrqhsRdwmk9YJYQS/STBMcaY bh27UZa3DpZtB9/oK8OFLOcOVX+xl7tmgK/23fDSxoiCEep97acJL/i7e oqzlhVddL7ghvrjp3l86vAiLpe1dZ/WUBJuctiBBrPeQKzb97nbhXPtos 9cejW+sQwJuS7bV7/zFD/TG5hic9P4mdsVl+Y0Bj1gl+DjI4nG26fiFKp 1NM1Ju4b0knkGS9afahkrwZQfC3iDgbxk18uPlXWEFJtdNplEnZrMcgzp nxkHNRugyVZjgnLJJTuD3EW+G+FlXWfqAdwfXo0yo9kXzZoe2K6Bg4ZPA Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="323395604" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="323395604" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2023 06:03:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="988128142" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="988128142" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga005.fm.intel.com with ESMTP; 17 Jan 2023 06:03:46 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 17 Jan 2023 06:03:46 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 17 Jan 2023 06:03:45 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 17 Jan 2023 06:03:45 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 17 Jan 2023 06:03:45 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f2RifTZ+rEE81XOuXXi0ecbgRyBuexM2oHXWE+DfEsdB9sYH4FGMSs6GIHzmH2XjKuUwKxPGK5bNj+rP0DfMpOozWopFt5CAL5u/PzLJltaaeD0tA4nbz8L0RnG7FkONEP+sN/RZOuKwPEkxJgmvsMhjtBvzrpYsLxT7002uPH3mgLfLlV+GgbO+cb1eLQQkdiApwkeLxryPvO98mmI3WPAchl/4invjXpHodrFzhGht+MMicboH5jmtiJEyzv80u2NttAfP/KkexjZ3wVGKSZRx5ysgpJWU4hrsaVio78h9WK6GruIakm4rBBvuTxlCfGlW/ITtvuf/LQJ6V/1d7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tDrBEttvsJtvVdKvwZP5K2/3nSZadQSQtSlzfDS5wKE=; b=bX2wf8S7/MU36xHxnzm90mVAS9csALP5+Qa58ff4o0vu2hy6RMXrMot7QHg+LoibwXO+O4MnhjY64cfLlG05T2iYXIiM53Au1RvVNAcFw8F0JdwMXI2/+GLlj4JgZ+JAYNguNJj8cG6b6I88BU2wJEL6iQDaece5/NfG53QdJYj/mb3ZKvU8LiP3BFuEYkYp0s044qvrT2bko93+MU8uW7pEnSdmEgvP6PykbWB8V3G+XlvuIrGdnUF4beCViG2tkwdTCWAseqdnkOMGJqFjpd/a+Hci4StcXyetuhoDaDML9zQvxWEYb81amNbDdIJk6UTDa79xaROu/6+3+9risA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CY8PR11MB7083.namprd11.prod.outlook.com (2603:10b6:930:51::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Tue, 17 Jan 2023 14:03:44 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4d9f:6867:2d53:9ee]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4d9f:6867:2d53:9ee%7]) with mapi id 15.20.5986.023; Tue, 17 Jan 2023 14:03:44 +0000 Date: Tue, 17 Jan 2023 14:03:37 +0000 From: Bruce Richardson To: "Jiang, Cheng1" CC: "thomas@monjalon.net" , "mb@smartsharesystems.com" , "dev@dpdk.org" , "Hu, Jiayu" , "Ding, Xuan" , "Ma, WenwuX" , "Wang, YuanX" , "He, Xingguang" Subject: Re: [PATCH v2] app/dma-perf: introduce dma-perf application Message-ID: References: <20221220010619.31829-1-cheng1.jiang@intel.com> <20230117015623.17606-1-cheng1.jiang@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO6P123CA0057.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:310::14) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CY8PR11MB7083:EE_ X-MS-Office365-Filtering-Correlation-Id: af636509-d611-445c-4ba3-08daf893a4dc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S7lbfKprclpnPsPuGTOu4fR7QoQ4dlMjvC/bvDnsSdaH3VjiYmiiBaOw0XIfSxymqKeV3rqg4ofa5roJN+B+coKfYg08ml3xOgnfAGzo4qK7MslDkA2kJLjSiYwCs24NPyG+V2GlY/NxSdGHY2DfeTdc1rN4Y+SKFZ7JCyCbe2l7XgPU/yTWXxTFAX11w+STyNLXdBzl5InI4gWIfY3CcFiVgr877oVPwN0Mt7R9/gIyEWgrYHYYXy70bTgQIn9F9o2XXpyRilpazT9enl/wYOH0a8kpopWFR9PItmfkm37Oq3ZEE7T2k7NQCHveOGPP7Sn200M/4vdR96141N/HT4MGek2UIHFPvKxnMn8B5IrC+JHuFzXiYre7KX+3idIHO5ueQM3RYGbspOM2mO+oOdgY85foSuj7sFkgkl9MbRZJFY9JkSOog99NBe24tN2TzOpA9fGsl5Py7vNol/RhxpQsvf1m+mrW/epQkWLvK40enEzT87pze2aheLahz0cwFVoVBrTJ2b3bjQi0XhVylDqzgJ6/UNkhwDvCiWpJ7bVx5WPQ0d/567IIIYgn5ksSwUh8lwgWDMShXGmWXZ9zLsvCCTw0ecmd+GYAkMud4Po2QvGlyFbcFqWVlXXtBudN789tdVJheKa2CTU+5aOXvA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(396003)(346002)(376002)(39860400002)(366004)(451199015)(86362001)(66946007)(66556008)(8936002)(44832011)(8676002)(6862004)(66476007)(2906002)(4326008)(82960400001)(83380400001)(5660300002)(38100700002)(6636002)(316002)(6666004)(6486002)(54906003)(41300700001)(478600001)(6512007)(107886003)(53546011)(26005)(186003)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Huw8c//bnALDMaHk+bAvqGUGBFYemV7dz6KMGIEyF/YrsISaJWokviWq8Xmq?= =?us-ascii?Q?cHz5+A6jiicpvBRAvZqAaxJEYikrMwlWWJGikfcI6UONTrjHfkxxAbSUJEtR?= =?us-ascii?Q?dSc7XjMEsPRWah6JVDfmUeSzJEZBGxxgfwYAzBvxtx9T8nckRt1gIDDbJKrk?= =?us-ascii?Q?EjJyG9BXdbaJRdCJhtafoy0YVSYlMAI4lg5Z+73nb7NGXCWkPOu42Q2aK7k1?= =?us-ascii?Q?J/ieeZk2x4uOnpxmdh0pX15jzL6ubq7Plw2z78UJ3+Kh5hiqXnG5XuPefyAo?= =?us-ascii?Q?grNS/QcrbcESj2Lp0TA+0azKtPS+SP8fIbs/IsScyVo1h8zVbDjNuu263c5D?= =?us-ascii?Q?hD6rmRwikxyQ3WKTiYVUE5PBM+f7qWPdK8D/RWBh3AvOry+tGF7quiL2fgiY?= =?us-ascii?Q?jmL55njqIEkmeGYEXDdSgF4bh+b0t3XwZ/4q8YVUTvuKpkaMKm7H2Or2X/mR?= =?us-ascii?Q?ilwOLyeSACFA1xH8NEf6vYMTt4WWVaajXiUUADfYrMkz+QaZINxIvZGaXP+0?= =?us-ascii?Q?fM1AaP79QcRs3/fp7OkVeq0717UuMyqURqseP35RLay0mmgeNwT4iJrdOYsM?= =?us-ascii?Q?Tjawi2ckOxJWjO+e+PK91j7JswejvvU/k7PP+IUgdM6T5cu9PGDdx2e0MSz8?= =?us-ascii?Q?2pUbOC0iCkSU3eayB1HLgxrXHSv8R7HKVITYseXbx69qcWrvfPK3SmgAC8XX?= =?us-ascii?Q?fCOpOJ0OmrRD8QJtN5vtJeotV7rVnyYr4sHMuDUpODFyawCacMj02ecHhGRO?= =?us-ascii?Q?RoZ5r9xVoS/vwmDhBVb2KCCYkodjZv0IaVJagIHMSLKySzGKM0QgCjCLKP7K?= =?us-ascii?Q?RGuh1EFc3LEWtVFPFK4Q/Y6w3EqXZNNq6AeTGuMBjB9WwU4mrrPAgEbA/ipO?= =?us-ascii?Q?BDKfp5FZKmg7mGQbt0yn+Qnd++Q8Ete7pa5ixjLr1j5wAFl6hMAmqHTI8EcC?= =?us-ascii?Q?ONFjHSDnfA3gRtDR6RiPetsoKToY8lzxlyyLwambfShKpFuivMmnbKyntX6f?= =?us-ascii?Q?b1Snj9iOn7Zpj3SzvVoEhOaZ6rX8+3uWk1x+n8ItJ3vq7dRHzqfWj2CBfegS?= =?us-ascii?Q?3ItAJ9+3X5lqPLsm0UkTsB6mMczd1989O43tZbXbsNBgUhB7cjo3wix9Pelp?= =?us-ascii?Q?8Kjuc40eCHqntvxUEViklwUWCUFPc7xH+IskaqOfRPXnINqgnqkv2/QM8W7R?= =?us-ascii?Q?u+0wiiXNQ8LJyqAuYRAZYcudO/uBPn+VPYS5QFf4kUSV2YsJ6mw03g8JPsEd?= =?us-ascii?Q?WDcjGTTue4vPS5Bsqh08P1kG9i4AmM8lNfQ/eZ/p1WmXcaFI8jFLDcaCJPuY?= =?us-ascii?Q?YNarDgJTVXjBmfzVrlD7bFPT0bGZPaHzd2PWTo8njlZek/DCmLdBfiIjbXW5?= =?us-ascii?Q?H+MxTgTgE8bWzrMtsRaNvwN+uGmVOiUa5dh9JkiFgRsm5NuEhdKXoJNbg86f?= =?us-ascii?Q?jsGMTrU4hS4u+GxkjLQQOiqzDF8TV/PZ2AB4r+X3w1Eom/mNRjS0HESBEVRk?= =?us-ascii?Q?OEjMjPKUC4PlKR719bmfihjWkD4IMPp2ZvZyXASGiTiVrfdpGccGdWeKKpFa?= =?us-ascii?Q?buo+1qf30XmheoeF/uIcnPLudqJQPxtRpt8GNO/9UgyGk17hAjXQd9hB6eOJ?= =?us-ascii?Q?k8c0wyeuuUEh8XR10bVkahE=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: af636509-d611-445c-4ba3-08daf893a4dc X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2023 14:03:43.8797 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XNyJ0YEy9e3TaW8d1JNIyIzR/9/3CQXxLr+PSQ08X9wZ72WfPypnPwaV5+qA+EantgP4XXzcPUMVUCfKN2izjHryjbQMQ8rR521uQjrlHLM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7083 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jan 17, 2023 at 01:54:50PM +0000, Jiang, Cheng1 wrote: > Hi Bruce, > > Thanks for your comments. > Replies are inline. I'll fix them in the next version. > > Thanks, > Cheng > > > -----Original Message----- > > From: Richardson, Bruce > > Sent: Tuesday, January 17, 2023 9:00 PM > > To: Jiang, Cheng1 > > Cc: thomas@monjalon.net; mb@smartsharesystems.com; dev@dpdk.org; > > Hu, Jiayu ; Ding, Xuan ; Ma, > > WenwuX ; Wang, YuanX > > ; He, Xingguang > > Subject: Re: [PATCH v2] app/dma-perf: introduce dma-perf application > > > > On Tue, Jan 17, 2023 at 01:56:23AM +0000, Cheng Jiang wrote: > > > +#if !defined(RTE_EXEC_ENV_LINUX) > > > + > > > +int > > > +main(int argc, char *argv[]) > > > +{ > > > + printf("OS not supported, skipping test\n"); > > > + return 0; > > > +} > > > + > > > > What is linux-specific about this app? > > > > If we do need to limit the app to Linux-only I suggest using meson to do so > > rather than putting #ifdefs in the code. > > Got it. Thanks! > Can you maybe clarify what is linux-specific about this app, or else perhaps test at least building on FreeBSD and windows. I'd rather not see stuff added just for Linux without some attempt to try on other OS's. /Bruce