From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C84BA41BBF; Fri, 3 Feb 2023 18:11:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 72AB742D10; Fri, 3 Feb 2023 18:11:21 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id DCFA64067B for ; Fri, 3 Feb 2023 18:11:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675444280; x=1706980280; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=HPrnkJlrlho03T7I04+d8LPfm700tmyc+4sYkbUmims=; b=dDxRWi3RvAn7RB26aOA1cEwpte5Ggbkotunq1ebs3461gnfIyWuUpq3B 5xU2eC6O5syPLFCa/FVKXLeDA1E4stT8WYljJQ3HfIoH3UQHuZBpMe/Y0 PyZIN77hatIzPqJJN8YeOTgVQtsKw0vf3S922AdTkEFfxxmEWRdH4+m5h +V78lvQhz7fqOa0UoyQcROMdBNaJv3qWji8tWEadeY20icBpsbMXJnyG2 mUNxWwNNbw66KBISO0/69k1EoA5kbZAGN3fRje+1u7asP1SeQ6bMf2t6t RXVQLYDSE2HXKqMP4zRTHk28HtaNjk0i5ZXoELb8chbhXSbfHw5vaG+jF A==; X-IronPort-AV: E=McAfee;i="6500,9779,10610"; a="393387789" X-IronPort-AV: E=Sophos;i="5.97,271,1669104000"; d="scan'208";a="393387789" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2023 09:07:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10610"; a="911220493" X-IronPort-AV: E=Sophos;i="5.97,271,1669104000"; d="scan'208";a="911220493" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga006.fm.intel.com with ESMTP; 03 Feb 2023 09:07:53 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 3 Feb 2023 09:07:53 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 3 Feb 2023 09:07:52 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Fri, 3 Feb 2023 09:07:52 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Fri, 3 Feb 2023 09:07:47 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aAYI4svB/GT7cNgzHG546NS16WnxRB+gduHNIduFcyKoGvNP5J7KWj2kCAvcOF5YjGLZ+a39OlLRzPT8Zt5bhq75TluwJb7X7EhVnJE1PtdJKOxnOLhTXwcuz5LgIUp9DvFJhbwxCEw+r284XTny3z6m0tMQQYuBKRULn7jSOITvE/tYqTAa/RHTXrm5CDYP7cSGI/ujJzFgMGj8OAWRkxOG2CHDgEKcO0b0NtHk/Sxckh5tobrlQZMMlfhmuEHSHZdNVOK52+aYiBG4YiUFqXHcD9roSHZ1YV8luS+HLL12H+aOXy+sKCXQqE4zFdbFS3YfNtHsGE1RuBuMTwDZVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RLkP5CdW2gANu+ASxA0dTwSyK72/uu1eDEtg+Yfb4FE=; b=hdsgN+24J/nloJKb8vJNMhsg+moDT8wJ5cKNb4YVWfB7IuwAGB5MN1SGpFxWzd6amJcHL53eNLKZr5F41a0IiHjs9wv1/E10gEmvHC2RgtGmWETFTyCbtrttNcFwHV4GzfW4Nl/kdtu5WbKPirpQN988y1CMzrm1M1CcHrEwdaPHFiUbLmhz4mcLzWRhCoDuBhFG3eCRtyo729Bc54X0DwARIZ1UeIJrpiKp3PABPSnOp86+TrTHqlWfRkTObvXuqJ57gO1S5gIHHtlmZ5AIjcCMI4TYO/jRykHpKGX7f6wimXnBegnzNDTXRpnJiT0Roi/Nlf+Q77PckCJ/YYPQ1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA1PR11MB6805.namprd11.prod.outlook.com (2603:10b6:806:24c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25; Fri, 3 Feb 2023 17:07:40 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::aaba:abb7:8794:def]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::aaba:abb7:8794:def%7]) with mapi id 15.20.6064.024; Fri, 3 Feb 2023 17:07:40 +0000 Date: Fri, 3 Feb 2023 17:07:33 +0000 From: Bruce Richardson To: Conor Walsh CC: , Subject: Re: [PATCH] dma/ioat: remove printf within ioat driver Message-ID: References: <20230203163514.621178-1-conor.walsh@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230203163514.621178-1-conor.walsh@intel.com> X-ClientProxiedBy: LO2P265CA0242.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::14) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA1PR11MB6805:EE_ X-MS-Office365-Filtering-Correlation-Id: cb210b40-95d9-4930-0bc4-08db060927e3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eK0PmI4qWzs25JBAovLGa6kXjY6Uu0XrQLeJJ7Mi2OFJjSFJ4AMJ7SRL8AsfFcWIy84foI9m3LASg0h7L37Hsw4wiIjf581qhLzfH1hLrLjqjc2CAwL8p2YMZ36IUjZ+QZWgk0mxxXpftcy/SHlTZL9j9iNF6PzXqlhF8zfrK31W3OxL6OV7JLYfgcVNn6eb8sHb7fZD2YLSiJNJyIw5k4KeYYWOZWumlEHQbcgW6YrMYVBwhZdF38lL3IOK+VbG/O/G6d8AKUPmqsxmik6KPnqGk58wwKpYwyLfu9XPOTcQFkG50jlTL0829zBAy9wyoYKnOEDfpaGZ3p5C8c2D7kcS2cYzCsBYr+EaSvo90Ys76vOL/8mWQRs9RKdstoOuR/qXz2Mca5TtRg3VEs2L+YVti7ViLd8tvrVZ3XC58pEyclbaWzf5aOf6gNLKgYuShLUVze5c/VyyB1jtKhcN8pzSw36R2n7BhfKWNmHbsZD+C+VDlDvtUVc00eT3vP8ZA7LyOzfl/jA9XRtuyD3QavJOMWi+B3f4JWeB2tj1uJzmDCrTuRQeGS+U79atewhqJCILL1s0/tPpLdY0TkpQAxxFsbbAKW+yncuvUlGybZ9v1l5cJ+OeiJJHy68lA9atbkEMsVa1ae68OC2Kf6i6GA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(39860400002)(366004)(376002)(136003)(396003)(346002)(451199018)(83380400001)(26005)(86362001)(6512007)(38100700002)(186003)(6506007)(478600001)(316002)(66476007)(6862004)(82960400001)(6636002)(6666004)(5660300002)(8936002)(41300700001)(66946007)(4326008)(6486002)(2906002)(44832011)(8676002)(66556008); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?77gQs7+JvWbVuRWKICb2AkOFCfBD9lK69X93xHoJuiKU2GwrhqKdXMb9YU85?= =?us-ascii?Q?aAsKMhHtbZXOGh1+HYpUzepUafLU/kVQky6hfHInVWhcTuJUT5NmfrkH6bpd?= =?us-ascii?Q?GBzg7yI7JgHtDctdRtaCTUa5WjCDye9407cj1sZOffhkSUgjGwi0F7iPAVGu?= =?us-ascii?Q?iJZtrPm80s8U3CxYDlZF5ZyZWIdw3g2Rt+4HarBKduEXknf56FL+M2MVWIra?= =?us-ascii?Q?NLAmAEmnVqG5Zja+1/t/gZFrwV/HOQaLDHROsnqjJEWsBouiLvNINYEJ+/Yv?= =?us-ascii?Q?iDXv6Q0pbEMHZAa/a5Aq2+zNn+C1D9GhIxnsI8zedvlTRhMI5inO6p80dTJk?= =?us-ascii?Q?FksFoxqz/D3Gl1qZfMmQC62by+hde2NJQ76I249DMpr1VZ2F0j0jIFl3otEs?= =?us-ascii?Q?o9VFVZbtN9QxLAvEIeMXl5kTlQG+mOrKPrIxal+W15rTpmpO3JhaKrkaSc04?= =?us-ascii?Q?97B7TIueaxiZZv7QIjdtkZuJ/DI+aZwu1OO/GyFxi/Gg7/RyUz8JHziD66vb?= =?us-ascii?Q?7XEmme7SvryBDZDQ2a84TL59szyuxcR8kd8XAvEdfvGLX780FGPLB42JXJhZ?= =?us-ascii?Q?yBQf0MxlI48wlNUfy4T1J/KyFbrkSvWlwgylwyXCpfaJ5bIikAW1ieLPxky5?= =?us-ascii?Q?DmPD3Wa0htngJcGP/dXHp+9syHBj4IxD/+60kHaHSYcLbRlqweHQ0riqLiMa?= =?us-ascii?Q?VFKFb9ndbqKVRbdId4NMBfw9GuKKVxCRS7fArwnnqu6LIYgO31RcEbAI8rv+?= =?us-ascii?Q?kp/k7LgirX0OdNFn9h/lG7w097R83zT97o/r2ba5xd4aFM4Zjbn5BPEZkU7Z?= =?us-ascii?Q?pQa8qMopcAyY/MKj90y+S1U2m0fsYHJlreI553IVFVKwvmZPXTsPAICUvm1o?= =?us-ascii?Q?E5N3/enJw7PFWh4m5tQ9pc7qFnp69DOZCzC/3tvagpKaW8iCyOi6CIgyPC8Z?= =?us-ascii?Q?JegTvvuEmNhLU7gDOJpftCuFLda94MSZ8QsCoHwDs+FjpE2pth4G8b9jsaw3?= =?us-ascii?Q?Bpp574jX5M+uxyRJSPOzWJkHG4qSL7HEn01bExOkOr/COOF2GFPrjOvEtc2M?= =?us-ascii?Q?rT9DrSXfYLXH2hdWGprWunWFuMxurXNuN/ajKuTwK8xlq15TPNBcmvFeIKde?= =?us-ascii?Q?yCzJoAhFnY2ARtHPKbJVlDmSui8zSetpUSTvHFjnL9m0WKHYq0bIL18fWAjS?= =?us-ascii?Q?ZcB+q0WD1pex5eJxfeyy/in3e/4fF6D1W52Hh41jdnTXJdhjJxOiA/hp8rnX?= =?us-ascii?Q?6tW7x16XJ6ZFE71emfhRHi9G8rnGicAtv5ZQqeIFDte05E5cn7G1lVd5yXcL?= =?us-ascii?Q?LLC3WEnAVobl7P0v+WJY9VwBhgr288fa+Z66GwhbLQle55rTf0NZooIAdAUM?= =?us-ascii?Q?UQ++xH2J1ZyOlEI3eHnxddef0MuNnUEj1iBsjw58G0LdNmKfgS9Qk6Yy5iPW?= =?us-ascii?Q?AKwSJ/9uOUnAUWvD15vvHQA7Hadv7WepO3JbIkrqcx4buYXCGjEetW0ESZpX?= =?us-ascii?Q?PpsMsF7+Q4gE4p+dMPEa/nZbNMcbdyPbP13i8iw+D43fGghqWzYGOnLa/9ZX?= =?us-ascii?Q?iMHIFQ5+S1CuhmjIVhuO1hF5DXVDjYyPdyEbmY4nkinLzoAZHnNld4eQTfmB?= =?us-ascii?Q?IpIJezo7Y4GRrW1/HuVZJdg=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: cb210b40-95d9-4930-0bc4-08db060927e3 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2023 17:07:39.9533 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xO/9ff6KH/RJNfERBkfm4dUFXSdWeeq/qOfN6U/OKsBMu2+ubSh38Ohvztpkde9Lb9d5SMLwTa6G87XB8PGcpLXl4wwRca4ypUF0mQ2dzBI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6805 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 03, 2023 at 04:35:14PM +0000, Conor Walsh wrote: > rte_log should be used instead of printf within the drivers this patch > changes a printf within the ioat dma driver's start function to an rte log. > The printfs within ioat's dump function will be retained. > > Signed-off-by: Conor Walsh > --- One little nit below, but with that fixed Acked-by: Bruce Richardson > drivers/dma/ioat/ioat_dmadev.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/dma/ioat/ioat_dmadev.c b/drivers/dma/ioat/ioat_dmadev.c > index 5906eb45aa..3fe50ea4a4 100644 > --- a/drivers/dma/ioat/ioat_dmadev.c > +++ b/drivers/dma/ioat/ioat_dmadev.c > @@ -146,9 +146,9 @@ ioat_dev_start(struct rte_dma_dev *dev) > /* Prime the status register to be set to the last element. */ > ioat->status = ioat->ring_addr + ((ioat->qcfg.nb_desc - 1) * DESC_SZ); > > - printf("IOAT.status: %s [0x%"PRIx64"]\n", > - chansts_readable[ioat->status & IOAT_CHANSTS_STATUS], > - ioat->status); > + IOAT_PMD_DEBUG("channel status - %s [0x%"PRIx64"]\n", > + chansts_readable[ioat->status & IOAT_CHANSTS_STATUS], > + ioat->status); > This whitespace change should not be needed, and we use only tabs for indent, not spaces. This should be a one-line change. > if ((ioat->regs->chansts & IOAT_CHANSTS_STATUS) == IOAT_CHANSTS_HALTED) { > IOAT_PMD_WARN("Device HALTED on start, attempting to recover\n"); > -- > 2.25.1 >