From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F258D41BAE; Thu, 2 Feb 2023 16:18:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C76E342D20; Thu, 2 Feb 2023 16:18:49 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id A7D7240EDC for ; Thu, 2 Feb 2023 16:18:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675351127; x=1706887127; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=fvAeJ79L4wCUejDLQzOEH5EBQQAZd7Y0MS82Fk/enzo=; b=DC7810FWcQICpY23E0pXmb6uLtSObpbIjCIRrA8Bo1DzdP8Ix2P00M5D mWQuRs86/PEblOXDN7TGnlEyEBFczagdWXFTl+90G82M+D9B5Pn+u0y5F VFF3n5XSXZ3y+Dxn0yzYPtHVcR9wm3ld/QDgVkw3gB5O8dP7d/Bdg/dNq 1sQFtbv7hL0zOoeR3gfxJ4JfNoAB/y5rve23kN/eE1xVxfFwxZEnoCom+ mxA3mar5TvtHXcRunhp+UZAGyE+XWahB6afqemjljvJ+Ta7Sdt1kNfcB6 kj6hO4ps06w0idJoKC1rjj7ewyPzWyDm61lpIK9KFDzndnB+27zGz4tLY Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="327119267" X-IronPort-AV: E=Sophos;i="5.97,267,1669104000"; d="scan'208";a="327119267" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2023 07:18:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="728911843" X-IronPort-AV: E=Sophos;i="5.97,267,1669104000"; d="scan'208";a="728911843" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga008.fm.intel.com with ESMTP; 02 Feb 2023 07:18:45 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 2 Feb 2023 07:18:44 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 2 Feb 2023 07:18:44 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 2 Feb 2023 07:18:44 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LYJ8IXqmgBbtweMm+VLTRWvlcqvDLUQs9rTWifmq0t9XXnf1A2PJeS8SpQ89QZOaTnRkWt0RXxAZnysZpODAXaoS09eWEyAiouIh89s94nKyhvpBEik1tZ9SXIxjC1Jx2sgaBkvs4xFqhOjeWxZf7DD/J62CV81vYYWpGldH9JzugD0gOV4/kKALamgGvV3tqzoTTDMkQToDWlUw0sbOa6er6NvdQpe3Iq6pMuwU0TPKV4SVgFliAnvhrB2H6xjbA8xu5eW10gNNLa+kiVD82dT8AnCpENnTEDD4G1T8De5LoGQFflSTdA9erltAbwSsyKlnolIF1PLxctD0T6MzPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mdxhdS74jjemeTTHiWz5Vy2JGse+fRFbArEf+tr1LxM=; b=VxJbZRAadVCtMFvD9fG6ysgsjUob0wvELVCS2IsYMP9jsZs4HS2oiZMIjIK6e0EIpkUbuT6C0ZwLmtLwSxN1YitdlXCy5/+6/Nc3xDRZQfRm9n/w6iriGsNsxAObANM/xGcA4HZ2G4l+6GlC+ULl7TIN1C4nf+AySNNEe3/o1cofP8bReHLznn02tEi0liL9l+3WLLPZtxDzra7ijOKDKgQ8VuliSgSWAXdRcuQLLTmPVnYhxUS8EWAFxe8KAgF7cHxnivgN297wr0ZgGSiRmC6EX1vRythxmuW5eR9BzzaLx6U++Ihq/wF1W5ko/b/QeElqTOcQTsNwlxQFbBIl3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MN2PR11MB4646.namprd11.prod.outlook.com (2603:10b6:208:264::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25; Thu, 2 Feb 2023 15:18:42 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::aaba:abb7:8794:def]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::aaba:abb7:8794:def%7]) with mapi id 15.20.6064.024; Thu, 2 Feb 2023 15:18:42 +0000 Date: Thu, 2 Feb 2023 15:18:36 +0000 From: Bruce Richardson To: "Zhang, Qi Z" CC: "Koikkara Reeny, Shibin" , "dev@dpdk.org" , "Burakov, Anatoly" , "Loftus, Ciara" Subject: Re: [PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration Message-ID: References: <20221214154102.1521489-1-shibin.koikkara.reeny@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P123CA0525.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2c5::8) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MN2PR11MB4646:EE_ X-MS-Office365-Filtering-Correlation-Id: 64be1550-4a4c-4345-f890-08db0530c506 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RGcjCGpgfVZExjYUXeF660Pr0L78xTquvtD1ZBv0OrcrZFwn4lGnoGQj/WA/rgR8w3By070e1LztRBynnEyqLwJwW0rQrmc9LQNeg6Z8gKmjWgQm8f8YxysfDWdDXNLMI3rwIyaXmFfEixP799LN6oFfXszAX/OsS32f7+LUHA4b361eOxemarH/hJ6ZuNuIxLI5lYClpDM1tnxC6zf+WKRRRdznmeYxabt3zed1vbEP5hiTi0PpnsYRciccylJ8KWHLqbS42GlkldrpKQVutOAYKqMxMsRFcNrEbEYtI71c1rY4drY2nEEkiT8xw8rfqnlp1bxjkoYMugeqbgC6gD9YNLXqpX9kEZS1Ph42obEPS2UiVG6todp+KlhebKGd46kBR62jAwQszFniUG9kC2qSDKE8Tu05I6s71hozeR0Fi2zYFbsYHDA0xrx0Jsuc1zCnjkW4SzsX+hpmuCfEzu53agyL/dR/dvsrSxfNL5RtD+p9zV8UM4AnoBAEhc6KssfVIX53RG8f/00ax+zHky9NXg5W/N85L2QJD4K+qJmwdrjwd5mC/KIqCbkDUQgXoNKDfwMaDw3IfBLbf5Xq1zYP8ZVsOgQ8Ub0A3Q6aZwrzrPBsT0VP/GNJrYL5YgkTocHh4S7+OMaYNYTUST5qYlWYaw8L+SASWnpE2dKNntA0qYcYcwEEHGOoikeHjST5131RWeFeQxPrcvGhD9g7LMuT0XCgt5NW/x+7WZIfQbXf85bZdTSmC6nA+DPRiPa0a7avJlRGcO8XsyztvjNirA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(396003)(366004)(346002)(136003)(39860400002)(376002)(451199018)(6636002)(8936002)(6862004)(54906003)(5660300002)(4326008)(2906002)(316002)(8676002)(41300700001)(66556008)(6486002)(66476007)(6512007)(107886003)(26005)(66946007)(478600001)(6666004)(6506007)(53546011)(186003)(966005)(83380400001)(38100700002)(44832011)(86362001)(82960400001)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WP9ekPMKwFbmxz+u4J/yIGCWTqfO2Dq7Hbf6Y+irA82GroBqA40rL30ATsC9?= =?us-ascii?Q?eeTGWK+rxu+t3oobqkSWTeZE+2I4SoxVOyddxPkEjKm8gYIxT8ji5/zrvy6E?= =?us-ascii?Q?McueYv90lalxMedJLLBojJUMeLsGpTXTVpDucJI8CSHIx3GPNWnwRMPgcXnb?= =?us-ascii?Q?PYsu+OEzINEUeRLrE/KkjGbsaF+N4iwfrHYRimCuyYgprRohokzvXMAb87nT?= =?us-ascii?Q?QU4ZT1zhMmN1chwI4wlJUAfQaPRp43K4OlFr3P0cWH3og9I6vx9WBhB/GwEQ?= =?us-ascii?Q?iZjFvJuxUCSMQ3uZpNL3llm+v2sn/JLk7fQSg8krdEbSfRBl0EpRbv5Rxuf+?= =?us-ascii?Q?p6ZYe8QtXMW1jtX2oPFlgzsceFTXs0hha9KDJ9ndBXPDJg+bvx0B+fPMJ+bG?= =?us-ascii?Q?spk/skD29DbyYF6UdSG3M2GgwDvKsjd/KTnbFNcMkkYqfkGYji5ynD72l3Gd?= =?us-ascii?Q?UpQNcUoz866FCBlfWDMWZPXOCszx+1/RR9xid+fqXZ+5fZSXEmosgs3tEtfH?= =?us-ascii?Q?D7pXX82+r7UjjqhJVk4Hpv7n9KGHcfjd4YW/lAcbY6wDBrOjPuLTDlu/Oki9?= =?us-ascii?Q?jj+HfnDAnI6pY5zZBnnS4ilDSPoQLMaYQa9IUHzwi+svfWKfWghmkU/ZGXjK?= =?us-ascii?Q?be5CzDRtuWwc3S1Da2jq1Ig/lOrgwy/ukgOagVgeygprAWEonPu6G2asJsHy?= =?us-ascii?Q?sCRlSksUmt9GpCKLJw7XQXaRMeqkChzGcJv8dQbon7WPEoGtkDJQd02FTVox?= =?us-ascii?Q?QeNPE/MLBr3BNu8plmG7P5zE4LCn5EhHzZWpYPJjmSRog81G2hY98X6eLHCy?= =?us-ascii?Q?BCQPCm/Ns48UmFs7NxY9Ugfae/jpnnmX8C9UXZ+IIZLCvtx3XF2XKK6JYqpl?= =?us-ascii?Q?fy8XLu1/oslNsoHS0qa775ARdkrOJkq7TDqViqQlBg4bqm/pdcyz83d1G/qj?= =?us-ascii?Q?gHznlvb/roCa8Fu8muX3Du6Rx79YbxersNDxjS4H/d4pVrEvmNrwV8zhb+gB?= =?us-ascii?Q?HTNen/aEQRmxuKWvC/3zUun11XZHYx5jhH6Hk+x1P0cxaIG3CONE9Bi6BE+O?= =?us-ascii?Q?UItaeXOQG7R0Csz73JS9H/l2pPpmHbwgm5N/d6GoIn0oIa3IfwKIrO+R5u8N?= =?us-ascii?Q?yWUHF1xu1WK4meLxLJaGiAVuC3gNjbZp22wWpJlKOeCi6UvzWsjSNW+feGq4?= =?us-ascii?Q?wA8t4tSdKH8Kq5GAXsCNEyBK6DBGeJPVTD63ib8CJhNFi1BM3w11qbb18jc/?= =?us-ascii?Q?90ZKrAPi84F84XOuUcGBFwFWHydsyk1JljhbP2g4yqbPXaUHpOALVQi/hnI0?= =?us-ascii?Q?wZrRz2QoKyUf1vf37gz+oilx4z2w3Q2cWqEmBHOUlRathkryCmtc0PUtOWSQ?= =?us-ascii?Q?UB2M0vFkz9bGoLUa51EpdJlLRA2gsxOtfFyR1qC51zXBmyoVOg0deoHxnRBK?= =?us-ascii?Q?1s9zoNtMfqol70ucDBt4/Q3mF09cyYVm7kiNFXZ146iy10ywGImMIQt4krxN?= =?us-ascii?Q?Wfx5YAVIJxhMa8u4Gm0PF5lm2MB1SolWIN9Q8AcJoar8QM217lpfCEL+13LX?= =?us-ascii?Q?1iQUj8K+ozU5pK/NwMUKi6I0EF/kFiLf9NOK8vSEJNUZnk1k4cw7138C/50z?= =?us-ascii?Q?JA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 64be1550-4a4c-4345-f890-08db0530c506 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 15:18:42.7226 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Wsu20iIPWbF5ohZDuEK1ibr2/xm4dQoMPpQBmIMBmXH9AYGuPgS1ECXxxNZ7jmxM+Zll1fnlfJgDeJkwHeTMRZA/hCjYZh6vnFjGKVbdWkk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4646 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Feb 02, 2023 at 02:49:52PM +0000, Zhang, Qi Z wrote: > > > > -----Original Message----- > > From: Koikkara Reeny, Shibin > > Sent: Thursday, January 19, 2023 11:10 PM > > To: Zhang, Qi Z ; dev@dpdk.org; Burakov, Anatoly > > ; Richardson, Bruce > > > > Cc: Loftus, Ciara > > Subject: RE: [PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration > > > > > > > -----Original Message----- > > > From: Zhang, Qi Z > > > Sent: Wednesday, January 18, 2023 12:10 PM > > > To: Koikkara Reeny, Shibin ; > > > dev@dpdk.org; Burakov, Anatoly ; > > > Richardson, Bruce > > > Cc: Loftus, Ciara > > > Subject: RE: [PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration > > > > > > > > > > > > > -----Original Message----- > > > > From: Koikkara Reeny, Shibin > > > > Sent: Wednesday, December 14, 2022 11:41 PM > > > > To: dev@dpdk.org; Burakov, Anatoly ; > > > > Richardson, Bruce > > > > Cc: Loftus, Ciara ; Zhang, Qi Z > > > > ; Koikkara Reeny, Shibin > > > > > > > > Subject: [PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration > > > > > > > > Integrate support for the AF_XDP CNI and device plugin [1] so that > > > > the DPDK AF_XDP PMD can work in an unprivileged container > > environment. > > > > Part of the AF_XDP PMD initialization process involves loading an > > > > eBPF program onto the given netdev. This operation requires > > > > privileges, which prevents the PMD from being able to work in an > > > > unprivileged container (without root access). The plugin CNI handles > > > > the program loading. CNI open Unix Domain Socket (UDS) and waits > > > > listening for a client to make requests over that UDS. The > > > > client(DPDK) connects and a "handshake" occurs, then the File > > > > Descriptor which points to the XSKMAP associated with the loaded > > > > eBPF program is handed over to the client. The client can then > > > > proceed with creating an AF_XDP socket and inserting the socket into > > > > the XSKMAP pointed to by the FD received on the > > > UDS. > > > > > > > > A new vdev arg "use_cni" is created to indicate user wishes to run > > > > the PMD in unprivileged mode and to receive the XSKMAP FD from the > > CNI. > > > > When this flag is set, the XSK_LIBBPF_FLAGS__INHIBIT_PROG_LOAD > > > > libbpf flag should be used when creating the socket, which tells > > > > libbpf not to load the default libbpf program on the netdev. We tell > > > > libbpf not to do this because the loading is handled by the CNI in this > > scenario. > > > > > > > > [1]: https://github.com/intel/afxdp-plugins-for-kubernetes > > > > > > > > Signed-off-by: Shibin Koikkara Reeny > > > > > > > > --- > > > > drivers/net/af_xdp/rte_eth_af_xdp.c | 337 > > > > +++++++++++++++++++++++++++- > > > > 1 file changed, 325 insertions(+), 12 deletions(-) > > > > > > > > diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c > > > > b/drivers/net/af_xdp/rte_eth_af_xdp.c > > > > index b6ec9bf490..196d98ad97 100644 > > > > --- a/drivers/net/af_xdp/rte_eth_af_xdp.c > > > > +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c > > > > @@ -7,6 +7,7 @@ > > > > #include > > > > #include > > > > #include > > > > +#include > > > > #include > > > > #include > > > > #include > > > > @@ -81,6 +82,24 @@ RTE_LOG_REGISTER_DEFAULT(af_xdp_logtype, > > > > NOTICE); > > > > > > > > #define ETH_AF_XDP_MP_KEY "afxdp_mp_send_fds" > > > > > > > > +#define MAX_LONG_OPT_SZ 64 > > > > +#define UDS_MAX_FD_NUM 2 > > > > +#define UDS_MAX_CMD_LEN 64 > > > > +#define UDS_MAX_CMD_RESP 128 > > > > +#define UDS_XSK_MAP_FD_MSG "/xsk_map_fd" > > > > +#define UDS_SOCK "/tmp/afxdp.sock" > > > > +#define UDS_CONNECT_MSG "/connect" > > > > +#define UDS_HOST_OK_MSG "/host_ok" > > > > +#define UDS_HOST_NAK_MSG "/host_nak" > > > > +#define UDS_VERSION_MSG "/version" > > > > +#define UDS_XSK_MAP_FD_MSG "/xsk_map_fd" > > > > +#define UDS_XSK_SOCKET_MSG "/xsk_socket" > > > > +#define UDS_FD_ACK_MSG "/fd_ack" > > > > +#define UDS_FD_NAK_MSG "/fd_nak" > > > > +#define UDS_FIN_MSG "/fin" > > > > +#define UDS_FIN_ACK_MSG "/fin_ack" > > > > + > > > > + > > > > static int afxdp_dev_count; > > > > > > > > /* Message header to synchronize fds via IPC */ @@ -151,6 +170,7 @@ > > > > struct pmd_internals { > > > > char prog_path[PATH_MAX]; > > > > bool custom_prog_configured; > > > > bool force_copy; > > > > + bool use_cni; > > > > struct bpf_map *map; > > > > > > > > struct rte_ether_addr eth_addr; > > > > @@ -170,6 +190,7 @@ struct pmd_process_private { > > > > #define ETH_AF_XDP_PROG_ARG "xdp_prog" > > > > #define ETH_AF_XDP_BUDGET_ARG > > > "busy_budget" > > > > #define ETH_AF_XDP_FORCE_COPY_ARG "force_copy" > > > > +#define ETH_AF_XDP_USE_CNI_ARG "use_cni" > > > > > > > > static const char * const valid_arguments[] = { > > > > ETH_AF_XDP_IFACE_ARG, > > > > @@ -179,8 +200,8 @@ static const char * const valid_arguments[] = { > > > > ETH_AF_XDP_PROG_ARG, > > > > ETH_AF_XDP_BUDGET_ARG, > > > > ETH_AF_XDP_FORCE_COPY_ARG, > > > > - NULL > > > > -}; > > > > + ETH_AF_XDP_USE_CNI_ARG, > > > > + NULL}; > > > > > > > > static const struct rte_eth_link pmd_link = { > > > > .link_speed = RTE_ETH_SPEED_NUM_10G, @@ -1129,7 +1150,8 > > @@ > > > > xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals, > > > > ret = xsk_umem__create(&umem->umem, base_addr, > > > umem_size, > > > > &rxq->fq, &rxq->cq, &usr_config); > > > > if (ret) { > > > > - AF_XDP_LOG(ERR, "Failed to create umem\n"); > > > > + AF_XDP_LOG(ERR, "Failed to create umem [%d]: > > > > [%s]\n", > > > > + errno, strerror(errno)); > > > > goto err; > > > > } > > > > umem->buffer = base_addr; > > > > @@ -1314,6 +1336,245 @@ configure_preferred_busy_poll(struct > > > > pkt_rx_queue *rxq) > > > > return 0; > > > > } > > > > > > > > +static int > > > > +init_uds_sock(struct sockaddr_un *server) { > > > > + int sock; > > > > + > > > > + sock = socket(AF_UNIX, SOCK_SEQPACKET, 0); > > > > + if (sock < 0) { > > > > + AF_XDP_LOG(ERR, "Failed to opening stream socket\n"); > > > > + return -1; > > > > + } > > > > + > > > > + server->sun_family = AF_UNIX; > > > > + strlcpy(server->sun_path, UDS_SOCK, sizeof(server->sun_path)); > > > > + > > > > + if (connect(sock, (struct sockaddr *)server, sizeof(struct > > > > sockaddr_un)) < 0) { > > > > > > seems the server address is hard coded as "/tmp/afxdp.sock", is any > > > spec we follows, or should we parse this as a devargs? > > > better add some comment or external link that help to explain this > > > > It was already hardcoded in the afxdp-plugins > > https://github.com/intel/afxdp-plugins-for- > > kubernetes/blob/main/constants/constants.go . > > OK, I saw this has been explained in your new doc patch. > > Reviewed-by: Qi Zhang > I would suggest the doc patch should be merged into this patch - code and doc should go together. Please do a v3 with both patches together, thanks. Assuming Qi is ok with it, you can probably keep his ack on the new version. /Bruce