From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00C53A0524; Mon, 19 Apr 2021 15:10:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E05B441283; Mon, 19 Apr 2021 15:10:36 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id E61DE4123B for ; Mon, 19 Apr 2021 15:10:34 +0200 (CEST) IronPort-SDR: CoWLr7qcTiitZVYH5lk4Oi4P2W1oYpmY0cfZZhoDWTp/F50EXV2jLur3Y4lVHfcXr8JVm69vlq JQFpEhpgIEYQ== X-IronPort-AV: E=McAfee;i="6200,9189,9959"; a="280646659" X-IronPort-AV: E=Sophos;i="5.82,234,1613462400"; d="scan'208";a="280646659" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2021 06:09:14 -0700 IronPort-SDR: D2MQznZCdgpM4DORqCbrXRnEL6LYk6Ydg9bHwfGr5g2fqpJ0z53eRq8NZGiyAbR5bW9zAot2qc +nnFu6mCNxDQ== X-IronPort-AV: E=Sophos;i="5.82,234,1613462400"; d="scan'208";a="462734214" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.30.74]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 19 Apr 2021 06:09:13 -0700 Date: Mon, 19 Apr 2021 14:09:09 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, bluca@debian.org Message-ID: References: <20210401115009.1063844-1-bruce.richardson@intel.com> <20210416170458.50188-1-bruce.richardson@intel.com> <3333564.j95ZaMVjHg@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3333564.j95ZaMVjHg@thomas> Subject: Re: [dpdk-dev] [PATCH 00/14] Build file updates X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Apr 19, 2021 at 02:20:47AM +0200, Thomas Monjalon wrote: > 16/04/2021 19:04, Bruce Richardson: > > RFC -> V1: * rebased to current main branch * performed cleanup on many > > meson.build files to ensure correct formatting of lists: * split lists > > with >3 or >4 entries to be one per line * first entry on own line * > > last entry on own line with "," * closing braces dedented to original > > indent level * alphabetical ordering Files in "lib" folder should be > > mostly ok now - files in the drivers directory have not been done to > > the same level, as there are so many of them to work on. * other > > general whitespace changes, including merging lines where possible, > > since indent levels are reduced > > There were 2 more suggestions in the RFC: - ignore-rev file to avoid > polluting git blame >From what I gather from reading the docs, an ignore-rev file can only be created after the patches are applied and we have the correct commit-ids to ignore. Therefore, I'm not sure what value there is in including one in this set since it would have to be completely rewritten on apply. > - devtools script to convert patches for backport Such a script would be to convert the "lib/librte_X" paths to "lib/X" in the patch files, correct? I can see about working on this for the next revision.