From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E70BA0524; Mon, 19 Apr 2021 16:23:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD1794130F; Mon, 19 Apr 2021 16:23:41 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id C3C9A412E6 for ; Mon, 19 Apr 2021 16:23:39 +0200 (CEST) IronPort-SDR: +4cL0iZpMENlYGJUur8tTc4jfiWsM/DWWJMlI5jctxUWG5Fz60wYXPXw39TWH7yXxhj8GviNW2 id029JQxe0fg== X-IronPort-AV: E=McAfee;i="6200,9189,9959"; a="215912876" X-IronPort-AV: E=Sophos;i="5.82,234,1613462400"; d="scan'208";a="215912876" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2021 07:23:38 -0700 IronPort-SDR: m8U0stlrJhi7hi2ug92ERI1cVp6DPt/aDQVS4n/JSaguoDpyvi9inkwxhQxvpbO4u34+KPt6Lr kHHoGRXA3QXQ== X-IronPort-AV: E=Sophos;i="5.82,234,1613462400"; d="scan'208";a="454332876" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.30.74]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 19 Apr 2021 07:23:37 -0700 Date: Mon, 19 Apr 2021 15:23:33 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, bluca@debian.org Message-ID: References: <20210401115009.1063844-1-bruce.richardson@intel.com> <3333564.j95ZaMVjHg@thomas> <1632968.CTq94apdVu@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1632968.CTq94apdVu@thomas> Subject: Re: [dpdk-dev] [PATCH 00/14] Build file updates X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Apr 19, 2021 at 03:47:49PM +0200, Thomas Monjalon wrote: > 19/04/2021 15:09, Bruce Richardson: > > On Mon, Apr 19, 2021 at 02:20:47AM +0200, Thomas Monjalon wrote: > > > 16/04/2021 19:04, Bruce Richardson: > > > > RFC -> V1: * rebased to current main branch * performed cleanup on many > > > > meson.build files to ensure correct formatting of lists: * split lists > > > > with >3 or >4 entries to be one per line * first entry on own line * > > > > last entry on own line with "," * closing braces dedented to original > > > > indent level * alphabetical ordering Files in "lib" folder should be > > > > mostly ok now - files in the drivers directory have not been done to > > > > the same level, as there are so many of them to work on. * other > > > > general whitespace changes, including merging lines where possible, > > > > since indent levels are reduced > > > > > > There were 2 more suggestions in the RFC: - ignore-rev file to avoid > > > polluting git blame > > > > From what I gather from reading the docs, an ignore-rev file can only be > > created after the patches are applied and we have the correct commit-ids to > > ignore. Therefore, I'm not sure what value there is in including one in > > this set since it would have to be completely rewritten on apply. > > OK I don't know how it works. I didn't either until I started using google for it! @bluca, please correct me if I'm wrong in my understanding above, or provide any advice about how to manage this?