From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7929A0C44; Fri, 16 Apr 2021 11:14:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 779681413D5; Fri, 16 Apr 2021 11:14:23 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 27E5614106F for ; Fri, 16 Apr 2021 11:14:20 +0200 (CEST) IronPort-SDR: 2aeY0ZVWMYNGGNfbo+LmnoWx9T4R5HHyqaU1gM0B118s+nPRLNWrL/jHW06QfxHzybg+Mzbog/ zjoObiqYFlLA== X-IronPort-AV: E=McAfee;i="6200,9189,9955"; a="192886859" X-IronPort-AV: E=Sophos;i="5.82,226,1613462400"; d="scan'208";a="192886859" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2021 02:14:19 -0700 IronPort-SDR: UWD4ucQ9JozSp2e9fPElPE2KJ7p73VP7Jltj4/IUbQcZ/aAXVAFAWAw2pISnyEWRERuWnoJ8hH nckGhfJZpl9A== X-IronPort-AV: E=Sophos;i="5.82,226,1613462400"; d="scan'208";a="522657019" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.29.105]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 16 Apr 2021 02:14:17 -0700 Date: Fri, 16 Apr 2021 10:14:13 +0100 From: Bruce Richardson To: Juraj =?utf-8?Q?Linke=C5=A1?= Cc: Dmitry Kozlyuk , "dev@dpdk.org" Message-ID: References: <20210415213629.30728-1-dmitry.kozliuk@gmail.com> <6a4acd6f8a6d47388ad27ba065f8fd41@pantheon.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6a4acd6f8a6d47388ad27ba065f8fd41@pantheon.tech> Subject: Re: [dpdk-dev] [PATCH] buildtools: fix all drivers disabled on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Apr 16, 2021 at 06:44:34AM +0000, Juraj Linkeš wrote: > > > > -----Original Message----- > > From: Dmitry Kozlyuk > > Sent: Thursday, April 15, 2021 11:36 PM > > To: dev@dpdk.org > > Cc: Dmitry Kozlyuk ; Juraj Linkeš > > ; Bruce Richardson > > Subject: [PATCH] buildtools: fix all drivers disabled on Windows > > > > buildtools/list-dir-globs.py printed paths with OS directory separator, which is > > "/" on Unices and "\" on Windows, while Meson code always expected "/". This > > resulted it all drivers being disabled on Windows. > > > > Replace "\" with "/" in script output. Forward slash is a valid, although non- > > default, separator on Windows, so no paths can be broken by this substitution. > > > > Fixes: 2e33309ebe03 ("config: enable/disable drivers in Arm builds") > > Cc: Juraj Linkeš > > This patch was only the latest that changed the code if the file, but not the logic related to path separators. I think you patch fixes the original commit ab9407c3addd. > > > > > Signed-off-by: Dmitry Kozlyuk +1 for the correction for the fixes line. Acked-by: Bruce Richardson > > --- > > buildtools/list-dir-globs.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/buildtools/list-dir-globs.py b/buildtools/list-dir-globs.py index > > 911e267335..d824360d39 100755 > > --- a/buildtools/list-dir-globs.py > > +++ b/buildtools/list-dir-globs.py > > @@ -17,4 +17,4 @@ > > if path: > > for p in iglob(os.path.join(root, path)): > > if os.path.isdir(p): > > - print(os.path.relpath(p)) > > + print(os.path.relpath(p).replace('\\', '/')) > > -- > > 2.29.3 > > >