From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5331CA09E4; Thu, 22 Apr 2021 10:39:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C1C8D413E6; Thu, 22 Apr 2021 10:39:09 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 5AE624069D for ; Thu, 22 Apr 2021 10:39:08 +0200 (CEST) IronPort-SDR: zX3UvDfWtlXDqU9742gosVupkG73l32kZs3zqvbGcZLSUxUhchdqs9its/cu5dcXl/bjC+g+fR HJNCTJZvyflQ== X-IronPort-AV: E=McAfee;i="6200,9189,9961"; a="175963689" X-IronPort-AV: E=Sophos;i="5.82,242,1613462400"; d="scan'208";a="175963689" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2021 01:39:07 -0700 IronPort-SDR: NXBQJKWP6qj0MW9ZaPzWUYjtP8eZsSr4Fienjl7emPn25dCBIqnIjTotQp1vJ6OFQ6ys3UQoU7 JPEpBDqXArrQ== X-IronPort-AV: E=Sophos;i="5.82,242,1613462400"; d="scan'208";a="524574081" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.30.122]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 22 Apr 2021 01:39:05 -0700 Date: Thu, 22 Apr 2021 09:39:00 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, John Griffin , Fiona Trahe , Deepak Kumar Jain , Nipun Gupta , Hemant Agrawal Message-ID: References: <20210421220358.2597249-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210421220358.2597249-1-thomas@monjalon.net> Subject: Re: [dpdk-dev] [PATCH] drivers: fix indentation in build files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 22, 2021 at 12:03:57AM +0200, Thomas Monjalon wrote: > A couple of mistakes slipped in the mass change. > > More mistakes could happen, especially when rebasing pending patches, so > we need an automatic check. > I have a partially-done script from when I was doing the original reindenting work, which I'll clean up a little and send on shortly. It only checks indent of lists and I'm extending it to check for trailing commas, but it may serve as a basis for further checks. On the plus side, it does automatic fixing of those issues though. Running it will probably show up more minor misses, so I'd suggest holding off on this patch until then. Regards, /Bruce