From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7EECA0A0E; Wed, 28 Apr 2021 12:48:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B340410E0; Wed, 28 Apr 2021 12:48:44 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 9AB7540147 for ; Wed, 28 Apr 2021 12:48:41 +0200 (CEST) IronPort-SDR: xPPG2g6JcgYzKEdeDmUcQnFDNiQmSw+ovKJBTHZYVDTBQbd4HclrTCv/dvrD3xIykaluCDmyW1 IYC05ypSTfyA== X-IronPort-AV: E=McAfee;i="6200,9189,9967"; a="176192012" X-IronPort-AV: E=Sophos;i="5.82,258,1613462400"; d="scan'208";a="176192012" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2021 03:48:40 -0700 IronPort-SDR: yGZHKUrs0uKreOUpGiwMIzrY87LizlIxAu6sMFPS4uWTFYIAKiXgfkle5FmYetmPdovYNF3wpw scqvruQp9Ong== X-IronPort-AV: E=Sophos;i="5.82,258,1613462400"; d="scan'208";a="447950827" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.12.50]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 28 Apr 2021 03:48:37 -0700 Date: Wed, 28 Apr 2021 11:48:34 +0100 From: Bruce Richardson To: Honnappa Nagarahalli Cc: "Ananyev, Konstantin" , "Yigit, Ferruh" , Stephen Hemminger , Jerin Jacob , Kathleen Capella , "thomas@monjalon.net" , "dev@dpdk.org" , Dharmik Thakkar , Ruifeng Wang , "david.marchand@redhat.com" , "jerinj@marvell.com" , "hemant.agrawal@nxp.com" , Stephen Hemminger , nd Message-ID: References: <20210426104720.2b892045@hermes.local> <81781e97-735c-f584-4148-ff07dedc5cb4@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] L3fwd mode in testpmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 27, 2021 at 11:17:24PM +0000, Honnappa Nagarahalli wrote: > Yes, this is what we have done. It is a new forwarding mode. > We could remove some forwarding modes from testpmd. For ex: macfwd, macswap seem very similar to iofwd mode. I'd suggest removing one of those two, but not both. Sometimes one is testing with a system behind a switch where correct mac addresses need to be used to ensure proper packet return. > > > > > In fact, l3fwd is also quite big and complex: > > $ wc -l examples/l3fwd/*.[h,c] |grep total > > 6969 total > > > > Plus it will introduce extra dependencies (fib, lpm, hash, might-be acl?) I am > > not sure it is a good idea to pull all these complexities into test-pmd. > I do not suggest pulling all these in. In our case, I see that the ask is only on LPM. I am open to hearing what others see as the requirement. > I think fib is the planned long-term replacement for lpm, and implements the same algorithm, so I think first versions should use it.