From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A270BA034F; Fri, 7 May 2021 11:50:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 878BF4013F; Fri, 7 May 2021 11:50:50 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 1138640040 for ; Fri, 7 May 2021 11:50:48 +0200 (CEST) IronPort-SDR: SAYnzOqfhdBmgDMjJELLqIrU/hPXwaYWEi2+CvtuwxIAYyfD2XSY8UWDqTdy6NIipDaB4RiRZI 7wMekifYZsOg== X-IronPort-AV: E=McAfee;i="6200,9189,9976"; a="178258103" X-IronPort-AV: E=Sophos;i="5.82,280,1613462400"; d="scan'208";a="178258103" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2021 02:50:47 -0700 IronPort-SDR: bQIYlTWkJpTXI/JCci4NZX2vHCKSFA0gYDpkapuoms5Ra9PhTPGCyhWHv8Sb4wtyWtXWTtwIVJ UU8gbdQ1qm0A== X-IronPort-AV: E=Sophos;i="5.82,280,1613462400"; d="scan'208";a="533420235" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.20.188]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 07 May 2021 02:50:45 -0700 Date: Fri, 7 May 2021 10:50:42 +0100 From: Bruce Richardson To: David Marchand Cc: dev@dpdk.org, Robin Jarry , Luca Boccassi , Juraj =?utf-8?Q?Linke=C5=A1?= , Honnappa Nagarahalli , Ruifeng Wang Message-ID: References: <20210507092158.12284-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210507092158.12284-1-david.marchand@redhat.com> Subject: Re: [dpdk-dev] [PATCH] build: fix drivers config with no python interpreter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, May 07, 2021 at 11:21:57AM +0200, David Marchand wrote: > If no enable_drivers option is passed, the default is to build the > drivers list by calling list-dir-globs.py. > > But if no python interpreter is installed, no error is reported and all > drivers end up being disabled. > > Example on a minimal FreeBSD vm: > > dpdk@freebsd:~/dpdk $ meson setup build > ... > drivers: > common/cpt: not in enabled drivers build config > common/dpaax: not in enabled drivers build config > common/iavf: not in enabled drivers build config > common/mvep: not in enabled drivers build config > common/octeontx: not in enabled drivers build config > common/octeontx2: not in enabled drivers build config > bus/dpaa: not in enabled drivers build config > bus/fslmc: not in enabled drivers build config > ... > > dpdk@freebsd:~/dpdk $ cd drivers/ > dpdk@freebsd:~/dpdk/drivers $ ~/dpdk/buildtools/list-dir-globs.py */* > env: python3: No such file or directory > > Rely on meson internal interpreter. > Check return code when calling this script. > > Fixes: ab9407c3addd ("build: allow using wildcards to disable drivers") > Fixes: 2e33309ebe03 ("config: enable/disable drivers in Arm builds") > > Signed-off-by: David Marchand > --- Acked-by: Bruce Richardson