From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62277A0548; Mon, 10 May 2021 10:49:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3BA0D40140; Mon, 10 May 2021 10:49:27 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 99E494003E for ; Mon, 10 May 2021 10:49:25 +0200 (CEST) IronPort-SDR: 4FvImw4BegRAfVxKguJFwCoztn64OKuPZ+ucfiapo8/6QgyKk542ZkYrZ7hMNhLRfJ/WrMVm5x 16caWvHdnToA== X-IronPort-AV: E=McAfee;i="6200,9189,9979"; a="196051016" X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="196051016" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 01:49:24 -0700 IronPort-SDR: U6PnDk1qmMoPuC/CNOF96xkqxL9LbRwefQCm0Y+yfVmCYFuPUgQvr5xa1QP7MlckfL2OZDGJ0q 4QspXWrTvoCw== X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="436049839" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.17.68]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 10 May 2021 01:49:22 -0700 Date: Mon, 10 May 2021 09:49:19 +0100 From: Bruce Richardson To: Akhil Goyal Cc: Matan Azrad , "dev@dpdk.org" , Suanming Mou , NBU-Contact-Thomas Monjalon , Shiri Kuzin Message-ID: References: <20210429154712.2820159-1-matan@nvidia.com> <20210504210857.3398397-1-matan@nvidia.com> <20210504210857.3398397-2-matan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, May 09, 2021 at 09:32:45AM +0000, Akhil Goyal wrote: > > > > + > > > > +fmt_name = 'mlx5_crypto' > > > > +deps += ['common_mlx5', 'eal', 'cryptodev'] > > > > > > I don't see a reason for eal dependency. Do you really need it? > > > > See RTE_LOG_REGISTER. > > Compilation works fine even after removing this dependency. > I believe it is internally managed in cryptodev. Yes, meson dependencies are recursive, so taking in e.g. cryptodev also pulls in all dependencies of cryptodev, including EAL. Having the deps explicitly called out makes things a little clearer for the reader, but having a minimum set of dependencies called out can make meson runs a little faster as it doesn't have as much checking and pruning of dependencies to do. [this was more a problem with older meson releases, less no now.] This is why the deps list in DPDK are generally fairly short. Either way, whatever builds is fine. :-) /Bruce