From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27FBCA0A0E; Mon, 10 May 2021 15:36:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 05C7640140; Mon, 10 May 2021 15:36:44 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id DBC0E4003E for ; Mon, 10 May 2021 15:36:42 +0200 (CEST) IronPort-SDR: nsxgQJVExTDA9F1x66jluYOrL09Z2hQbaZiGvvcUKKiWF4V8mrLtr5bBUVbzxBg8wRMKwLWijD zhf9ur+C/83A== X-IronPort-AV: E=McAfee;i="6200,9189,9980"; a="196102882" X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="196102882" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 06:36:42 -0700 IronPort-SDR: W9q+1MRv6BJFSKb9ZFfd8SCj5/279WKyrXR1qzU2aQpkOqjbsHdJyuU7/wVzXPr2nDkeGJcHXE cCb83syWZ4LA== X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="468130585" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.17.68]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 10 May 2021 06:36:39 -0700 Date: Mon, 10 May 2021 14:36:34 +0100 From: Bruce Richardson To: Kevin Laatz Cc: dev@dpdk.org, Sunil Pai G Message-ID: References: <20210507172025.181720-1-kevin.laatz@intel.com> <20210510125514.12914-1-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210510125514.12914-1-kevin.laatz@intel.com> Subject: Re: [dpdk-dev] [PATCH v2] raw/ioat: fix parameter shadow warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, May 10, 2021 at 12:55:14PM +0000, Kevin Laatz wrote: > In the function __idxd_completed_ops() we have a parameter shadow warning > due to a local variable having the same name as one of the function > parameters. This issue is fixed by simply renaming the local variable. > > This warning was discovered during an OVS build with DPDK 21.05-rc2. The > OVS build passes the -Wshadow flag by default, allowing the warning to be > seen. > > Fixes: 245efe544d8e ("raw/ioat: report status of completed jobs") > > Reported-by: Sunil Pai G > Signed-off-by: Kevin Laatz > Tested-by: Sunil Pai G > > --- Acked-by: Bruce Richardson