From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2742A0A0E; Mon, 10 May 2021 16:48:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4186540140; Mon, 10 May 2021 16:48:38 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 9B6C84003E for ; Mon, 10 May 2021 16:48:35 +0200 (CEST) IronPort-SDR: 7h31vWtqVhSRoFpLATAerq+9VXGfgNykVV1ZMM2oeK73rffVCL5rk4EBxxvvmzCYqSMAOWlDg0 qp5GfPBGYfjw== X-IronPort-AV: E=McAfee;i="6200,9189,9980"; a="196118060" X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="196118060" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 07:48:33 -0700 IronPort-SDR: 2OevsERKAO0T5o22xrD1VE61ECYO19owf2ytJgQbhNBCITf54FkfsoGAI2Fzr5er+9LD2lDlyL tSTfYGc67d/Q== X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="436171662" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.17.68]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 10 May 2021 07:48:31 -0700 Date: Mon, 10 May 2021 15:48:27 +0100 From: Bruce Richardson To: David Marchand Cc: Kevin Laatz , dev , Sunil Pai G Message-ID: References: <20210507172025.181720-1-kevin.laatz@intel.com> <20210510125514.12914-1-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v2] raw/ioat: fix parameter shadow warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, May 10, 2021 at 04:06:00PM +0200, David Marchand wrote: > On Mon, May 10, 2021 at 2:55 PM Kevin Laatz wrote: > > > > In the function __idxd_completed_ops() we have a parameter shadow warning > > due to a local variable having the same name as one of the function > > parameters. This issue is fixed by simply renaming the local variable. > > > > This warning was discovered during an OVS build with DPDK 21.05-rc2. The > > OVS build passes the -Wshadow flag by default, allowing the warning to be > > seen. > > A bit confusing. > -Wshadow only affects OVS code and there is no code calling this in > the OVS master branch. > > I did not see this issue while updating my dpdk-latest OVS branch and > running builds in GHA. > So I guess Sunil caught it with his patch: > https://patchwork.ozlabs.org/project/openvswitch/patch/20201023094845.35652-2-sunil.pai.g@intel.com/ > Yes, it was caught by Sunil in the course of his work. Ideally, I think -Wshadow would be a good flag to add to our DPDK builds, but it causes quite a number of errors right now to do so. Hopefully in a future release. /Bruce