From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, andrew.rybchenko@oktetlabs.ru,
ferruh.yigit@intel.com,
David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v3] log: register with standardized names
Date: Tue, 11 May 2021 12:59:49 +0100 [thread overview]
Message-ID: <YJpxtclzpERKKhKU@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20210511100927.824319-1-thomas@monjalon.net>
On Tue, May 11, 2021 at 12:09:27PM +0200, Thomas Monjalon wrote:
> From: David Marchand <david.marchand@redhat.com>
>
> Let's try to enforce the convention where most drivers use a pmd. logtype
> with their class reflected in it, and libraries use a lib. logtype.
>
> Introduce two new macros:
> - RTE_LOG_REGISTER_DEFAULT can be used when a single logtype is
> used in a component. It is associated to the default name provided
> by the build system,
> - RTE_LOG_REGISTER_SUFFIX can be used when multiple logtypes are used,
> and then the passed name is appended to the default name,
>
> RTE_LOG_REGISTER is left untouched for existing external users
> and for components that do not comply with the convention.
>
> There is a new Meson variable log_prefix to adapt the default name
> for baseband (pmd.bb.), bus (no pmd.) and mempool (no pmd.) classes.
>
> Note: achieved with below commands + reverted change on net/bonding +
> edits on crypto/virtio, compress/mlx5, regex/mlx5, baseband, bus and
> mempool drivers.
>
> $ git grep -l RTE_LOG_REGISTER drivers/ |
> while read file; do
> pattern=${file##drivers/};
> class=${pattern%%/*};
> pattern=${pattern#$class/};
> pattern=pmd.$class.${pattern%%/*};
> sed -i -e 's/RTE_LOG_REGISTER(\(.*\), '$pattern',/RTE_LOG_REGISTER_DEFAULT(\1,/' $file;
> sed -i -e 's/RTE_LOG_REGISTER(\(.*\), '$pattern'\.\(.*\),/RTE_LOG_REGISTER_SUFFIX(\1, \2,/' $file;
> done
>
> $ git grep -l RTE_LOG_REGISTER lib/ |
> while read file; do
> pattern=${file##lib/};
> pattern=lib.${pattern%%/*};
> sed -i -e 's/RTE_LOG_REGISTER(\(.*\), '$pattern',/RTE_LOG_REGISTER_DEFAULT(\1,/' $file;
> sed -i -e 's/RTE_LOG_REGISTER(\(.*\), '$pattern'\.\(.*\),/RTE_LOG_REGISTER_SUFFIX(\1, \2,/' $file;
> done
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>
> Changes since v2:
> - use RTE_LOG_REGISTER_DEFAULT in baseband, bus, mempool
> by adding the variable log_prefix in drivers/meson.build
>
> Changes since v1:
> - moved default logtype generation in the build system,
> - rebased,
> - reverted net/bonding change,
>
> ---
> doc/guides/contributing/coding_style.rst | 6 +++
> drivers/baseband/acc100/rte_acc100_pmd.c | 4 +-
> .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 4 +-
> drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 4 +-
> drivers/baseband/meson.build | 2 +
> drivers/baseband/null/bbdev_null.c | 2 +-
> .../baseband/turbo_sw/bbdev_turbo_software.c | 2 +-
> drivers/bus/dpaa/dpaa_bus.c | 2 +-
> drivers/bus/fslmc/fslmc_bus.c | 2 +-
> drivers/bus/ifpga/ifpga_bus.c | 2 +-
> drivers/bus/meson.build | 3 ++
> drivers/bus/vdev/vdev.c | 2 +-
> drivers/bus/vmbus/vmbus_common.c | 2 +-
> drivers/common/dpaax/dpaax_iova_table.c | 2 +-
> drivers/common/iavf/iavf_impl.c | 2 +-
> drivers/common/mlx5/mlx5_common.c | 2 +-
> drivers/compress/isal/isal_compress_pmd.c | 2 +-
> drivers/compress/mlx5/mlx5_compress.c | 3 +-
> drivers/compress/octeontx/otx_zip_pmd.c | 2 +-
> drivers/compress/zlib/zlib_pmd.c | 2 +-
> drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 2 +-
> drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 2 +-
> drivers/crypto/armv8/rte_armv8_pmd.c | 2 +-
> drivers/crypto/bcmfs/bcmfs_logs.c | 4 +-
> drivers/crypto/kasumi/rte_kasumi_pmd.c | 2 +-
> drivers/crypto/mvsam/rte_mrvl_pmd.c | 2 +-
> drivers/crypto/nitrox/nitrox_logs.c | 2 +-
> drivers/crypto/null/null_crypto_pmd.c | 2 +-
> drivers/crypto/octeontx/otx_cryptodev.c | 2 +-
> drivers/crypto/octeontx2/otx2_cryptodev.c | 2 +-
> drivers/crypto/openssl/rte_openssl_pmd.c | 2 +-
> .../scheduler/rte_cryptodev_scheduler.c | 2 +-
> drivers/crypto/snow3g/rte_snow3g_pmd.c | 2 +-
> drivers/crypto/virtio/virtio_cryptodev.c | 12 +++---
> drivers/crypto/zuc/rte_zuc_pmd.c | 2 +-
> drivers/event/dlb2/dlb2.c | 2 +-
> drivers/event/dpaa/dpaa_eventdev.c | 2 +-
> drivers/event/dpaa2/dpaa2_eventdev.c | 2 +-
> drivers/event/octeontx/ssovf_evdev.c | 2 +-
> drivers/event/octeontx/timvf_evdev.c | 2 +-
> drivers/event/opdl/opdl_evdev.c | 2 +-
> drivers/event/sw/sw_evdev.c | 2 +-
> drivers/mempool/dpaa/dpaa_mempool.c | 2 +-
> drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 2 +-
> drivers/mempool/meson.build | 3 ++
> drivers/meson.build | 6 +++
> drivers/net/af_packet/rte_eth_af_packet.c | 2 +-
> drivers/net/af_xdp/rte_eth_af_xdp.c | 2 +-
> drivers/net/ark/ark_ethdev.c | 2 +-
> drivers/net/atlantic/atl_ethdev.c | 4 +-
> drivers/net/avp/avp_ethdev.c | 2 +-
> drivers/net/axgbe/axgbe_ethdev.c | 4 +-
> drivers/net/bnx2x/bnx2x_ethdev.c | 4 +-
> drivers/net/bnxt/bnxt_ethdev.c | 2 +-
> drivers/net/bonding/rte_eth_bond_pmd.c | 3 ++
> drivers/net/cxgbe/cxgbe_ethdev.c | 4 +-
> drivers/net/dpaa/dpaa_ethdev.c | 2 +-
> drivers/net/dpaa2/dpaa2_ethdev.c | 2 +-
> drivers/net/e1000/e1000_logs.c | 8 ++--
> drivers/net/ena/ena_ethdev.c | 12 +++---
> drivers/net/enetc/enetc_ethdev.c | 2 +-
> drivers/net/enic/enic_ethdev.c | 2 +-
> drivers/net/failsafe/failsafe.c | 2 +-
> drivers/net/fm10k/fm10k_ethdev.c | 8 ++--
> drivers/net/hinic/hinic_pmd_ethdev.c | 2 +-
> drivers/net/hns3/hns3_ethdev.c | 4 +-
> drivers/net/i40e/i40e_ethdev.c | 8 ++--
> drivers/net/iavf/iavf_ethdev.c | 8 ++--
> drivers/net/ice/ice_ethdev.c | 8 ++--
> drivers/net/igc/igc_logs.c | 4 +-
> drivers/net/ionic/ionic_ethdev.c | 2 +-
> drivers/net/ipn3ke/ipn3ke_ethdev.c | 2 +-
> drivers/net/ixgbe/ixgbe_ethdev.c | 8 ++--
> drivers/net/kni/rte_eth_kni.c | 2 +-
> drivers/net/liquidio/lio_ethdev.c | 4 +-
> drivers/net/memif/rte_eth_memif.c | 2 +-
> drivers/net/mlx4/mlx4.c | 2 +-
> drivers/net/mlx5/mlx5.c | 2 +-
> drivers/net/mvneta/mvneta_ethdev.c | 2 +-
> drivers/net/mvpp2/mrvl_ethdev.c | 2 +-
> drivers/net/netvsc/hn_ethdev.c | 4 +-
> drivers/net/nfp/nfp_net.c | 4 +-
> drivers/net/null/rte_eth_null.c | 2 +-
> drivers/net/octeontx/octeontx_ethdev.c | 6 +--
> drivers/net/octeontx_ep/otx_ep_ethdev.c | 2 +-
> drivers/net/pcap/pcap_ethdev.c | 2 +-
> drivers/net/pfe/pfe_ethdev.c | 2 +-
> drivers/net/qede/qede_ethdev.c | 4 +-
> drivers/net/ring/rte_eth_ring.c | 2 +-
> drivers/net/softnic/rte_eth_softnic.c | 2 +-
> drivers/net/szedata2/rte_eth_szedata2.c | 4 +-
> drivers/net/tap/rte_eth_tap.c | 2 +-
> drivers/net/thunderx/nicvf_ethdev.c | 6 +--
> drivers/net/txgbe/txgbe_ethdev.c | 12 +++---
> drivers/net/vdev_netvsc/vdev_netvsc.c | 2 +-
> drivers/net/vhost/rte_eth_vhost.c | 2 +-
> drivers/net/virtio/virtio_ethdev.c | 4 +-
> drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 +-
> drivers/raw/ifpga/ifpga_rawdev.c | 2 +-
> drivers/raw/ioat/ioat_rawdev.c | 2 +-
> drivers/raw/ntb/ntb.c | 2 +-
> drivers/raw/skeleton/skeleton_rawdev.c | 2 +-
> drivers/regex/mlx5/mlx5_regex.c | 3 +-
> drivers/vdpa/mlx5/mlx5_vdpa.c | 2 +-
> lib/bbdev/rte_bbdev.c | 2 +-
> lib/bpf/bpf.c | 2 +-
> lib/cfgfile/rte_cfgfile.c | 2 +-
> lib/compressdev/rte_compressdev.c | 2 +-
> lib/eal/include/rte_log.h | 41 +++++++++++++++----
> lib/ethdev/rte_ethdev.c | 2 +-
> lib/eventdev/rte_event_timer_adapter.c | 6 +--
> lib/flow_classify/rte_flow_classify.c | 2 +-
> lib/graph/graph.c | 2 +-
> lib/member/rte_member.c | 2 +-
> lib/meson.build | 1 +
> lib/metrics/rte_metrics_telemetry.c | 2 +-
> lib/net/rte_net_crc.c | 2 +-
> lib/node/log.c | 2 +-
> lib/pdump/rte_pdump.c | 2 +-
> lib/rawdev/rte_rawdev.c | 2 +-
> lib/rcu/rte_rcu_qsbr.c | 2 +-
> lib/stack/rte_stack.c | 2 +-
> lib/vhost/vhost.c | 4 +-
> 123 files changed, 227 insertions(+), 184 deletions(-)
>
> diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst
> index 7601162c4f..f58ae948ff 100644
> --- a/doc/guides/contributing/coding_style.rst
> +++ b/doc/guides/contributing/coding_style.rst
> @@ -986,6 +986,12 @@ includes
>
> includes += include_directories('base')
>
> +log_prefix
> + **Default Value = pmd.<class>**
> + Some driver classes have a customized log prefix.
> + This prefix is combined with the driver name
> + when registering a default log name for the driver.
> +
> name
> As above, though note that each driver class can define it's own naming
> scheme for the resulting ``.so`` files.
> diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c
> index ca2703fbe1..68ba523ea9 100644
> --- a/drivers/baseband/acc100/rte_acc100_pmd.c
> +++ b/drivers/baseband/acc100/rte_acc100_pmd.c
> @@ -24,9 +24,9 @@
> #include "rte_acc100_pmd.h"
>
> #ifdef RTE_LIBRTE_BBDEV_DEBUG
> -RTE_LOG_REGISTER(acc100_logtype, pmd.bb.acc100, DEBUG);
> +RTE_LOG_REGISTER_DEFAULT(acc100_logtype, DEBUG);
> #else
> -RTE_LOG_REGISTER(acc100_logtype, pmd.bb.acc100, NOTICE);
> +RTE_LOG_REGISTER_DEFAULT(acc100_logtype, NOTICE);
> #endif
>
> /* Write to MMIO register address */
> diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
> index 026fc894d6..6485cc824a 100644
> --- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
> +++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
> @@ -24,9 +24,9 @@
> #include "rte_pmd_fpga_5gnr_fec.h"
>
> #ifdef RTE_LIBRTE_BBDEV_DEBUG
> -RTE_LOG_REGISTER(fpga_5gnr_fec_logtype, pmd.bb.fpga_5gnr_fec, DEBUG);
> +RTE_LOG_REGISTER_DEFAULT(fpga_5gnr_fec_logtype, DEBUG);
> #else
> -RTE_LOG_REGISTER(fpga_5gnr_fec_logtype, pmd.bb.fpga_5gnr_fec, NOTICE);
> +RTE_LOG_REGISTER_DEFAULT(fpga_5gnr_fec_logtype, NOTICE);
> #endif
>
> #ifdef RTE_LIBRTE_BBDEV_DEBUG
> diff --git a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
> index 1a72aa7b70..350c4248eb 100644
> --- a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
> +++ b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
> @@ -23,9 +23,9 @@
> #include "fpga_lte_fec.h"
>
> #ifdef RTE_LIBRTE_BBDEV_DEBUG
> -RTE_LOG_REGISTER(fpga_lte_fec_logtype, pmd.bb.fpga_lte_fec, DEBUG);
> +RTE_LOG_REGISTER_DEFAULT(fpga_lte_fec_logtype, DEBUG);
> #else
> -RTE_LOG_REGISTER(fpga_lte_fec_logtype, pmd.bb.fpga_lte_fec, NOTICE);
> +RTE_LOG_REGISTER_DEFAULT(fpga_lte_fec_logtype, NOTICE);
> #endif
>
> /* Helper macro for logging */
> diff --git a/drivers/baseband/meson.build b/drivers/baseband/meson.build
> index c98ebd9024..5ee61d5323 100644
> --- a/drivers/baseband/meson.build
> +++ b/drivers/baseband/meson.build
> @@ -12,3 +12,5 @@ drivers = [
> 'null',
> 'turbo_sw',
> ]
> +
> +log_prefix = 'pmd.bb'
> diff --git a/drivers/baseband/null/bbdev_null.c b/drivers/baseband/null/bbdev_null.c
> index 6cf3988b88..53c538ba44 100644
> --- a/drivers/baseband/null/bbdev_null.c
> +++ b/drivers/baseband/null/bbdev_null.c
> @@ -15,7 +15,7 @@
>
> #define DRIVER_NAME baseband_null
>
> -RTE_LOG_REGISTER(bbdev_null_logtype, pmd.bb.null, NOTICE);
> +RTE_LOG_REGISTER_DEFAULT(bbdev_null_logtype, NOTICE);
>
> /* Helper macro for logging */
> #define rte_bbdev_log(level, fmt, ...) \
> diff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
> index 85cf93d7bc..77e9a2ecbc 100644
> --- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c
> +++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
> @@ -35,7 +35,7 @@
>
> #define DRIVER_NAME baseband_turbo_sw
>
> -RTE_LOG_REGISTER(bbdev_turbo_sw_logtype, pmd.bb.turbo_sw, NOTICE);
> +RTE_LOG_REGISTER_DEFAULT(bbdev_turbo_sw_logtype, NOTICE);
>
> /* Helper macro for logging */
> #define rte_bbdev_log(level, fmt, ...) \
> diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c
> index 173041c026..2f48d4036b 100644
> --- a/drivers/bus/dpaa/dpaa_bus.c
> +++ b/drivers/bus/dpaa/dpaa_bus.c
> @@ -777,4 +777,4 @@ static struct rte_dpaa_bus rte_dpaa_bus = {
> };
>
> RTE_REGISTER_BUS(FSL_DPAA_BUS_NAME, rte_dpaa_bus.bus);
> -RTE_LOG_REGISTER(dpaa_logtype_bus, bus.dpaa, NOTICE);
> +RTE_LOG_REGISTER_DEFAULT(dpaa_logtype_bus, NOTICE);
> diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
> index 26910ac01f..becc455f6b 100644
> --- a/drivers/bus/fslmc/fslmc_bus.c
> +++ b/drivers/bus/fslmc/fslmc_bus.c
> @@ -666,4 +666,4 @@ struct rte_fslmc_bus rte_fslmc_bus = {
> };
>
> RTE_REGISTER_BUS(FSLMC_BUS_NAME, rte_fslmc_bus.bus);
> -RTE_LOG_REGISTER(dpaa2_logtype_bus, bus.fslmc, NOTICE);
> +RTE_LOG_REGISTER_DEFAULT(dpaa2_logtype_bus, NOTICE);
> diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
> index bb8b3dcfb9..62887da2d8 100644
> --- a/drivers/bus/ifpga/ifpga_bus.c
> +++ b/drivers/bus/ifpga/ifpga_bus.c
> @@ -472,4 +472,4 @@ static struct rte_bus rte_ifpga_bus = {
> };
>
> RTE_REGISTER_BUS(IFPGA_BUS_NAME, rte_ifpga_bus);
> -RTE_LOG_REGISTER(ifpga_bus_logtype, bus.ifpga, NOTICE);
> +RTE_LOG_REGISTER_DEFAULT(ifpga_bus_logtype, NOTICE);
> diff --git a/drivers/bus/meson.build b/drivers/bus/meson.build
> index c770c6ba1e..410058de3a 100644
> --- a/drivers/bus/meson.build
> +++ b/drivers/bus/meson.build
> @@ -9,4 +9,7 @@ drivers = [
> 'vdev',
> 'vmbus',
> ]
> +
> std_deps = ['eal']
> +
> +log_prefix = 'bus'
> diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
> index d075409942..281a2c34e8 100644
> --- a/drivers/bus/vdev/vdev.c
> +++ b/drivers/bus/vdev/vdev.c
> @@ -637,4 +637,4 @@ static struct rte_bus rte_vdev_bus = {
> };
>
> RTE_REGISTER_BUS(vdev, rte_vdev_bus);
> -RTE_LOG_REGISTER(vdev_logtype_bus, bus.vdev, NOTICE);
> +RTE_LOG_REGISTER_DEFAULT(vdev_logtype_bus, NOTICE);
> diff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus_common.c
> index 39b3308577..d25fd14ef5 100644
> --- a/drivers/bus/vmbus/vmbus_common.c
> +++ b/drivers/bus/vmbus/vmbus_common.c
> @@ -297,4 +297,4 @@ struct rte_vmbus_bus rte_vmbus_bus = {
> };
>
> RTE_REGISTER_BUS(vmbus, rte_vmbus_bus.bus);
> -RTE_LOG_REGISTER(vmbus_logtype_bus, bus.vmbus, NOTICE);
> +RTE_LOG_REGISTER_DEFAULT(vmbus_logtype_bus, NOTICE);
> diff --git a/drivers/common/dpaax/dpaax_iova_table.c b/drivers/common/dpaax/dpaax_iova_table.c
> index 54f89e12ba..3d661102cc 100644
> --- a/drivers/common/dpaax/dpaax_iova_table.c
> +++ b/drivers/common/dpaax/dpaax_iova_table.c
> @@ -462,4 +462,4 @@ dpaax_handle_memevents(void)
> dpaax_memevent_cb, NULL);
> }
>
> -RTE_LOG_REGISTER(dpaax_logger, pmd.common.dpaax, ERR);
> +RTE_LOG_REGISTER_DEFAULT(dpaax_logger, ERR);
> diff --git a/drivers/common/iavf/iavf_impl.c b/drivers/common/iavf/iavf_impl.c
> index 08147314c6..0c7d5c0dae 100644
> --- a/drivers/common/iavf/iavf_impl.c
> +++ b/drivers/common/iavf/iavf_impl.c
> @@ -85,4 +85,4 @@ iavf_free_virt_mem_d(__rte_unused struct iavf_hw *hw,
> return IAVF_SUCCESS;
> }
>
> -RTE_LOG_REGISTER(iavf_common_logger, pmd.common.iavf, NOTICE);
> +RTE_LOG_REGISTER_DEFAULT(iavf_common_logger, NOTICE);
> diff --git a/drivers/common/mlx5/mlx5_common.c b/drivers/common/mlx5/mlx5_common.c
> index d397459a3d..25e9f09108 100644
> --- a/drivers/common/mlx5/mlx5_common.c
> +++ b/drivers/common/mlx5/mlx5_common.c
> @@ -39,7 +39,7 @@ static inline void mlx5_cpu_id(unsigned int level,
> }
> #endif
>
> -RTE_LOG_REGISTER(mlx5_common_logtype, pmd.common.mlx5, NOTICE)
> +RTE_LOG_REGISTER_DEFAULT(mlx5_common_logtype, NOTICE)
>
> static bool mlx5_common_initialized;
>
> diff --git a/drivers/compress/isal/isal_compress_pmd.c b/drivers/compress/isal/isal_compress_pmd.c
> index 0ecca12a83..81b937ee73 100644
> --- a/drivers/compress/isal/isal_compress_pmd.c
> +++ b/drivers/compress/isal/isal_compress_pmd.c
> @@ -750,4 +750,4 @@ static struct rte_vdev_driver compdev_isal_pmd_drv = {
> RTE_PMD_REGISTER_VDEV(COMPDEV_NAME_ISAL_PMD, compdev_isal_pmd_drv);
> RTE_PMD_REGISTER_PARAM_STRING(COMPDEV_NAME_ISAL_PMD,
> "socket_id=<int>");
> -RTE_LOG_REGISTER(isal_logtype_driver, pmd.compress.isal, INFO);
> +RTE_LOG_REGISTER_DEFAULT(isal_logtype_driver, INFO);
> diff --git a/drivers/compress/mlx5/mlx5_compress.c b/drivers/compress/mlx5/mlx5_compress.c
> index 0581dee505..80c564f10b 100644
> --- a/drivers/compress/mlx5/mlx5_compress.c
> +++ b/drivers/compress/mlx5/mlx5_compress.c
> @@ -23,7 +23,6 @@
> #include "mlx5_compress_utils.h"
>
> #define MLX5_COMPRESS_DRIVER_NAME mlx5_compress
> -#define MLX5_COMPRESS_LOG_NAME pmd.compress.mlx5
> #define MLX5_COMPRESS_MAX_QPS 1024
> #define MLX5_COMP_MAX_WIN_SIZE_CONF 6u
>
> @@ -873,7 +872,7 @@ RTE_INIT(rte_mlx5_compress_init)
> mlx5_pci_driver_register(&mlx5_compress_driver);
> }
>
> -RTE_LOG_REGISTER(mlx5_compress_logtype, MLX5_COMPRESS_LOG_NAME, NOTICE)
> +RTE_LOG_REGISTER_DEFAULT(mlx5_compress_logtype, NOTICE)
> RTE_PMD_EXPORT_NAME(MLX5_COMPRESS_DRIVER_NAME, __COUNTER__);
> RTE_PMD_REGISTER_PCI_TABLE(MLX5_COMPRESS_DRIVER_NAME, mlx5_compress_pci_id_map);
> RTE_PMD_REGISTER_KMOD_DEP(MLX5_COMPRESS_DRIVER_NAME, "* ib_uverbs & mlx5_core & mlx5_ib");
> diff --git a/drivers/compress/octeontx/otx_zip_pmd.c b/drivers/compress/octeontx/otx_zip_pmd.c
> index bee90fc7cd..dd62285b86 100644
> --- a/drivers/compress/octeontx/otx_zip_pmd.c
> +++ b/drivers/compress/octeontx/otx_zip_pmd.c
> @@ -646,4 +646,4 @@ static struct rte_pci_driver octtx_zip_pmd = {
>
> RTE_PMD_REGISTER_PCI(COMPRESSDEV_NAME_ZIP_PMD, octtx_zip_pmd);
> RTE_PMD_REGISTER_PCI_TABLE(COMPRESSDEV_NAME_ZIP_PMD, pci_id_octtx_zipvf_table);
> -RTE_LOG_REGISTER(octtx_zip_logtype_driver, pmd.compress.octeontx, INFO);
> +RTE_LOG_REGISTER_DEFAULT(octtx_zip_logtype_driver, INFO);
> diff --git a/drivers/compress/zlib/zlib_pmd.c b/drivers/compress/zlib/zlib_pmd.c
> index 8a79d15c98..0220c6d038 100644
> --- a/drivers/compress/zlib/zlib_pmd.c
> +++ b/drivers/compress/zlib/zlib_pmd.c
> @@ -426,4 +426,4 @@ static struct rte_vdev_driver zlib_pmd_drv = {
> };
>
> RTE_PMD_REGISTER_VDEV(COMPRESSDEV_NAME_ZLIB_PMD, zlib_pmd_drv);
> -RTE_LOG_REGISTER(zlib_logtype_driver, pmd.compress.zlib, INFO);
> +RTE_LOG_REGISTER_DEFAULT(zlib_logtype_driver, INFO);
> diff --git a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
> index 0de51202a6..bc87e44a9d 100644
> --- a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
> +++ b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
> @@ -975,4 +975,4 @@ RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_AESNI_GCM_PMD,
> "socket_id=<int>");
> RTE_PMD_REGISTER_CRYPTO_DRIVER(aesni_gcm_crypto_drv, aesni_gcm_pmd_drv.driver,
> cryptodev_driver_id);
> -RTE_LOG_REGISTER(aesni_gcm_logtype_driver, pmd.crypto.aesni_gcm, NOTICE);
> +RTE_LOG_REGISTER_DEFAULT(aesni_gcm_logtype_driver, NOTICE);
> diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c
> index 03186485f9..a01c826a3c 100644
> --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c
> +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c
> @@ -2229,4 +2229,4 @@ RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_AESNI_MB_PMD,
> RTE_PMD_REGISTER_CRYPTO_DRIVER(aesni_mb_crypto_drv,
> cryptodev_aesni_mb_pmd_drv.driver,
> cryptodev_driver_id);
> -RTE_LOG_REGISTER(aesni_mb_logtype_driver, pmd.crypto.aesni_mb, NOTICE);
> +RTE_LOG_REGISTER_DEFAULT(aesni_mb_logtype_driver, NOTICE);
> diff --git a/drivers/crypto/armv8/rte_armv8_pmd.c b/drivers/crypto/armv8/rte_armv8_pmd.c
> index 3f6cb66ba2..c642ac350f 100644
> --- a/drivers/crypto/armv8/rte_armv8_pmd.c
> +++ b/drivers/crypto/armv8/rte_armv8_pmd.c
> @@ -864,7 +864,7 @@ static struct rte_vdev_driver armv8_crypto_pmd_drv = {
>
> static struct cryptodev_driver armv8_crypto_drv;
>
> -RTE_LOG_REGISTER(crypto_armv8_log_type, pmd.crypto.armv8, ERR);
> +RTE_LOG_REGISTER_DEFAULT(crypto_armv8_log_type, ERR);
>
> RTE_PMD_REGISTER_VDEV(CRYPTODEV_NAME_ARMV8_PMD, armv8_crypto_pmd_drv);
> RTE_PMD_REGISTER_ALIAS(CRYPTODEV_NAME_ARMV8_PMD, cryptodev_armv8_pmd);
> diff --git a/drivers/crypto/bcmfs/bcmfs_logs.c b/drivers/crypto/bcmfs/bcmfs_logs.c
> index 9faf12f238..08fd67af50 100644
> --- a/drivers/crypto/bcmfs/bcmfs_logs.c
> +++ b/drivers/crypto/bcmfs/bcmfs_logs.c
> @@ -21,5 +21,5 @@ bcmfs_hexdump_log(uint32_t level, uint32_t logtype, const char *title,
> return 0;
> }
>
> -RTE_LOG_REGISTER(bcmfs_conf_logtype, pmd.crypto.bcmfs.config, NOTICE)
> -RTE_LOG_REGISTER(bcmfs_dp_logtype, pmd.crypto.bcmfs.fp, NOTICE)
> +RTE_LOG_REGISTER_SUFFIX(bcmfs_conf_logtype, config, NOTICE)
> +RTE_LOG_REGISTER_SUFFIX(bcmfs_dp_logtype, fp, NOTICE)
> diff --git a/drivers/crypto/kasumi/rte_kasumi_pmd.c b/drivers/crypto/kasumi/rte_kasumi_pmd.c
> index 5ff1b5c562..48b7db9e9b 100644
> --- a/drivers/crypto/kasumi/rte_kasumi_pmd.c
> +++ b/drivers/crypto/kasumi/rte_kasumi_pmd.c
> @@ -639,4 +639,4 @@ RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_KASUMI_PMD,
> RTE_PMD_REGISTER_CRYPTO_DRIVER(kasumi_crypto_drv,
> cryptodev_kasumi_pmd_drv.driver, cryptodev_driver_id);
>
> -RTE_LOG_REGISTER(kasumi_logtype_driver, pmd.crypto.kasumi, NOTICE);
> +RTE_LOG_REGISTER_DEFAULT(kasumi_logtype_driver, NOTICE);
> diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd.c b/drivers/crypto/mvsam/rte_mrvl_pmd.c
> index bec51c9ff6..b2cfa710f5 100644
> --- a/drivers/crypto/mvsam/rte_mrvl_pmd.c
> +++ b/drivers/crypto/mvsam/rte_mrvl_pmd.c
> @@ -1019,4 +1019,4 @@ RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_MRVL_PMD,
> "socket_id=<int>");
> RTE_PMD_REGISTER_CRYPTO_DRIVER(mrvl_crypto_drv, cryptodev_mrvl_pmd_drv.driver,
> cryptodev_driver_id);
> -RTE_LOG_REGISTER(mrvl_logtype_driver, pmd.crypto.mvsam, NOTICE);
> +RTE_LOG_REGISTER_DEFAULT(mrvl_logtype_driver, NOTICE);
> diff --git a/drivers/crypto/nitrox/nitrox_logs.c b/drivers/crypto/nitrox/nitrox_logs.c
> index 26395159aa..0e0a94648c 100644
> --- a/drivers/crypto/nitrox/nitrox_logs.c
> +++ b/drivers/crypto/nitrox/nitrox_logs.c
> @@ -4,4 +4,4 @@
>
> #include <rte_log.h>
>
> -RTE_LOG_REGISTER(nitrox_logtype, pmd.crypto.nitrox, NOTICE);
> +RTE_LOG_REGISTER_DEFAULT(nitrox_logtype, NOTICE);
> diff --git a/drivers/crypto/null/null_crypto_pmd.c b/drivers/crypto/null/null_crypto_pmd.c
> index e04042e757..179e5ff36d 100644
> --- a/drivers/crypto/null/null_crypto_pmd.c
> +++ b/drivers/crypto/null/null_crypto_pmd.c
> @@ -248,4 +248,4 @@ RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_NULL_PMD,
> "socket_id=<int>");
> RTE_PMD_REGISTER_CRYPTO_DRIVER(null_crypto_drv, cryptodev_null_pmd_drv.driver,
> cryptodev_driver_id);
> -RTE_LOG_REGISTER(null_logtype_driver, pmd.crypto.null, INFO);
> +RTE_LOG_REGISTER_DEFAULT(null_logtype_driver, INFO);
> diff --git a/drivers/crypto/octeontx/otx_cryptodev.c b/drivers/crypto/octeontx/otx_cryptodev.c
> index 5ce1cf82fd..ba73c2f939 100644
> --- a/drivers/crypto/octeontx/otx_cryptodev.c
> +++ b/drivers/crypto/octeontx/otx_cryptodev.c
> @@ -111,4 +111,4 @@ RTE_PMD_REGISTER_PCI_TABLE(CRYPTODEV_NAME_OCTEONTX_PMD, pci_id_cpt_table);
> RTE_PMD_REGISTER_KMOD_DEP(CRYPTODEV_NAME_OCTEONTX_PMD, "vfio-pci");
> RTE_PMD_REGISTER_CRYPTO_DRIVER(otx_cryptodev_drv, otx_cryptodev_pmd.driver,
> otx_cryptodev_driver_id);
> -RTE_LOG_REGISTER(otx_cpt_logtype, pmd.crypto.octeontx, NOTICE);
> +RTE_LOG_REGISTER_DEFAULT(otx_cpt_logtype, NOTICE);
> diff --git a/drivers/crypto/octeontx2/otx2_cryptodev.c b/drivers/crypto/octeontx2/otx2_cryptodev.c
> index 7f45e57cce..d4e5ca080b 100644
> --- a/drivers/crypto/octeontx2/otx2_cryptodev.c
> +++ b/drivers/crypto/octeontx2/otx2_cryptodev.c
> @@ -177,4 +177,4 @@ RTE_PMD_REGISTER_PCI_TABLE(CRYPTODEV_NAME_OCTEONTX2_PMD, pci_id_cpt_table);
> RTE_PMD_REGISTER_KMOD_DEP(CRYPTODEV_NAME_OCTEONTX2_PMD, "vfio-pci");
> RTE_PMD_REGISTER_CRYPTO_DRIVER(otx2_cryptodev_drv, otx2_cryptodev_pmd.driver,
> otx2_cryptodev_driver_id);
> -RTE_LOG_REGISTER(otx2_cpt_logtype, pmd.crypto.octeontx2, NOTICE);
> +RTE_LOG_REGISTER_DEFAULT(otx2_cpt_logtype, NOTICE);
> diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c
> index 7d3959f550..47004337d5 100644
> --- a/drivers/crypto/openssl/rte_openssl_pmd.c
> +++ b/drivers/crypto/openssl/rte_openssl_pmd.c
> @@ -2278,4 +2278,4 @@ RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_OPENSSL_PMD,
> "socket_id=<int>");
> RTE_PMD_REGISTER_CRYPTO_DRIVER(openssl_crypto_drv,
> cryptodev_openssl_pmd_drv.driver, cryptodev_driver_id);
> -RTE_LOG_REGISTER(openssl_logtype_driver, pmd.crypto.openssl, INFO);
> +RTE_LOG_REGISTER_DEFAULT(openssl_logtype_driver, INFO);
> diff --git a/drivers/crypto/scheduler/rte_cryptodev_scheduler.c b/drivers/crypto/scheduler/rte_cryptodev_scheduler.c
> index 9367a0e915..1e0b4df0ca 100644
> --- a/drivers/crypto/scheduler/rte_cryptodev_scheduler.c
> +++ b/drivers/crypto/scheduler/rte_cryptodev_scheduler.c
> @@ -577,4 +577,4 @@ rte_cryptodev_scheduler_option_get(uint8_t scheduler_id,
> }
>
>
> -RTE_LOG_REGISTER(scheduler_logtype_driver, pmd.crypto.scheduler, INFO);
> +RTE_LOG_REGISTER_DEFAULT(scheduler_logtype_driver, INFO);
> diff --git a/drivers/crypto/snow3g/rte_snow3g_pmd.c b/drivers/crypto/snow3g/rte_snow3g_pmd.c
> index 962868e1fc..9aab357846 100644
> --- a/drivers/crypto/snow3g/rte_snow3g_pmd.c
> +++ b/drivers/crypto/snow3g/rte_snow3g_pmd.c
> @@ -653,4 +653,4 @@ RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_SNOW3G_PMD,
> "socket_id=<int>");
> RTE_PMD_REGISTER_CRYPTO_DRIVER(snow3g_crypto_drv,
> cryptodev_snow3g_pmd_drv.driver, cryptodev_driver_id);
> -RTE_LOG_REGISTER(snow3g_logtype_driver, pmd.crypto.snow3g, INFO);
> +RTE_LOG_REGISTER_DEFAULT(snow3g_logtype_driver, INFO);
> diff --git a/drivers/crypto/virtio/virtio_cryptodev.c b/drivers/crypto/virtio/virtio_cryptodev.c
> index 1822f21744..4bae74a487 100644
> --- a/drivers/crypto/virtio/virtio_cryptodev.c
> +++ b/drivers/crypto/virtio/virtio_cryptodev.c
> @@ -1483,10 +1483,8 @@ RTE_PMD_REGISTER_PCI(CRYPTODEV_NAME_VIRTIO_PMD, rte_virtio_crypto_driver);
> RTE_PMD_REGISTER_CRYPTO_DRIVER(virtio_crypto_drv,
> rte_virtio_crypto_driver.driver,
> cryptodev_virtio_driver_id);
> -RTE_LOG_REGISTER(virtio_crypto_logtype_init, pmd.crypto.virtio.init, NOTICE);
> -RTE_LOG_REGISTER(virtio_crypto_logtype_session, pmd.crypto.virtio.session,
> - NOTICE);
> -RTE_LOG_REGISTER(virtio_crypto_logtype_rx, pmd.crypto.virtio.rx, NOTICE);
> -RTE_LOG_REGISTER(virtio_crypto_logtype_tx, pmd.crypto.virtio.tx, NOTICE);
> -RTE_LOG_REGISTER(virtio_crypto_logtype_driver, pmd.crypto.virtio.driver,
> - NOTICE);
> +RTE_LOG_REGISTER_SUFFIX(virtio_crypto_logtype_init, init, NOTICE);
> +RTE_LOG_REGISTER_SUFFIX(virtio_crypto_logtype_session, session, NOTICE);
> +RTE_LOG_REGISTER_SUFFIX(virtio_crypto_logtype_rx, rx, NOTICE);
> +RTE_LOG_REGISTER_SUFFIX(virtio_crypto_logtype_tx, tx, NOTICE);
> +RTE_LOG_REGISTER_SUFFIX(virtio_crypto_logtype_driver, driver, NOTICE);
> diff --git a/drivers/crypto/zuc/rte_zuc_pmd.c b/drivers/crypto/zuc/rte_zuc_pmd.c
> index a9ff318281..aa50c12da6 100644
> --- a/drivers/crypto/zuc/rte_zuc_pmd.c
> +++ b/drivers/crypto/zuc/rte_zuc_pmd.c
> @@ -580,4 +580,4 @@ RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_ZUC_PMD,
> "socket_id=<int>");
> RTE_PMD_REGISTER_CRYPTO_DRIVER(zuc_crypto_drv, cryptodev_zuc_pmd_drv.driver,
> cryptodev_driver_id);
> -RTE_LOG_REGISTER(zuc_logtype_driver, pmd.crypto.zuc, INFO);
> +RTE_LOG_REGISTER_DEFAULT(zuc_logtype_driver, INFO);
> diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
> index 3570678b9e..5696f568cd 100644
> --- a/drivers/event/dlb2/dlb2.c
> +++ b/drivers/event/dlb2/dlb2.c
> @@ -4655,4 +4655,4 @@ dlb2_parse_params(const char *params,
> }
> return ret;
> }
> -RTE_LOG_REGISTER(eventdev_dlb2_log_level, pmd.event.dlb2, NOTICE);
> +RTE_LOG_REGISTER_DEFAULT(eventdev_dlb2_log_level, NOTICE);
> diff --git a/drivers/event/dpaa/dpaa_eventdev.c b/drivers/event/dpaa/dpaa_eventdev.c
> index 460375ca30..ec74160325 100644
> --- a/drivers/event/dpaa/dpaa_eventdev.c
> +++ b/drivers/event/dpaa/dpaa_eventdev.c
> @@ -46,7 +46,7 @@
> * Eventqueue = Channel Instance
> * 1 Eventdev can have N Eventqueue
> */
> -RTE_LOG_REGISTER(dpaa_logtype_eventdev, pmd.event.dpaa, NOTICE);
> +RTE_LOG_REGISTER_DEFAULT(dpaa_logtype_eventdev, NOTICE);
>
> #define DISABLE_INTR_MODE "disable_intr"
>
> diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c
> index e4fa3a2e46..5ccf22f77f 100644
> --- a/drivers/event/dpaa2/dpaa2_eventdev.c
> +++ b/drivers/event/dpaa2/dpaa2_eventdev.c
> @@ -1206,4 +1206,4 @@ static struct rte_vdev_driver vdev_eventdev_dpaa2_pmd = {
> };
>
> RTE_PMD_REGISTER_VDEV(EVENTDEV_NAME_DPAA2_PMD, vdev_eventdev_dpaa2_pmd);
> -RTE_LOG_REGISTER(dpaa2_logtype_event, pmd.event.dpaa2, NOTICE);
> +RTE_LOG_REGISTER_DEFAULT(dpaa2_logtype_event, NOTICE);
> diff --git a/drivers/event/octeontx/ssovf_evdev.c b/drivers/event/octeontx/ssovf_evdev.c
> index 17325bbf6a..d8b359801a 100644
> --- a/drivers/event/octeontx/ssovf_evdev.c
> +++ b/drivers/event/octeontx/ssovf_evdev.c
> @@ -22,7 +22,7 @@
>
> static uint8_t timvf_enable_stats;
>
> -RTE_LOG_REGISTER(otx_logtype_ssovf, pmd.event.octeontx, NOTICE);
> +RTE_LOG_REGISTER_DEFAULT(otx_logtype_ssovf, NOTICE);
>
> /* SSOPF Mailbox messages */
>
> diff --git a/drivers/event/octeontx/timvf_evdev.c b/drivers/event/octeontx/timvf_evdev.c
> index 8af4d6e37f..688e9daa66 100644
> --- a/drivers/event/octeontx/timvf_evdev.c
> +++ b/drivers/event/octeontx/timvf_evdev.c
> @@ -5,7 +5,7 @@
> #include "ssovf_evdev.h"
> #include "timvf_evdev.h"
>
> -RTE_LOG_REGISTER(otx_logtype_timvf, pmd.event.octeontx.timer, NOTICE);
> +RTE_LOG_REGISTER_SUFFIX(otx_logtype_timvf, timer, NOTICE);
>
> static struct rte_eventdev *event_dev;
>
> diff --git a/drivers/event/opdl/opdl_evdev.c b/drivers/event/opdl/opdl_evdev.c
> index 3050578ffd..cfa9733b64 100644
> --- a/drivers/event/opdl/opdl_evdev.c
> +++ b/drivers/event/opdl/opdl_evdev.c
> @@ -755,7 +755,7 @@ static struct rte_vdev_driver evdev_opdl_pmd_drv = {
> .remove = opdl_remove
> };
>
> -RTE_LOG_REGISTER(opdl_logtype_driver, pmd.event.opdl.driver, INFO);
> +RTE_LOG_REGISTER_SUFFIX(opdl_logtype_driver, driver, INFO);
>
> RTE_PMD_REGISTER_VDEV(EVENTDEV_NAME_OPDL_PMD, evdev_opdl_pmd_drv);
> RTE_PMD_REGISTER_PARAM_STRING(event_opdl, NUMA_NODE_ARG "=<int>"
> diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
> index 0d8013adf7..a5e6ca22e8 100644
> --- a/drivers/event/sw/sw_evdev.c
> +++ b/drivers/event/sw/sw_evdev.c
> @@ -1151,4 +1151,4 @@ RTE_PMD_REGISTER_PARAM_STRING(event_sw, NUMA_NODE_ARG "=<int> "
> SCHED_QUANTA_ARG "=<int>" CREDIT_QUANTA_ARG "=<int>"
> MIN_BURST_SIZE_ARG "=<int>" DEQ_BURST_SIZE_ARG "=<int>"
> REFIL_ONCE_ARG "=<int>");
> -RTE_LOG_REGISTER(eventdev_sw_log_level, pmd.event.sw, NOTICE);
> +RTE_LOG_REGISTER_DEFAULT(eventdev_sw_log_level, NOTICE);
> diff --git a/drivers/mempool/dpaa/dpaa_mempool.c b/drivers/mempool/dpaa/dpaa_mempool.c
> index 1ee7ffb647..f02056982c 100644
> --- a/drivers/mempool/dpaa/dpaa_mempool.c
> +++ b/drivers/mempool/dpaa/dpaa_mempool.c
> @@ -37,7 +37,7 @@ struct dpaa_memseg_list rte_dpaa_memsegs
>
> struct dpaa_bp_info *rte_dpaa_bpid_info;
>
> -RTE_LOG_REGISTER(dpaa_logtype_mempool, mempool.dpaa, NOTICE);
> +RTE_LOG_REGISTER_DEFAULT(dpaa_logtype_mempool, NOTICE);
>
> static int
> dpaa_mbuf_create_pool(struct rte_mempool *mp)
> diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
> index bc146e4ce1..771e0a0e28 100644
> --- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
> +++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
> @@ -457,4 +457,4 @@ static const struct rte_mempool_ops dpaa2_mpool_ops = {
>
> MEMPOOL_REGISTER_OPS(dpaa2_mpool_ops);
>
> -RTE_LOG_REGISTER(dpaa2_logtype_mempool, mempool.dpaa2, NOTICE);
> +RTE_LOG_REGISTER_DEFAULT(dpaa2_logtype_mempool, NOTICE);
> diff --git a/drivers/mempool/meson.build b/drivers/mempool/meson.build
> index caaffc3806..d295263b87 100644
> --- a/drivers/mempool/meson.build
> +++ b/drivers/mempool/meson.build
> @@ -11,4 +11,7 @@ drivers = [
> 'ring',
> 'stack',
> ]
> +
> std_deps = ['mempool']
> +
> +log_prefix = 'mempool'
> diff --git a/drivers/meson.build b/drivers/meson.build
> index 0052247a55..bff1761433 100644
> --- a/drivers/meson.build
> +++ b/drivers/meson.build
> @@ -59,6 +59,11 @@ foreach subpath:subdirs
> drivers += driver_path[1]
> else
> class = subpath
> + endif
> +
> + log_prefix = 'pmd.' + class
> +
> + if drivers.length() == 0
> subdir(class)
> endif
>
Minor nit - rather than splitting the existing block here, I suggest
setting log_prefix = '' at the start of the loop, and leaving the existing
else as-is. Then after the "subdir(class)" just check if log_prefix ==
'' and then set it to the default. I think it might be easier to read that
way. [See suggested change below (untested)]
/Bruce
diff --git a/drivers/meson.build b/drivers/meson.build
index 0052247a5..9d518d361 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -51,6 +51,7 @@ endif
foreach subpath:subdirs
drivers = []
std_deps = []
+ log_prefix = ''
# subpath can be either "class" or "class/driver"
if subpath.contains('/')
@@ -62,6 +63,10 @@ foreach subpath:subdirs
subdir(class)
endif
+ if log_prefix == '':
+ log_prefix = 'pmd.' + class
+ endif
+
# save class name on first occurrence
if not dpdk_driver_classes.contains(class)
dpdk_driver_classes += class
next prev parent reply other threads:[~2021-05-11 11:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 12:43 [dpdk-dev] [PATCH] log: deduce log type from filename David Marchand
2021-04-09 13:01 ` Bruce Richardson
2021-04-13 15:07 ` David Marchand
2021-04-26 12:51 ` [dpdk-dev] [PATCH v2] log: register with standardized names David Marchand
2021-05-11 10:09 ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2021-05-11 11:15 ` David Marchand
2021-05-11 11:49 ` Bruce Richardson
2021-05-11 12:01 ` Thomas Monjalon
2021-05-11 11:59 ` Bruce Richardson [this message]
2021-05-11 12:10 ` Thomas Monjalon
2021-05-11 12:24 ` Bruce Richardson
2021-05-11 12:38 ` [dpdk-dev] [PATCH v4] " Thomas Monjalon
2021-05-11 12:52 ` Bruce Richardson
2021-05-11 13:21 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJpxtclzpERKKhKU@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).