From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97FD1A0C41; Wed, 12 May 2021 18:32:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09E2D4003F; Wed, 12 May 2021 18:32:17 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 35DF34003E for ; Wed, 12 May 2021 18:32:13 +0200 (CEST) IronPort-SDR: ljwEckoblyvh0rixJEG3Lopr4KgGMelJ2HU9VOwV4XAibo2EHoiVksqsCTnohnQrkU3olTS/Mt 1Org7n0sRn8w== X-IronPort-AV: E=McAfee;i="6200,9189,9982"; a="263677260" X-IronPort-AV: E=Sophos;i="5.82,293,1613462400"; d="scan'208";a="263677260" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2021 09:32:11 -0700 IronPort-SDR: fPPcZo53h5LCThsHKJhNabTLlfhVCt4cERpUTDdT/GuqZUTb/ELoK81FW4NJcYJ/vpTugTZBkX PuvOLxUbraag== X-IronPort-AV: E=Sophos;i="5.82,293,1613462400"; d="scan'208";a="622741988" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.19.33]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 12 May 2021 09:32:09 -0700 Date: Wed, 12 May 2021 17:32:06 +0100 From: Bruce Richardson To: Heinrich Kuhn Cc: dev@dpdk.org, "Chaoyong.He" , Simon Horman , konstantin.ananyev@intel.com, vladimir.medvedkin@intel.com Message-ID: References: <20210510165319.9153-1-heinrich.kuhn@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210510165319.9153-1-heinrich.kuhn@netronome.com> Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: change mq-mode on single queue devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, May 10, 2021 at 06:53:19PM +0200, Heinrich Kuhn wrote: > From: "Chaoyong.He" > > Set the Rx multi-queue mode to NONE when configuring a port that is > associated with hardware that only supports a single Rx queue. > > Signed-off-by: Chaoyong He > Signed-off-by: Heinrich Kuhn > Signed-off-by: Simon Horman > --- > examples/l3fwd/main.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c > index bb49e5faf..87b638ac0 100644 > --- a/examples/l3fwd/main.c > +++ b/examples/l3fwd/main.c > @@ -953,6 +953,10 @@ l3fwd_poll_resource_setup(void) > > local_port_conf.rx_adv_conf.rss_conf.rss_hf &= > dev_info.flow_type_rss_offloads; > + > + if (dev_info.max_rx_queues == 1) > + local_port_conf.rxmode.mq_mode = ETH_MQ_RX_NONE; > + While it makes sense to do this when the port only supports a single queue, would it not also make sense to do this when the requested queues are 1 too? Adding some lookup library maintainers on CC - I assume that the RSS value is not actually used for lookup anywhere in l3fwd. /Bruce