From: Piotr Kubaj <pkubaj@anongoth.pl>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, David Christensen <drc@linux.vnet.ibm.com>
Subject: Re: [dpdk-dev] [PATCH] ppc64le: fix build without glibc and using Clang
Date: Wed, 19 May 2021 14:07:45 +0200 [thread overview]
Message-ID: <YKT/kf4G//rwGcTM@KGPE-D16> (raw)
In-Reply-To: <3175316.hIkBcZur5t@thomas>
[-- Attachment #1: Type: text/plain, Size: 1279 bytes --]
On 21-05-19 11:59:35, Thomas Monjalon wrote:
> 19/05/2021 11:57, Piotr Kubaj:
> > Well, isn't FreeBSD already supported?
> >
> > Even https://www.dpdk.org/ mentions supporting FreeBSD.
>
> Yes it is supposed to be supported.
> But why are you adding all this code for PPC?
> It doesn't seem to be all related to clang only.
>
> PS: please do not top-post.
>
>
> > On 21-05-19 09:53:16, Thomas Monjalon wrote:
> > > 18/05/2021 22:42, David Christensen:
> > > > On 5/16/21 5:46 PM, Piotr Kubaj wrote:
> > > > > __ppc_get_timebase() is only present when glibc is used.
> > > > >
> > > > > Signed-off-by: Piotr Kubaj <pkubaj@FreeBSD.org>
> > > > > ---
> > > > > lib/eal/ppc/include/rte_altivec.h | 3 +++
> > > > > lib/eal/ppc/include/rte_cycles.h | 12 ++++++++++++
> > > > > lib/eal/ppc/rte_cycles.c | 16 ++++++++++++++++
> > > > > 3 files changed, 31 insertions(+)
> > > >
> > > > Reviewed-by: David Christensen <drc@linux.vnet.ibm.com>
> > >
> > > This patch does a lot more than what is described.
> > > It seems adding support for FreeBSD.
> > > For testing OS, please use #ifdef RTE_EXEC_ENV_*
>
>
>
>
Well, I'm adding this code for PPC, because there are build issues on powerpc64le machines running FreeBSD.
prev parent reply other threads:[~2021-05-20 8:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 0:46 Piotr Kubaj
2021-05-18 20:42 ` David Christensen
2021-05-19 7:53 ` Thomas Monjalon
2021-05-19 9:57 ` Piotr Kubaj
2021-05-19 9:59 ` Thomas Monjalon
2021-05-19 12:07 ` Piotr Kubaj [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKT/kf4G//rwGcTM@KGPE-D16 \
--to=pkubaj@anongoth.pl \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).