From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 649B5A0A0A; Fri, 21 May 2021 17:21:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E79440686; Fri, 21 May 2021 17:21:44 +0200 (CEST) Received: from sender11-of-o51.zoho.eu (sender11-of-o51.zoho.eu [31.186.226.237]) by mails.dpdk.org (Postfix) with ESMTP id 7214E40143; Fri, 21 May 2021 17:21:42 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; t=1621610496; cv=none; d=zohomail.eu; s=zohoarc; b=WblxEBP3FnW036aTPjBAlnFisjxr6GU+UUBrY0rbtaYefC1zxS28ZddLYbptQZ3v1fTmtk7rU+nQcNp6olV/XVhx1cJH8XEkxsHvB+CFSIAogCACk5fKt9f0KYXoLwwSlRBWtZ/jblMCD8Azr4nRlCi+m0a41Ho/1Lbz+NKYcw0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1621610496; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=4EFdSeHpvNmb9RtJ2BRICbcYCKSwWu0jI8OMrLMYrGQ=; b=jWf/X21MbnHHZ4UOhhm3Y1kno30+RakqoYaDFNWym5j32sbbk6bCyRU7qi+ifRuHlTUUDQ8joqbprQXyVE1S6JU1S4JBlJ25LF4CbhcSEbdSKywTHenrKbkwr19gfGVfWJiQbCBH9Y6SncaOL7+ptEuGQ8Go0ZwFFGBYpkjXgmI= ARC-Authentication-Results: i=1; mx.zohomail.eu; spf=pass smtp.mailfrom=liangma@liangbit.com; dmarc=pass header.from= header.from= Received: from C02F33EJML85 (47.254.128.112 [47.254.128.112]) by mx.zoho.eu with SMTPS id 162161049400493.91807781465377; Fri, 21 May 2021 17:21:34 +0200 (CEST) Date: Fri, 21 May 2021 16:21:31 +0100 From: Liang Ma To: Thomas Monjalon Cc: Konstantin Ananyev , dev@dpdk.org, stable@dpdk.org Message-ID: References: <20210521144207.13802-1-konstantin.ananyev@intel.com> <5942248.XgMt1RgFVE@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <5942248.XgMt1RgFVE@thomas> X-ZohoMailClient: External Subject: Re: [dpdk-dev] [PATCH] acl: fix build with GCC 6.3 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, May 21, 2021 at 05:10:41PM +0200, Thomas Monjalon wrote: > 21/05/2021 16:42, Konstantin Ananyev: > > --buildtype=3Ddebug with gcc 6.3 produces the following error: > >=20 > > ../lib/librte_acl/acl_run_avx512_common.h: In function > > =E2=80=98resolve_match_idx_avx512x16=E2=80=99: > > ../lib/librte_acl/acl_run_avx512x16.h:33:18: error: > > =09the last argument must be an 8-bit immediate > > ^ > > ../lib/librte_acl/acl_run_avx512_common.h:373:9: note: > > =09in expansion of macro =E2=80=98_M_I_=E2=80=99 > > return _M_I_(slli_epi32)(mi, match_log); > > ^~~~~ > >=20 > > Seems like gcc-6.3 complains about the following construct: > >=20 > > static const uint32_t match_log =3D 5; > > ... > > _mm512_slli_epi32(mi, match_log); > >=20 > > It can't substitute constant variable 'match_log' with its actual value= . > > The fix replaces constant variable with its immediate value. > >=20 > > Bugzilla ID: 717 > > Fixes: b64c2295f7fc ("acl: add 256-bit AVX512 classify method") > > Fixes: 45da22e42ec3 ("acl: add 512-bit AVX512 classify method") > > Cc: stable@dpdk.org > >=20 > > Reported-by: Liang Ma > > Signed-off-by: Konstantin Ananyev >=20 > How much critical is it? > It looks safer to wait for 21.08 cycle? +1. gcc8.30 is OK. It's a bit late now.=20 >=20 >=20