From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 965FAA0547;
Fri, 28 May 2021 10:19:19 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 3275F40143;
Fri, 28 May 2021 10:19:18 +0200 (CEST)
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
by mails.dpdk.org (Postfix) with ESMTP id 6F47D40040;
Fri, 28 May 2021 10:19:16 +0200 (CEST)
IronPort-SDR: HCWOOdZ+2kvhuUd0o7rZSTv7YNx2+lGO4tekZPDFn6LtlnHFcnWgeuUx3Uvd/+A25QjIl36vKi
ZSN/t3rZKwbg==
X-IronPort-AV: E=McAfee;i="6200,9189,9997"; a="202955012"
X-IronPort-AV: E=Sophos;i="5.83,229,1616482800"; d="scan'208";a="202955012"
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
28 May 2021 01:19:13 -0700
IronPort-SDR: NamjPpHXJxsTZL3r15+AE28brDTNqxmjykuFZoQoa1QHKh6R4PtSlY3ofHc0VThC3hliBu8+2c
pq+TXJBP2FKQ==
X-IronPort-AV: E=Sophos;i="5.83,229,1616482800"; d="scan'208";a="548511116"
Received: from bricha3-mobl.ger.corp.intel.com ([10.252.7.179])
by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;
28 May 2021 01:19:10 -0700
Date: Fri, 28 May 2021 09:19:06 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Nick Connolly <nick.connolly@mayadata.io>
Cc: Ranjit Menon <ranjit.menon@intel.com>, dev@dpdk.org,
dmitry.kozliuk@gmail.com, navasile@linux.microsoft.com,
dmitrym@microsoft.com, pallavi.kadam@intel.com, stable@dpdk.org
Message-ID: <YLCnehBh4ovz8T+s@bricha3-MOBL.ger.corp.intel.com>
References: <20210401122723.23082-1-nick.connolly@mayadata.io>
<20210426100733.22478-1-nick.connolly@mayadata.io>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210426100733.22478-1-nick.connolly@mayadata.io>
Subject: Re: [dpdk-dev] [PATCH v3] build: fix symlink of drivers for Windows
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Mon, Apr 26, 2021 at 11:07:32AM +0100, Nick Connolly wrote:
> The symlink-drivers-solibs.sh script was disabled as part of 'install'
> for Windows because there is no support for shell scripts. However,
> this means that driver related DLLs are not present in the installed
> 'libdir' directory. Add a python script to perform the install and use
> it for Windows if the version of meson supports using an external
> program with add_install_script (>= 0.55.0).
>
> On Windows, symbolic links are somewhat problematic since the
> SeCreateSymbolicLinkPrivilege is required to be able to create them.
> In addition, different cross-compilation environments handle symbolic
> links differently, e.g. WSL, Msys2, Cygwin. Rather than trying to
> distinguish these scenarios, the python script will perform a file copy
> for any Windows specific names.
>
> On Windows, the shared library outputs have different names depending
> upon which toolset has been used to build them. The script currently
> handles Clang and GCC.
>
> On Linux the functionality is unchanged, but could be replaced with the
> python script once the required minimum version of meson is >= 0.55.0.
>
> Fixes: 5c7d86948764 ("build: fix install on Windows")
> Cc: stable@dpdk.org
>
> Signed-off-by: Nick Connolly <nick.connolly@mayadata.io>
> Tested-by: Narcisa Vasile <navasile@linux.microsoft.com>
> Acked-by: Narcisa Vasile <navasile@linux.microsoft.com>
> ---
Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>