From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91136A0547; Fri, 28 May 2021 10:19:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 82C02410E9; Fri, 28 May 2021 10:19:56 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 5A06340040; Fri, 28 May 2021 10:19:54 +0200 (CEST) IronPort-SDR: 8JQhkxE0B5TO9je4rnQ+CMQzA3LqaP230ituO8zXp0wjiP5g9OqeRDl8frv5yLc4EwdRvmTTFj VWq0aNktdlrA== X-IronPort-AV: E=McAfee;i="6200,9189,9997"; a="190288564" X-IronPort-AV: E=Sophos;i="5.83,229,1616482800"; d="scan'208";a="190288564" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2021 01:19:52 -0700 IronPort-SDR: Bx9b9RDoLTnwELRa+56cuUIvu9/jbNVdzliYrDVIhurqDxJSzS5ORgU8RJ0HYUbyqelEuob5z+ UCXzGhQGruPw== X-IronPort-AV: E=Sophos;i="5.83,229,1616482800"; d="scan'208";a="548511170" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.7.179]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 28 May 2021 01:19:49 -0700 Date: Fri, 28 May 2021 09:19:45 +0100 From: Bruce Richardson To: Nick Connolly Cc: Ranjit Menon , dev@dpdk.org, dmitry.kozliuk@gmail.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, stable@dpdk.org Message-ID: References: <20210401122723.23082-1-nick.connolly@mayadata.io> <20210426100733.22478-1-nick.connolly@mayadata.io> <77be8951-5cc8-dd20-a084-9485ccceef28@mayadata.io> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <77be8951-5cc8-dd20-a084-9485ccceef28@mayadata.io> Subject: Re: [dpdk-dev] [PATCH v3] build: fix symlink of drivers for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, May 27, 2021 at 06:37:57PM +0100, Nick Connolly wrote: > Hi Bruce, > > Would you have some time to take a look at this?  It's a replacement for the > symlink-drivers-solibs.sh script for windows builds. > > Thanks, > Nick > I've reviewed it now and it looks good. Couldn't even find anything to nit-pick in it! :-)