From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80AA1A0C47; Fri, 11 Jun 2021 11:59:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E2CF74067C; Fri, 11 Jun 2021 11:59:51 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 726014014F; Fri, 11 Jun 2021 11:59:50 +0200 (CEST) IronPort-SDR: gPg4/tGWxEP59cLri7DzKL5/NV1WdMhh2tuPwRpmJQetVkjMSoSvL3ZTn9VD6x7BqAWdQbNmIk NZCpWW+NuekA== X-IronPort-AV: E=McAfee;i="6200,9189,10011"; a="202471654" X-IronPort-AV: E=Sophos;i="5.83,265,1616482800"; d="scan'208";a="202471654" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2021 02:59:48 -0700 IronPort-SDR: z5V+Vx9ycpBn68wSATDUqIL3YG376iZjg1NsO5CRIPv0KE6t5Zqndk1iPXdXZDq+34901YT0b9 p53QKXildFUA== X-IronPort-AV: E=Sophos;i="5.83,265,1616482800"; d="scan'208";a="450711529" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.11.39]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 11 Jun 2021 02:59:46 -0700 Date: Fri, 11 Jun 2021 10:59:42 +0100 From: Bruce Richardson To: David Marchand Cc: Jan Viktorin , Ruifeng Wang , Jerin Jacob , dev , Michael Pfeiffer , dpdk stable , kosar@rehivetech.com, Phil Yang , Joyce Kong Message-ID: References: <20210609101755.20769-1-michael.pfeiffer@tu-ilmenau.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v5] eal: arm: fix out of tree build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jun 11, 2021 at 11:54:25AM +0200, David Marchand wrote: > Hello Bruce, > > On Wed, Jun 9, 2021 at 12:18 PM Michael Pfeiffer > wrote: > > > > Including various headers may fail for ARM builds with 'Platform must > > be built with RTE_FORCE_INTRINSICS' if rte_config.h is not included > > before. Move the error message after the includes to ensure rte_config.h > > is always included. > > > > Fixes: de966ccdcd7f ("eal/arm: add byte order operations for ARM") > > Fixes: 17d5fa0fa90d ("eal/arm: add atomic operations for ARMv7") > > Fixes: d708f01b7102 ("eal/arm: add atomic operations for ARMv8") > > Fixes: 2173f3333b61 ("mcslock: add MCS queued lock implementation") > > Fixes: 7860c3965483 ("eal/arm: add spinlock operations for ARM") > > Fixes: ca49b92079df ("ticketlock: enable generic ticketlock on all arch") > > Cc: stable@dpdk.org > > Cc: kosar@rehivetech.com > > Cc: phil.yang@arm.com > > Cc: joyce.kong@arm.com > > > > Signed-off-by: Michael Pfeiffer > > The header check currently compiles all headers with an implicit > "-include rte_config.h". > I suppose this is because it comes from the project level meson configuration. > > Would there be a way to detect the issue fixed by this patch? > I'm not convinced that there is an issue here. For DPDK compiles rte_config.h must always be included first, which is why it's included in the cflags reported by pkg-config. If we do want to move away from having rte_config as an omnipresent first include, we need to update many DPDK headers to explicitly include it. /Bruce