From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF89CA0A0C; Thu, 1 Jul 2021 11:57:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9348A40141; Thu, 1 Jul 2021 11:57:58 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 45BED40040 for ; Thu, 1 Jul 2021 11:57:56 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10031"; a="272360476" X-IronPort-AV: E=Sophos;i="5.83,313,1616482800"; d="scan'208";a="272360476" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2021 02:57:54 -0700 X-IronPort-AV: E=Sophos;i="5.83,313,1616482800"; d="scan'208";a="642022964" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.3.218]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 01 Jul 2021 02:57:52 -0700 Date: Thu, 1 Jul 2021 10:57:49 +0100 From: Bruce Richardson To: Luca Boccassi Cc: Dmitry Kozlyuk , dev@dpdk.org, Rob Scheepens Message-ID: References: <20210630162235.267285-1-dmitry.kozliuk@gmail.com> <57d6b6a0808b899e6b23cd204a1018d519326fd0.camel@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57d6b6a0808b899e6b23cd204a1018d519326fd0.camel@debian.org> Subject: Re: [dpdk-dev] [PATCH] doc: fix build on Windows with meson 0.58 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 01, 2021 at 09:34:04AM +0100, Luca Boccassi wrote: > On Wed, 2021-06-30 at 19:22 +0300, Dmitry Kozlyuk wrote: > > The `doc` target used `echo` as its command. > > On Windows, `echo` is always a shell built-in, there is no binary. > > Starting from meson 0.58, `run_target()` always searches for command > > executable and no longer accepts `echo` as such on Windows. > > Replace plain `echo` with a Python one-liner. > > > > Fixes: d02a2dab2dfb ("doc: support building HTML guides with meson") > > Cc: Bruce Richardson > > Cc: Luca Boccassi > > Cc: stable@dpdk.org > > > > Reported-by: Rob Scheepens > > Signed-off-by: Dmitry Kozlyuk > > --- > > Acked-by: Luca Boccassi One small suggestion might be to move the "echo" command definition to buildtools folder in case it's wanted for use anywhere in the build at some point in the future. However, this patch is fine without that change too. Acked-by: Bruce Richardson