From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B76DDA0A0C; Thu, 1 Jul 2021 15:35:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A3867412D4; Thu, 1 Jul 2021 15:35:12 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 2DF2C40141 for ; Thu, 1 Jul 2021 15:35:11 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10031"; a="294169231" X-IronPort-AV: E=Sophos;i="5.83,314,1616482800"; d="scan'208";a="294169231" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2021 06:35:10 -0700 X-IronPort-AV: E=Sophos;i="5.83,314,1616482800"; d="scan'208";a="457658706" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.3.218]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 01 Jul 2021 06:35:08 -0700 Date: Thu, 1 Jul 2021 14:35:04 +0100 From: Bruce Richardson To: Andrew Rybchenko Cc: David Marchand , Thomas Monjalon , dev , Igor Romanov , Andy Moreton , Ivan Malov Message-ID: References: <20210527152510.1551026-1-andrew.rybchenko@oktetlabs.ru> <20210618134032.1922012-20-andrew.rybchenko@oktetlabs.ru> <23888533.A65Z59arLz@thomas> <8a3c653e-65db-fc48-253c-db78037635f3@oktetlabs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v3 19/20] net/sfc: support flow action COUNT in transfer rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 01, 2021 at 04:05:56PM +0300, Andrew Rybchenko wrote: > @Bruce, see below. > > On 7/1/21 3:34 PM, David Marchand wrote: > > On Thu, Jul 1, 2021 at 11:22 AM Andrew Rybchenko > > wrote: > >> The build works fine for me on FC34, but it has > >> libatomic-11.1.1-3.fc34.x86_64 installed. > > > > I first produced the issue on my "old" FC32. > > Afaics, for FC33 and later, gcc now depends on libatomic and the > > problem won't be noticed. > > FC32 and before are EOL, but I then reproduced the issue on RHEL 8 > > (and Intel CI reported it on Centos 8 too). > > I see. Thanks for the clarification. > > >> > >> I'd like to understand what we're trying to solve here. > >> Are we trying to make meson to report the missing library > >> correctly? > >> > >> If so, I think I can do simple check using cc.links() > >> which will fail if the library is not found. I'll > >> test that it works as expected if the library is not > >> completely installed. > >> > > > > I tried below diff, and it works for me. > > "works" as in net/sfc gets disabled without libatomic installed: > > > > diff --git a/drivers/net/sfc/meson.build b/drivers/net/sfc/meson.build > > index 32b58e3d76..8d62aad774 100644 > > --- a/drivers/net/sfc/meson.build > > +++ b/drivers/net/sfc/meson.build > > @@ -15,6 +15,7 @@ endif > > if (arch_subdir != 'x86' or not dpdk_conf.get('RTE_ARCH_64')) and > > (arch_subdir != 'arm' or not > > host_machine.cpu_family().startswith('aarch64')) > > build = false > > reason = 'only supported on x86_64 and aarch64' > > + subdir_done() > > @Bruce Shouldn't we add subdir_done() after all build = false > cases? As I understand it is OK for minimum supported meson > version. > We can add it, no problem. For many files it's just not necessary, since in a lot of cases we just do assignments to variables afterward and those vars are just ignored and unused on return. That's the only reason it wasn't added generally before.