From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCC26A0C43; Thu, 15 Jul 2021 10:11:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 67AB640143; Thu, 15 Jul 2021 10:11:21 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 64A2D40140; Thu, 15 Jul 2021 10:11:19 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10045"; a="190874754" X-IronPort-AV: E=Sophos;i="5.84,240,1620716400"; d="scan'208";a="190874754" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2021 01:11:18 -0700 X-IronPort-AV: E=Sophos;i="5.84,240,1620716400"; d="scan'208";a="652711972" Received: from ccarthy-mobl1.ger.corp.intel.com (HELO bricha3-MOBL.ger.corp.intel.com) ([10.252.5.222]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 15 Jul 2021 01:11:16 -0700 Date: Thu, 15 Jul 2021 09:11:13 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: David Marchand <david.marchand@redhat.com> Cc: "Zhang, Tianfei" <tianfei.zhang@intel.com>, "Hussin, Mohamad Noor Alim" <mohamad.noor.alim.hussin@intel.com>, "Xu, Rosen" <rosen.xu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Huang, Wei" <wei.huang@intel.com>, "stable@dpdk.org" <stable@dpdk.org> Message-ID: <YO/toU3CT2rvs75N@bricha3-MOBL.ger.corp.intel.com> References: <20210630092613.70647-1-mohamad.noor.alim.hussin@intel.com> <BYAPR11MB29019C45173776CCEEDCE22A89019@BYAPR11MB2901.namprd11.prod.outlook.com> <DM6PR11MB313172FE145950817053F23CE3009@DM6PR11MB3131.namprd11.prod.outlook.com> <MWHPR11MB201329DC61D770B7D5E6269E8D1F9@MWHPR11MB2013.namprd11.prod.outlook.com> <BN9PR11MB54837BF4710F18ACC16F4659E3139@BN9PR11MB5483.namprd11.prod.outlook.com> <CAJFAV8wB=gtzvgTsEhdLfUiFxwgK+LFG5+pM18kAvPjQ5LCCxw@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <CAJFAV8wB=gtzvgTsEhdLfUiFxwgK+LFG5+pM18kAvPjQ5LCCxw@mail.gmail.com> Subject: Re: [dpdk-dev] [PATCH v2] ifpga/base/meson: fix looking for librt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Thu, Jul 15, 2021 at 10:00:19AM +0200, David Marchand wrote: > Hello, > > On Wed, Jul 14, 2021 at 5:40 AM Zhang, Tianfei <tianfei.zhang@intel.com> wrote: > > > > > > > > Hi Tianfei, > > > > > > To reproduce this, assume using Ubuntu 20.04. > > > 1. Install libfdt (It will include ifpga driver from drivers/raw/ifpga/base) > > > $ sudo apt-get install libfdt-dev > > > 2. configure DPDK library > > > $ meson build > > > 3. check libdpdk.pc file in build/meson-private/libdpdk.pc. It will include path > > > to librt.so without this patch. > > > > I have checked the libdpdk.pc and got the different between with and without this patch. > > Without this patch, there are a full path for librt.so in libdpdk.pc. With this patch, it provide "-lrt" in libdpdk.pc. > > > > This patch looks good for me. > > > > Acked-by: Tianfei Zhang <Tianfei.zhang@intel.com> > > I can't find the original mail to dev@dpdk.org and patchwork did not help. > Please, can you resubmit this patch? > > Also copy Bruce as this touches a meson subtlety I was not aware of, > and he should probably have a look. > Thanks for flagging this to me, I wasn't aware of the subtlety here at all, but it's good to know for future reference. If asked, I would generally have recommended using find_library without the "lib" prefix on the library name, but I had no idea using with or without leads to different output. Acked-by: Bruce Richardson <bruce.richardson@intel.com> /Bruce