From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E249A0C4A; Wed, 7 Jul 2021 10:11:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A7BAD406B4; Wed, 7 Jul 2021 10:11:44 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id E1C384069D for ; Wed, 7 Jul 2021 10:11:43 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10037"; a="196540421" X-IronPort-AV: E=Sophos;i="5.83,331,1616482800"; d="scan'208";a="196540421" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2021 01:11:40 -0700 X-IronPort-AV: E=Sophos;i="5.83,331,1616482800"; d="scan'208";a="497662555" Received: from jweldon-mobl.ger.corp.intel.com (HELO bricha3-MOBL.ger.corp.intel.com) ([10.252.4.148]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 07 Jul 2021 01:11:38 -0700 Date: Wed, 7 Jul 2021 09:11:29 +0100 From: Bruce Richardson To: fengchengwen Cc: dev@dpdk.org, Jerin Jacob , Jerin Jacob , Morten =?iso-8859-1?Q?Br=F8rup?= Message-ID: References: <1625231891-2963-1-git-send-email-fengchengwen@huawei.com> <20210706202841.661302-1-bruce.richardson@intel.com> <32b9fa47-918b-cb16-d4c1-729ee92ba6f4@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <32b9fa47-918b-cb16-d4c1-729ee92ba6f4@huawei.com> Subject: Re: [dpdk-dev] [RFC UPDATE PATCH 0/9] dmadev rfc suggested updates X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 07, 2021 at 11:16:44AM +0800, fengchengwen wrote: > LGTM, thanks > > And I'am prepare dmadev V2, include: > a) Fix code review comments (e.g. multiple-process support, doxygen, comments, typo) > b) Flatten device abstraction to two layer: dmadev <> vchan > c) Public API use dev_id and vchan_id to locate one vchan > d) Using the flags parameter instead of the fence API Bit uncertain about this one still > e) Rename rte_dmadev_perform to rte_dmadev_submit so it corresponds to the stats variable. > > PS: Some code (lib/dmadev) will rebase this patchset > This was not meant to be a separate patchset, but rather to try and keep us all in sync on what was being looked at and tested. Please just pull in the changes from this set (as many as you are happy with) into your V2 RFC to simplify things. It's better to just have the one master RFC into which changes are pulled. Thanks, /Bruce