From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F529A0C47; Tue, 27 Jul 2021 10:44:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 18611410ED; Tue, 27 Jul 2021 10:44:41 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 03803410EC for <dev@dpdk.org>; Tue, 27 Jul 2021 10:44:38 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10057"; a="212434771" X-IronPort-AV: E=Sophos;i="5.84,272,1620716400"; d="scan'208";a="212434771" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2021 01:44:37 -0700 X-IronPort-AV: E=Sophos;i="5.84,272,1620716400"; d="scan'208";a="634338761" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.31.170]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 27 Jul 2021 01:44:35 -0700 Date: Tue, 27 Jul 2021 09:44:31 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: "Xia, Chenbo" <chenbo.xia@intel.com> Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "thomas@monjalon.net" <thomas@monjalon.net>, "mdr@ashroe.eu" <mdr@ashroe.eu>, "nhorman@tuxdriver.com" <nhorman@tuxdriver.com>, "david.marchand@redhat.com" <david.marchand@redhat.com> Message-ID: <YP/Hb9tLKG7XLnOl@bricha3-MOBL.ger.corp.intel.com> References: <20210601084131.4277-1-chenbo.xia@intel.com> <MN2PR11MB40638A461F9D8E4F7329784F9CE59@MN2PR11MB4063.namprd11.prod.outlook.com> <ca1ad039-b8d9-6442-7fd4-bcf7c50db412@intel.com> <MN2PR11MB4063ED510043B7640EAC167C9CE89@MN2PR11MB4063.namprd11.prod.outlook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <MN2PR11MB4063ED510043B7640EAC167C9CE89@MN2PR11MB4063.namprd11.prod.outlook.com> Subject: Re: [dpdk-dev] [PATCH] doc: announce removal of ABIs in PCI bus driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Mon, Jul 26, 2021 at 05:56:17AM +0000, Xia, Chenbo wrote: > Hi, Ferruh > > > -----Original Message----- > > From: Yigit, Ferruh <ferruh.yigit@intel.com> > > Sent: Friday, July 23, 2021 8:47 PM > > To: Xia, Chenbo <chenbo.xia@intel.com>; dev@dpdk.org; thomas@monjalon.net > > Cc: mdr@ashroe.eu; nhorman@tuxdriver.com; david.marchand@redhat.com > > Subject: Re: [dpdk-dev] [PATCH] doc: announce removal of ABIs in PCI bus > > driver > > > > On 7/23/2021 8:39 AM, Xia, Chenbo wrote: > > > Hi, > > > > > > A gentle ping for comments.. > > > > > >> -----Original Message----- > > >> From: dev <dev-bounces@dpdk.org> On Behalf Of Chenbo Xia > > >> Sent: Tuesday, June 1, 2021 4:42 PM > > >> To: dev@dpdk.org; thomas@monjalon.net > > >> Cc: mdr@ashroe.eu; nhorman@tuxdriver.com > > >> Subject: [dpdk-dev] [PATCH] doc: announce removal of ABIs in PCI bus > > driver > > >> > > >> All ABIs in PCI bus driver, which are defined in rte_buc_pci.h, > > >> will be removed and the header will be made internal. > > >> > > >> Signed-off-by: Chenbo Xia <chenbo.xia@intel.com> > > >> --- > > >> doc/guides/rel_notes/deprecation.rst | 5 +++++ > > >> 1 file changed, 5 insertions(+) > > >> > > >> diff --git a/doc/guides/rel_notes/deprecation.rst > > >> b/doc/guides/rel_notes/deprecation.rst > > >> index 9584d6bfd7..b01f46c62e 100644 > > >> --- a/doc/guides/rel_notes/deprecation.rst > > >> +++ b/doc/guides/rel_notes/deprecation.rst > > >> @@ -147,3 +147,8 @@ Deprecation Notices > > >> * cmdline: ``cmdline`` structure will be made opaque to hide platform- > > >> specific > > >> content. On Linux and FreeBSD, supported prior to DPDK 20.11, > > >> original structure will be kept until DPDK 21.11. > > >> + > > >> +* pci: To reduce unnecessary ABIs exposed by DPDK bus driver, > > "rte_bus_pci.h" > > >> + will be made internal in 21.11 and macros/data structures/functions > > defined > > >> + in the header will not be considered as ABI anymore. This change is > > >> inspired > > >> + by the RFC > > https://patchwork.dpdk.org/project/dpdk/list/?series=17176. > > > > > > I see there's some ABI improvement work on-going and I think it could be > > part of > > > the work. If it makes sense to you, I'd like some ACKs. > > > > > > > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com> > > > > I am for reducing the public ABI as much as possible. How big will the > > change > > be? Is the 'rte_bus_pci.h' used other than './drivers/bus/pci/'? > > I don't see big change here. And I am not sure if I understand your second > question. The rte_bus_pci.h will still be used by drivers (maybe remove the > rte prefix and change the file name). > The file itself will still be exported in some cases, where the end-user has their own drivers which need to be compiled, so I'd recommend keeping the rte_ prefix. However, I think making all bus APIs internal-only to DPDK is a good idea. Acked-by: Bruce Richardson <bruce.richardson@intel.com>