From: Bruce Richardson <bruce.richardson@intel.com>
To: jerinj@marvell.com
Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Haiyue Wang <haiyue.wang@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Xiao Wang <xiao.w.wang@intel.com>,
Ziyang Xuan <xuanziyang2@huawei.com>,
Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,
Guoyang Zhou <zhouguoyang@huawei.com>,
Beilei Xing <beilei.xing@intel.com>,
Qiming Yang <qiming.yang@intel.com>,
Jiawen Wu <jiawenwu@trustnetic.com>,
Harman Kalra <hkalra@marvell.com>,
Rasesh Mody <rmody@marvell.com>,
Devendra Singh Rawat <dsinghrawat@marvell.com>,
Igor Russkikh <irusskikh@marvell.com>,
Maciej Czekaj <mczekaj@marvell.com>,
Jian Wang <jianwang@trustnetic.com>,
Rosen Xu <rosen.xu@intel.com>,
Tianfei zhang <tianfei.zhang@intel.com>,
dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH v2] drivers: remove warning with meson 0.59.0
Date: Tue, 17 Aug 2021 13:29:24 +0100 [thread overview]
Message-ID: <YRurpLAYuOLkfDre@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20210730073548.3596659-1-jerinj@marvell.com>
On Fri, Jul 30, 2021 at 01:05:48PM +0530, jerinj@marvell.com wrote:
> From: Jerin Jacob <jerinj@marvell.com>
>
> Since meson 0.59.0 version, the extract_all_objects() API
> need to pass explicit boolean value.
>
> To remove the following warning[1], added explicit `true` for
> extract_all_objects() use in codebase whever there is
> no argument.
>
> [1]
> WARNING: extract_all_objects called without setting recursive
> keyword argument. Meson currently defaults to
> non-recursive to maintain backward compatibility but
> the default will be changed in the future.
>
Technically this is changing the default behaviour since it previously
defaulted to "false". However, since there should be no recursion involved
here anyway, I don't think it matters, correct?
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
> v2..v1
> - Corrrect the meson version number in git commit log(0.46.0 to 0.59.0)
>
> drivers/common/sfc_efx/base/meson.build | 2 +-
> drivers/meson.build | 2 +-
> drivers/net/e1000/base/meson.build | 2 +-
> drivers/net/fm10k/base/meson.build | 2 +-
> drivers/net/hinic/base/meson.build | 2 +-
> drivers/net/i40e/base/meson.build | 2 +-
> drivers/net/ice/base/meson.build | 2 +-
> drivers/net/igc/base/meson.build | 2 +-
> drivers/net/ixgbe/base/meson.build | 2 +-
> drivers/net/ngbe/base/meson.build | 2 +-
> drivers/net/octeontx/base/meson.build | 2 +-
> drivers/net/qede/base/meson.build | 2 +-
> drivers/net/thunderx/base/meson.build | 2 +-
> drivers/net/txgbe/base/meson.build | 2 +-
> drivers/raw/ifpga/base/meson.build | 2 +-
> 15 files changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/common/sfc_efx/base/meson.build b/drivers/common/sfc_efx/base/meson.build
> index 9fba47b1cc..ff7f33fb44 100644
> --- a/drivers/common/sfc_efx/base/meson.build
> +++ b/drivers/common/sfc_efx/base/meson.build
> @@ -86,7 +86,7 @@ if build
> dependencies: static_rte_eal,
> c_args: c_args)
>
> - base_objs = base_lib.extract_all_objects()
> + base_objs = base_lib.extract_all_objects(recursive: true)
> else
> base_objs = []
> endif
> diff --git a/drivers/meson.build b/drivers/meson.build
> index bc6f4f567f..d9e331ec85 100644
> --- a/drivers/meson.build
> +++ b/drivers/meson.build
> @@ -160,7 +160,7 @@ foreach subpath:subdirs
> include_directories: includes,
> dependencies: static_deps,
> c_args: cflags)
> - objs += tmp_lib.extract_all_objects()
> + objs += tmp_lib.extract_all_objects(recursive: true)
> sources = custom_target(out_filename,
> command: [pmdinfo, tmp_lib.full_path(), '@OUTPUT@', pmdinfogen],
> output: out_filename,
> diff --git a/drivers/net/e1000/base/meson.build b/drivers/net/e1000/base/meson.build
> index 317692dfab..528a33f958 100644
> --- a/drivers/net/e1000/base/meson.build
> +++ b/drivers/net/e1000/base/meson.build
> @@ -35,4 +35,4 @@ endforeach
> base_lib = static_library('e1000_base', sources,
> dependencies: static_rte_eal,
> c_args: c_args)
> -base_objs = base_lib.extract_all_objects()
> +base_objs = base_lib.extract_all_objects(recursive: true)
> diff --git a/drivers/net/fm10k/base/meson.build b/drivers/net/fm10k/base/meson.build
> index ca98d34d4e..bd19df27f7 100644
> --- a/drivers/net/fm10k/base/meson.build
> +++ b/drivers/net/fm10k/base/meson.build
> @@ -25,4 +25,4 @@ endforeach
> base_lib = static_library('fm10k_base', sources,
> dependencies: static_rte_eal,
> c_args: c_args)
> -base_objs = base_lib.extract_all_objects()
> +base_objs = base_lib.extract_all_objects(recursive: true)
> diff --git a/drivers/net/hinic/base/meson.build b/drivers/net/hinic/base/meson.build
> index a00c90c14e..3aa53df881 100644
> --- a/drivers/net/hinic/base/meson.build
> +++ b/drivers/net/hinic/base/meson.build
> @@ -34,4 +34,4 @@ c_args = cflags
> base_lib = static_library('hinic_base', sources,
> dependencies: [static_rte_eal, static_rte_ethdev, static_rte_bus_pci, static_rte_hash],
> c_args: c_args)
> -base_objs = base_lib.extract_all_objects()
> +base_objs = base_lib.extract_all_objects(recursive: true)
> diff --git a/drivers/net/i40e/base/meson.build b/drivers/net/i40e/base/meson.build
> index 79a887a297..d94108629b 100644
> --- a/drivers/net/i40e/base/meson.build
> +++ b/drivers/net/i40e/base/meson.build
> @@ -27,4 +27,4 @@ endforeach
> base_lib = static_library('i40e_base', sources,
> dependencies: static_rte_eal,
> c_args: c_args)
> -base_objs = base_lib.extract_all_objects()
> +base_objs = base_lib.extract_all_objects(recursive: true)
> diff --git a/drivers/net/ice/base/meson.build b/drivers/net/ice/base/meson.build
> index 3305e5dd18..30e251876d 100644
> --- a/drivers/net/ice/base/meson.build
> +++ b/drivers/net/ice/base/meson.build
> @@ -43,4 +43,4 @@ endforeach
> base_lib = static_library('ice_base', sources,
> dependencies: static_rte_eal,
> c_args: c_args)
> -base_objs = base_lib.extract_all_objects()
> +base_objs = base_lib.extract_all_objects(recursive: true)
> diff --git a/drivers/net/igc/base/meson.build b/drivers/net/igc/base/meson.build
> index 8affc72e65..f52421f7a9 100644
> --- a/drivers/net/igc/base/meson.build
> +++ b/drivers/net/igc/base/meson.build
> @@ -16,4 +16,4 @@ base_lib = static_library('igc_base', sources,
> dependencies: static_rte_eal,
> c_args: cflags)
>
> -base_objs = base_lib.extract_all_objects()
> +base_objs = base_lib.extract_all_objects(recursive: true)
> diff --git a/drivers/net/ixgbe/base/meson.build b/drivers/net/ixgbe/base/meson.build
> index 7d3cec002d..22972c6b56 100644
> --- a/drivers/net/ixgbe/base/meson.build
> +++ b/drivers/net/ixgbe/base/meson.build
> @@ -31,4 +31,4 @@ endforeach
> base_lib = static_library('ixgbe_base', sources,
> dependencies: static_rte_eal,
> c_args: c_args)
> -base_objs = base_lib.extract_all_objects()
> +base_objs = base_lib.extract_all_objects(recursive: true)
> diff --git a/drivers/net/ngbe/base/meson.build b/drivers/net/ngbe/base/meson.build
> index a1a9c2ff65..6081281135 100644
> --- a/drivers/net/ngbe/base/meson.build
> +++ b/drivers/net/ngbe/base/meson.build
> @@ -18,4 +18,4 @@ c_args = cflags
> base_lib = static_library('ngbe_base', sources,
> dependencies: [static_rte_eal, static_rte_ethdev, static_rte_bus_pci],
> c_args: c_args)
> -base_objs = base_lib.extract_all_objects()
> +base_objs = base_lib.extract_all_objects(recursive: true)
> diff --git a/drivers/net/octeontx/base/meson.build b/drivers/net/octeontx/base/meson.build
> index c86a726704..8e5e8c1b55 100644
> --- a/drivers/net/octeontx/base/meson.build
> +++ b/drivers/net/octeontx/base/meson.build
> @@ -22,4 +22,4 @@ base_lib = static_library('octeontx_base', sources,
> dependencies: static_objs,
> )
>
> -base_objs = base_lib.extract_all_objects()
> +base_objs = base_lib.extract_all_objects(recursive: true)
> diff --git a/drivers/net/qede/base/meson.build b/drivers/net/qede/base/meson.build
> index 614a0c3808..4ad177b478 100644
> --- a/drivers/net/qede/base/meson.build
> +++ b/drivers/net/qede/base/meson.build
> @@ -54,4 +54,4 @@ endforeach
> base_lib = static_library('qede_base', sources,
> dependencies: [static_rte_net, static_rte_bus_pci],
> c_args: c_args)
> -base_objs = base_lib.extract_all_objects()
> +base_objs = base_lib.extract_all_objects(recursive: true)
> diff --git a/drivers/net/thunderx/base/meson.build b/drivers/net/thunderx/base/meson.build
> index 704ee65771..cec45d0ae1 100644
> --- a/drivers/net/thunderx/base/meson.build
> +++ b/drivers/net/thunderx/base/meson.build
> @@ -13,4 +13,4 @@ base_lib = static_library('nicvf_base', sources,
> dependencies: static_rte_ethdev
> )
>
> -base_objs = base_lib.extract_all_objects()
> +base_objs = base_lib.extract_all_objects(recursive: true)
> diff --git a/drivers/net/txgbe/base/meson.build b/drivers/net/txgbe/base/meson.build
> index c6816b4279..7a30191472 100644
> --- a/drivers/net/txgbe/base/meson.build
> +++ b/drivers/net/txgbe/base/meson.build
> @@ -24,4 +24,4 @@ endforeach
> base_lib = static_library('txgbe_base', sources,
> dependencies: static_rte_eal,
> c_args: c_args)
> -base_objs = base_lib.extract_all_objects()
> +base_objs = base_lib.extract_all_objects(recursive: true)
> diff --git a/drivers/raw/ifpga/base/meson.build b/drivers/raw/ifpga/base/meson.build
> index 8d27c60213..db602cee69 100644
> --- a/drivers/raw/ifpga/base/meson.build
> +++ b/drivers/raw/ifpga/base/meson.build
> @@ -40,4 +40,4 @@ ext_deps += rtdep
> base_lib = static_library('ifpga_rawdev_base', sources,
> dependencies: static_rte_eal,
> c_args: cflags)
> -base_objs = base_lib.extract_all_objects()
> +base_objs = base_lib.extract_all_objects(recursive: true)
> --
> 2.32.0
>
next prev parent reply other threads:[~2021-08-17 12:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 5:24 [dpdk-dev] [PATCH] drivers: remove meson 0.46.0 warning jerinj
2021-07-30 7:35 ` [dpdk-dev] [PATCH v2] drivers: remove warning with meson 0.59.0 jerinj
2021-08-17 12:29 ` Bruce Richardson [this message]
2021-08-17 12:54 ` Jerin Jacob
2021-08-27 12:30 ` Thomas Monjalon
2021-08-27 12:55 ` Bruce Richardson
2021-08-27 14:36 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRurpLAYuOLkfDre@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=beilei.xing@intel.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dsinghrawat@marvell.com \
--cc=haiyue.wang@intel.com \
--cc=hkalra@marvell.com \
--cc=irusskikh@marvell.com \
--cc=jerinj@marvell.com \
--cc=jianwang@trustnetic.com \
--cc=jiawenwu@trustnetic.com \
--cc=mczekaj@marvell.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=rmody@marvell.com \
--cc=rosen.xu@intel.com \
--cc=thomas@monjalon.net \
--cc=tianfei.zhang@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=xuanziyang2@huawei.com \
--cc=zhouguoyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).