From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84E8AA0C43; Fri, 27 Aug 2021 14:56:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 091364067C; Fri, 27 Aug 2021 14:56:08 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 4423740150 for ; Fri, 27 Aug 2021 14:56:06 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10088"; a="197518175" X-IronPort-AV: E=Sophos;i="5.84,356,1620716400"; d="scan'208";a="197518175" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Aug 2021 05:56:05 -0700 X-IronPort-AV: E=Sophos;i="5.84,356,1620716400"; d="scan'208";a="687504171" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.24.30]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 27 Aug 2021 05:56:00 -0700 Date: Fri, 27 Aug 2021 13:55:57 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, Jerin Jacob , Andrew Rybchenko , Haiyue Wang , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Beilei Xing , Qiming Yang , Jiawen Wu , Harman Kalra , Rasesh Mody , Devendra Singh Rawat , Igor Russkikh , Maciej Czekaj , Jian Wang , Rosen Xu , Tianfei zhang , David Marchand , Jerin Jacob Message-ID: References: <20210730052434.2627818-1-jerinj@marvell.com> <6419779.oJmSqRMgos@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6419779.oJmSqRMgos@thomas> Subject: Re: [dpdk-dev] [PATCH v2] drivers: remove warning with meson 0.59.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Aug 27, 2021 at 02:30:44PM +0200, Thomas Monjalon wrote: > 17/08/2021 14:54, Jerin Jacob: > > On Tue, Aug 17, 2021 at 5:59 PM Bruce Richardson > > wrote: > > > > > > On Fri, Jul 30, 2021 at 01:05:48PM +0530, jerinj@marvell.com wrote: > > > > From: Jerin Jacob > > > > > > > > Since meson 0.59.0 version, the extract_all_objects() API > > > > need to pass explicit boolean value. > > > > > > > > To remove the following warning[1], added explicit `true` for > > > > extract_all_objects() use in codebase whever there is > > > > no argument. > > > > > > > > [1] > > > > WARNING: extract_all_objects called without setting recursive > > > > keyword argument. Meson currently defaults to > > > > non-recursive to maintain backward compatibility but > > > > the default will be changed in the future. > > > > > > > > > > Technically this is changing the default behaviour since it previously > > > defaulted to "false". However, since there should be no recursion involved > > > here anyway, I don't think it matters, correct? > > > > Yes. To be on the safer side, I just put "true" in case some drivers > > using for a recursive way. > > Bruce, are you OK with the change? > Yes. Acked-by: Bruce Richardson