From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77F32A0C4B; Mon, 13 Sep 2021 10:09:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4BF8240E28; Mon, 13 Sep 2021 10:09:03 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 3164D40151 for ; Mon, 13 Sep 2021 10:09:02 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10105"; a="219731299" X-IronPort-AV: E=Sophos;i="5.85,288,1624345200"; d="scan'208";a="219731299" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2021 01:08:55 -0700 X-IronPort-AV: E=Sophos;i="5.85,288,1624345200"; d="scan'208";a="696574229" Received: from omccleax-mobl1.ger.corp.intel.com (HELO bricha3-MOBL.ger.corp.intel.com) ([10.252.30.142]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 13 Sep 2021 01:08:53 -0700 Date: Mon, 13 Sep 2021 09:08:49 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: dev@dpdk.org Message-ID: References: <20210910175443.527801-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210910175443.527801-1-stephen@networkplumber.org> Subject: Re: [dpdk-dev] [PATCH] checkpatches: suppress warning about strlcpy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 10, 2021 at 10:54:43AM -0700, Stephen Hemminger wrote: > Latest versions of Linux kernel checkpatch now complain about > uses of strlcpy (kernel perfers strcspy). > > WARNING:STRLCPY: Prefer strscpy over strlcpy > > But DPDK does not have strcspy so suppress the warning. ^^^ typo :-) > > Signed-off-by: Stephen Hemminger We actually do have an rte_strscpy function, but on the other hand I believe that strlcpy should very much also be acceptable. Acked-by: Bruce Richardson > --- > devtools/checkpatches.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh > index c314d83a29d3..057208c8e1ea 100755 > --- a/devtools/checkpatches.sh > +++ b/devtools/checkpatches.sh > @@ -33,7 +33,7 @@ VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\ > PREFER_KERNEL_TYPES,PREFER_FALLTHROUGH,BIT_MACRO,CONST_STRUCT,\ > SPLIT_STRING,LONG_LINE_STRING,C99_COMMENT_TOLERANCE,\ > LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\ > -NEW_TYPEDEFS,COMPARISON_TO_NULL" > +NEW_TYPEDEFS,COMPARISON_TO_NULL,STRLCPY" > options="$options $DPDK_CHECKPATCH_OPTIONS" > > print_usage () { > -- > 2.30.2 >