From: Bruce Richardson <bruce.richardson@intel.com>
To: David Hunt <david.hunt@intel.com>
Cc: dev@dpdk.org, ciara.power@intel.com
Subject: Re: [dpdk-dev] [PATCH v1] usertools/telemetry: add non-interactive mode
Date: Mon, 13 Sep 2021 11:53:53 +0100 [thread overview]
Message-ID: <YT8twbTuh7o75uTs@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <YT8rTXug5G7yNDc7@bricha3-MOBL.ger.corp.intel.com>
On Mon, Sep 13, 2021 at 11:43:25AM +0100, Bruce Richardson wrote:
> On Thu, Sep 09, 2021 at 04:56:25PM +0100, David Hunt wrote:
> > Add non-interactive mode to dpdk-telemetry.py so that a query string
> > can be supplied on the command line, and script dumps out data and
> > exits. Handing for calling from scripts.
> >
> > Signed-off-by: David Hunt <david.hunt@intel.com>
> > ---
> Hi Dave,
>
> I'm not sure I like the use of "-q" for adding a query mode - it's more a
> shortcut parameter for a "quiet" mode. If I may, I'd suggest an alternative
> approach here might be to improve support for piping the input commands to
> the script instead so that you can do e.g.
>
> "echo /ethdev/stats,0 | dpdk-telemetry.py"
>
> and have that work well in a script.
>
> I'll do up a patchset for improving that and upstream it for feedback.
>
Now at: http://patches.dpdk.org/project/dpdk/list/?series=18867
/Bruce
next prev parent reply other threads:[~2021-09-13 10:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 15:56 David Hunt
2021-09-13 10:43 ` Bruce Richardson
2021-09-13 10:53 ` Bruce Richardson [this message]
2021-09-15 10:49 ` Power, Ciara
2021-09-15 10:58 ` David Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YT8twbTuh7o75uTs@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).