From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EFB96A0C4C; Thu, 2 Sep 2021 17:50:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 84F9D4003E; Thu, 2 Sep 2021 17:50:24 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 8EEC14003C for ; Thu, 2 Sep 2021 17:50:20 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10095"; a="282869589" X-IronPort-AV: E=Sophos;i="5.85,262,1624345200"; d="scan'208";a="282869589" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2021 08:50:19 -0700 X-IronPort-AV: E=Sophos;i="5.85,262,1624345200"; d="scan'208";a="691540483" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.1.171]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 02 Sep 2021 08:50:18 -0700 Date: Thu, 2 Sep 2021 16:50:14 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: dev@dpdk.org Message-ID: References: <20210901212707.25079-1-stephen@networkplumber.org> <20210902082458.1ba387f5@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210902082458.1ba387f5@hermes.local> Subject: Re: [dpdk-dev] [RFC] devbind: conform to PEP 8 recommended style X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 02, 2021 at 08:24:58AM -0700, Stephen Hemminger wrote: > On Thu, 2 Sep 2021 09:10:47 +0100 > Bruce Richardson wrote: > > > On Wed, Sep 01, 2021 at 02:27:07PM -0700, Stephen Hemminger wrote: > > > This fixes most of the warnings from the Flake8 style checker. > > > The ones remaing are long lines (we allow > 79 characters) > > > and a line break warning. The line break style changed in later > > > versions of PEP 8 and the tool is not updated. > > > > > > https://www.flake8rules.com/rules/W503.html > > > > > > Signed-off-by: Stephen Hemminger > > > --- > > > usertools/dpdk-devbind.py | 70 ++++++++++++++++++++++----------------- > > > 1 file changed, 39 insertions(+), 31 deletions(-) > > > > > Thanks for the cleanup. > > > > Acked-by: Bruce Richardson > > I don't use devbind (except in artifical testing), could someone with > hardware make sure that nothing changed here. I didn't go testing with all possible options and inputs, but basic operation for binding unbinding devices and giving error messages for invalid device names works fine with this patch applied. Tested-by: Bruce Richardson