From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4EB9A034F; Fri, 10 Sep 2021 09:49:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB130406B4; Fri, 10 Sep 2021 09:49:45 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 66BD440DF7 for ; Fri, 10 Sep 2021 09:49:42 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10102"; a="221073853" X-IronPort-AV: E=Sophos;i="5.85,282,1624345200"; d="scan'208";a="221073853" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2021 00:49:41 -0700 X-IronPort-AV: E=Sophos;i="5.85,282,1624345200"; d="scan'208";a="504962706" Received: from lcostigx-mobl2.ger.corp.intel.com (HELO bricha3-MOBL.ger.corp.intel.com) ([10.252.4.132]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 10 Sep 2021 00:49:39 -0700 Date: Fri, 10 Sep 2021 08:49:35 +0100 From: Bruce Richardson To: Honnappa Nagarahalli Cc: dev@dpdk.org, konstantin.ananyev@intel.com, david.marchand@redhat.com, feifei.wang2@arm.com, ruifeng.wang@arm.com, nd@arm.com, Feifei Wang Message-ID: References: <20210224212018.17576-1-honnappa.nagarahalli@arm.com> <20210909231312.2572006-1-honnappa.nagarahalli@arm.com> <20210909231312.2572006-2-honnappa.nagarahalli@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210909231312.2572006-2-honnappa.nagarahalli@arm.com> Subject: Re: [dpdk-dev] [PATCH v2 1/6] eal: reset lcore function pointer and argument X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 09, 2021 at 06:13:07PM -0500, Honnappa Nagarahalli wrote: > In the rte_eal_remote_launch function, the lcore function pointer is > checked for NULL. However, the pointer is never reset to NULL. Reset the > lcore function pointer and argument after the worker has completed > executing the lcore function. > No problems with this patch, but just in general observation. It would be good if we had test cases to cover these sorts of problems. If a test were added to the autotests for this issue we could observe the issue reproduced and easily verify it were fixed by this patch, giving us a high degree of confidence in the fix. Regards, /Bruce