From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9534A0C41; Wed, 15 Sep 2021 11:08:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 601934003F; Wed, 15 Sep 2021 11:08:55 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 5032B4003C for ; Wed, 15 Sep 2021 11:08:53 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10107"; a="222305335" X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="222305335" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2021 02:08:52 -0700 X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="544757586" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.4.180]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 15 Sep 2021 02:08:50 -0700 Date: Wed, 15 Sep 2021 10:08:46 +0100 From: Bruce Richardson To: Ferruh Yigit Cc: David Marchand , dev@dpdk.org, David Christensen Message-ID: References: <20210915050812.12798-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH] config/ppc: fix build with GCC >= 10 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 15, 2021 at 09:14:34AM +0100, Ferruh Yigit wrote: > On 9/15/2021 6:08 AM, David Marchand wrote: > > Like for python, multiline statements in meson must either use a > > backslash character (explicit continuation) or be enclosed in () > > (implicit continuation). > > > > python PEP8 recommends the latter [1], and it looks like meson had > > an issue with backslash before 0.50 [2]. > > > > 1: https://www.python.org/dev/peps/pep-0008/#multiline-if-statements > > 2: https://github.com/mesonbuild/meson/commit/90c9b868b20b > > > > Fixes: 394407f50c90 ("config/ppc: ignore GCC 11 psabi warnings") > > > > Reported-by: Ferruh Yigit > > Signed-off-by: David Marchand > > --- > > config/ppc/meson.build | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/config/ppc/meson.build b/config/ppc/meson.build > > index 0b1948fc7c..aa1327a595 100644 > > --- a/config/ppc/meson.build > > +++ b/config/ppc/meson.build > > @@ -20,8 +20,8 @@ endif > > > > # Suppress the gcc warning "note: the layout of aggregates containing > > # vectors with 4-byte alignment has changed in GCC 5". > > -if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and > > - cc.version().version_compare('<12.0') and cc.has_argument('-Wno-psabi') > > +if (cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and > > + cc.version().version_compare('<12.0') and cc.has_argument('-Wno-psabi')) > > add_project_arguments('-Wno-psabi', language: 'c') > > endif > > > > > > Tested-by: Ferruh Yigit Acked-by: Bruce Richardson