From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D55A2A0C41; Thu, 16 Sep 2021 14:14:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5BCC940151; Thu, 16 Sep 2021 14:14:37 +0200 (CEST) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mails.dpdk.org (Postfix) with ESMTP id 353404003F for ; Thu, 16 Sep 2021 14:14:36 +0200 (CEST) Received: by mail-wr1-f42.google.com with SMTP id g16so9143439wrb.3 for ; Thu, 16 Sep 2021 05:14:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tc320YpbRtWp9OWE8gZsByUGOQbGkzikQW1WGz05kO0=; b=TbV3d1aiO2Q5QoOVmRKrH0CiYK7McnlgT2oOa9bBjeP/np0kl0wBZ46KpyoVUHcRFO AzsimZLw+qhxaD7DkFGqXOoOidevoMQCXxg1UqC7sGRdOkFlJw0QGGR0yEHkvDP4D+bS 79vdfIOs6k05uIONeS8i3Bg6ipZ7ejWLZAxMl+rGKZWpY4fR4szlLYwFa71YguMH2Jit hYDdOCFJWoDX8oIMe1mCMR+dcMeDqV5+Rz8BB5ESlPOWpS4XHjiLdas/iPEOLxk7noZk MtVrG2OvRKRmV/gsxPxDNMN1MsaP/CYWLwgKlnIB/gxdxcMD/WIAOlQPNG+EOGj1vJq6 6gkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tc320YpbRtWp9OWE8gZsByUGOQbGkzikQW1WGz05kO0=; b=61mdScPusDn4DudhbjzCwuE/CNS5ytZqj+rjhztrCGkPNxME2AjLhcLH68YwHpkBx5 I6TnX13RJIgIpiWaE1CHFOnj7fnei60JzaBhtLe/u5+x/MRFMxBf8TyhrfcLep11yLLG 8CBSHhg6hkec6QBIMZ6BUrBcsNiQCiikFs5+1tiwQF2l31MYq6F3W/v6eCb6VJuSH83C rn86fZ/y5VDha61l5dGz4aJqUuvk7wXefybGvkjPWCYPir8GbDFu81ZdAfE3sMaUusmN JVaD372yycX/g6+82ODP/xZw2NeNu1D0u7lp37Mq7Btp7CSgR6pWa0oAlCIHZv6Es58b yKDg== X-Gm-Message-State: AOAM531o33G5ioB+bHU5Iw+aPfIrQuYtO6xwqtjkqYYLXOT4OdRjU/gC IABYIzEQG7PRW5wvhcIutpWcVQ== X-Google-Smtp-Source: ABdhPJy5V0vbamVI0d1L19CwqvZwfXbGZ4/emROwyj5QKS5An37eym9ObSJpJAw+P19qNKn6I+4TTQ== X-Received: by 2002:a05:6000:343:: with SMTP id e3mr5575161wre.96.1631794475930; Thu, 16 Sep 2021 05:14:35 -0700 (PDT) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id l7sm3151814wmj.9.2021.09.16.05.14.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Sep 2021 05:14:35 -0700 (PDT) Date: Thu, 16 Sep 2021 14:14:34 +0200 From: Olivier Matz To: Andrew Rybchenko Cc: Stephen Hemminger , dev@dpdk.org, konstantin.ananyev@intel.com Message-ID: References: <20210825220958.91326-1-stephen@networkplumber.org> <20210831193507.43426-1-stephen@networkplumber.org> <20210831193507.43426-4-stephen@networkplumber.org> <332aeaa2-b72d-b59e-74f8-0f7f3c2d0993@oktetlabs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <332aeaa2-b72d-b59e-74f8-0f7f3c2d0993@oktetlabs.ru> Subject: Re: [dpdk-dev] [PATCH v3 3/4] mbuf: make rte_mbuf_tx_offload as stable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 01, 2021 at 09:45:22AM +0300, Andrew Rybchenko wrote: > On 8/31/21 10:35 PM, Stephen Hemminger wrote: > > This function should be made stable now. > > > > Also, fix the docbook comment format. > > > > Fixes: 8d9c2c3a1f01 ("mbuf: add function to generate raw Tx offload value") > > Cc: konstantin.ananyev@intel.com > > Signed-off-by: Stephen Hemminger > > I'm not sure that it is correct to have promotion with > Fixes tag. It will require extra care on backporting to > stable. > > Acked-by: Andrew Rybchenko > > > --- > > lib/mbuf/rte_mbuf.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h > > index 7722b36ee44b..627790fe26e7 100644 > > --- a/lib/mbuf/rte_mbuf.h > > +++ b/lib/mbuf/rte_mbuf.h > > @@ -1773,7 +1773,7 @@ static inline int rte_pktmbuf_chain(struct rte_mbuf *head, struct rte_mbuf *tail > > return 0; > > } > > > > -/* > > +/** > > * @warning > > * @b EXPERIMENTAL: This API may change without prior notice. > > The warning must be removed. Just to highligth this comment from Andrew. > > > * > > @@ -1797,6 +1797,7 @@ static inline int rte_pktmbuf_chain(struct rte_mbuf *head, struct rte_mbuf *tail > > * @return > > * raw tx_offload value. > > */ > > +__rte_experimental > > static __rte_always_inline uint64_t > > rte_mbuf_tx_offload(uint64_t il2, uint64_t il3, uint64_t il4, uint64_t tso, > > uint64_t ol3, uint64_t ol2, uint64_t unused) > > >