From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45FE4A0548; Mon, 20 Sep 2021 13:21:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B19AD40DF7; Mon, 20 Sep 2021 13:21:58 +0200 (CEST) Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by mails.dpdk.org (Postfix) with ESMTP id 9566640DF5 for <dev@dpdk.org>; Mon, 20 Sep 2021 13:21:57 +0200 (CEST) Received: by mail-wr1-f44.google.com with SMTP id u15so28596777wru.6 for <dev@dpdk.org>; Mon, 20 Sep 2021 04:21:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=UtsyAYQpOnKh2ekkHS9mxlWgglNLPuBT9+l5Svkbkg4=; b=D6nj/3w7irfgiIUT4YCDhUvkRW1f3SOqdr5oi/Cy6YBtRoyQ7g6ew79XOunYi0spUp mFN8JPM92bNH7txDFSQUK5Lpg1rE3t+GK1WGoMA7VNtnhp/CW/zG/SvMOsodE5lv+nkQ 04sPGhmaxbmw9FC8Xz86JMw1oeTsSmlXVy8hntVToN1BAzYNYN/rG+i8Pk6p00GI7GPk K/3PI9YOE08FYCyf4LYALeD5INBvOW4EVf4QhT2B9fUzceCGa26y98I9Hyl2NPChbcp9 nop4U+QohG+HshQkS1B5IxPR6QoU26ybM1eAKa+O9RPRm+xg3I3Wj8brFEnSQrMCw5Hp PjfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UtsyAYQpOnKh2ekkHS9mxlWgglNLPuBT9+l5Svkbkg4=; b=ArRyu3xPSCSu5T2fBsSbUVTmnixZf658zMIDFO1g1SLmlA5qORYtskJmV6PNdk3NvV 1c8k3Lt+NBZeCq5lIik3Q9enJAjFfYusvUXbqSW1aZ0QbBRUJ38q6RFISH7BHGNz3gwS X0bHefYHK6L5+IY83Dkp73EcvnidRJlC9Iuv82M9zMiqpYxVpmGMrBKEVpM58PGA6liq IK3xNw5XIsN1uMHYzzJBLegnL/j2MTGAinfuDx2J0F/g3k4VgAvuJPxK6lHxEB28mVWe vKUCv7qPv5QZsG3neAviejcQYXlraQnSpl0in3xEfNvvfC5CxycPXU/loMf3TYPnh9Q7 LEsg== X-Gm-Message-State: AOAM532ec1Hyr/uHDTCB4Zl+U3Pe97sm5HxvFZ2UAcjtdwYx/cgvRSXe wyCeYlm0Hkq14d3fyYrI610bUw== X-Google-Smtp-Source: ABdhPJy5lmJ6G0Xcb+kYlZRq9zUxv1DQx6Pf9cx4/F5+4HkCkU5sIwLp1i39QxYHyyGtwMCpyhAWQA== X-Received: by 2002:a05:600c:a05:: with SMTP id z5mr23833491wmp.73.1632136917214; Mon, 20 Sep 2021 04:21:57 -0700 (PDT) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id u13sm15906614wrt.41.2021.09.20.04.21.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Sep 2021 04:21:56 -0700 (PDT) Date: Mon, 20 Sep 2021 13:21:56 +0200 From: Olivier Matz <olivier.matz@6wind.com> To: David Marchand <david.marchand@redhat.com> Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, Ray Kinsella <mdr@ashroe.eu>, dev <dev@dpdk.org> Message-ID: <YUhu1IIcgytdWUct@platinum> References: <20210910231639.789066-1-dmitry.kozliuk@gmail.com> <20210910231639.789066-2-dmitry.kozliuk@gmail.com> <CAJFAV8wMW4xEq=QhQD4C2qwPayKA4uQLFenrPFWmErgPH_MCQA@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <CAJFAV8wMW4xEq=QhQD4C2qwPayKA4uQLFenrPFWmErgPH_MCQA@mail.gmail.com> Subject: Re: [dpdk-dev] [PATCH] cmdline: reduce ABI X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Hi Dmitry, On Mon, Sep 20, 2021 at 01:11:23PM +0200, David Marchand wrote: > On Sat, Sep 11, 2021 at 1:17 AM Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote: > > > > Remove the definition of `struct cmdline` from public header. > > Deprecation notice: > > https://mails.dpdk.org/archives/dev/2020-September/183310.html > > > > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> > > This patch lgtm. > Acked-by: David Marchand <david.marchand@redhat.com> Acked-by: Olivier Matz <olivier.matz@6wind.com> Many thanks Dmitry for taking care of this. > > --- > > I would also hide struct rdline to be able to alter buffer size, > > but we don't have a deprecation notice for it. > > Fyi, I found one project looking into a rdline pointer to get the back > reference to cmdline stored in opaque. > https://github.com/Gandi/packet-journey/blob/master/app/cmdline.c#L1398 > > This cmdline pointer is then dereferenced to get s_out. > Given that we announced cmdline becoming opaque, they would have to > handle the first API change in any case. > I don't think another API change would really make a big difference to them. > > Plus, this project seems stuck to 18.08 support. I agree with you and David, it would make sense to also hide the rdline struct at the same time. Olivier