From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6873A0548; Mon, 20 Sep 2021 17:57:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 67DD440DF7; Mon, 20 Sep 2021 17:57:06 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id A81A140DF5 for ; Mon, 20 Sep 2021 17:57:04 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10113"; a="223197833" X-IronPort-AV: E=Sophos;i="5.85,308,1624345200"; d="scan'208";a="223197833" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2021 08:57:03 -0700 X-IronPort-AV: E=Sophos;i="5.85,308,1624345200"; d="scan'208";a="548842024" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.17.156]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 20 Sep 2021 08:57:02 -0700 Date: Mon, 20 Sep 2021 16:56:58 +0100 From: Bruce Richardson To: Harman Kalra Cc: dev@dpdk.org, ciara.power@intel.com, Anatoly Burakov Message-ID: References: <20210915095336.105635-1-hkalra@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210915095336.105635-1-hkalra@marvell.com> Subject: Re: [dpdk-dev] [PATCH] eal: add telemetry callbacks for memory info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 15, 2021 at 03:23:36PM +0530, Harman Kalra wrote: > Registering new telemetry callbacks to dump named (memzones) > and unnamed (malloc) memory information to a file provided as > an argument. > > Example: > Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2 > {"version": "DPDK 21.08.0", "pid": 34075, "max_output_len": 16384} > Connected to application: "dpdk-testpmd" > --> /eal/malloc_dump,/tmp/malloc_dump > {"/eal/malloc_dump": {"Malloc elements file: ": "/tmp/malloc_dump"}} > --> > --> /eal/malloc_info,/tmp/info > {"/eal/malloc_info": {"Malloc stats file: ": "/tmp/info"}} > --> > --> > --> /eal/memzone_dump,/tmp/memzone_info > {"/eal/memzone_dump": {"Memzones count: ": 11, \ > "Memzones info file: ": "/tmp/memzone_info"}} > > Signed-off-by: Harman Kalra > --- For this info, why not just send the data out as telemetry data rather than writing files on the filesystem containing it? If the info is too large to dump it all in a single go, a shortened form could be sent via some form of list call, and additional calls could be used to provide more detail on specific items in the list. Also, this seems more a debugging operation than a telemetry one, though I don't have a strong objection to the info being exported as telemetry directly (just not via filesystem). Regards, /Bruce