From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C3B5A0032; Fri, 1 Oct 2021 18:39:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 173D041155; Fri, 1 Oct 2021 18:39:24 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 8DB114114F for ; Fri, 1 Oct 2021 18:39:22 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10124"; a="204974806" X-IronPort-AV: E=Sophos;i="5.85,339,1624345200"; d="scan'208";a="204974806" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2021 09:39:21 -0700 X-IronPort-AV: E=Sophos;i="5.85,339,1624345200"; d="scan'208";a="540352262" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.10.40]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 01 Oct 2021 09:39:20 -0700 Date: Fri, 1 Oct 2021 17:39:16 +0100 From: Bruce Richardson To: Dmitry Kozlyuk Cc: dev@dpdk.org Message-ID: References: <20211001163726.78308-1-dmitry.kozliuk@gmail.com> <20211001163726.78308-3-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211001163726.78308-3-dmitry.kozliuk@gmail.com> Subject: Re: [dpdk-dev] [PATCH 2/2] buildtools: enable chkincs on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 01, 2021 at 07:37:26PM +0300, Dmitry Kozlyuk wrote: > Independent header compilation test (chkincs) was disabled on Windows. > The comment stated that the shebang line in the generator script was not > working. Meson 0.57.0, currently recommended for Windows, successfully > parses that line and invokes the script. Remove the OS restriction > as its reason no longer applies. > > Fixes: 05050ac4ce99 ("build: add header includes check") > Cc: bruce.richardson@intel.com > > Signed-off-by: Dmitry Kozlyuk Acked-by: Bruce Richardson