From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75E80A0C4D; Mon, 4 Oct 2021 18:48:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E93934138B; Mon, 4 Oct 2021 18:48:14 +0200 (CEST) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mails.dpdk.org (Postfix) with ESMTP id 55A604138A for ; Mon, 4 Oct 2021 18:48:14 +0200 (CEST) Received: by mail-wr1-f50.google.com with SMTP id s15so3697306wrv.11 for ; Mon, 04 Oct 2021 09:48:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=UzpNqDmEFP0fig0KQ/TarmLWmDlsFPB+K8AVghSjITc=; b=IT9UnHbVTCJS08i2TSt1hSkXCj7zcfRt2sW7I4gQ5NFEuDnI6B5BytGIblBQotA0Y9 EQKzeZh2iN3iLwWdifLgtL/iob4vlumc5DL9z31hAQktyAjih1PBc77V53uiv2aIfIco axRbDa3zMwPTXSXJR05CDuwJKr3MvmZE58klOiMUfV8pzPzBiUUvNYupofaCvqwO2Piy Sda9HKuZ87CqaDAkLAk8nKYBsYk6+X83arzNbV/TiA3J0qXZfTae/EymlYZoS/rUtiGT uU7HWV9YpQDQAdSReCu/JO4f2M5HWTp6tPKxNBz0sCxYLZs0xzicToJmKRojr3blWaXJ qPTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UzpNqDmEFP0fig0KQ/TarmLWmDlsFPB+K8AVghSjITc=; b=Vc83ATEp0R4Z92AD3DqGU4dKYXkztIzE7DgEpxDXk9j192VzZrAJ9QXDX9VTCbczfi aQMrYS6/A2C8i6BPsa0EJlf/MqWZxJCrPQy/bcA1qdW+5hVnSWBaTXIzutn40AveOw3q mXDpQFh+yxZuxC5efCpCQkpfO/YQY1jYDM1scgiBj3ml1lQwuZE6r5rqEwwRVtqRjDTA pFI92xE84hwm83aJ6/S3rNukXFytxdCbzyMpbPNR5G7hApiBiQBgpsyZR1HYIgZTWfG3 szvEUgYw+imHkDGbfTW6m0In7vFt6RCHuiZBiiKv54X1Y2qoTfmmGFrZ0L/3iDgvCbxN 64dg== X-Gm-Message-State: AOAM533tlik21ak0JGhF4e96rE3AhA6gadwtt2TPk0YUNbRWO7xasLJM 2ffaChvdNZ0Yh+VAuhaSAAzVwg== X-Google-Smtp-Source: ABdhPJzDeim53iy3kMebib4d4RoK8Vp4sIGBarYgT7XHC5B/fT6V+AMGCDTdivsWLREwt//uiqm+QA== X-Received: by 2002:a05:6000:1a89:: with SMTP id f9mr15482305wry.19.1633366093928; Mon, 04 Oct 2021 09:48:13 -0700 (PDT) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id 2sm1722148wmf.30.2021.10.04.09.48.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 09:48:13 -0700 (PDT) Date: Mon, 4 Oct 2021 18:48:12 +0200 From: Olivier Matz To: Stephen Hemminger Cc: Gregory Etelson , dev@dpdk.org, matan@nvidia.com, rasland@nvidia.com, thomas@monjalon.net, Bernard Iremonger Message-ID: References: <20210527152858.13312-1-getelson@nvidia.com> <20211004121323.6677-1-getelson@nvidia.com> <20211004085934.7105af27@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211004085934.7105af27@hermes.local> Subject: Re: [dpdk-dev] [PATCH v4] net: introduce IPv4 ihl and version fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 04, 2021 at 08:59:34AM -0700, Stephen Hemminger wrote: > On Mon, 4 Oct 2021 15:13:22 +0300 > Gregory Etelson wrote: > > > diff --git a/app/test/test_flow_classify.c b/app/test/test_flow_classify.c > > index 951606f248..4f64be5357 100644 > > --- a/app/test/test_flow_classify.c > > +++ b/app/test/test_flow_classify.c > > @@ -95,7 +95,7 @@ static struct rte_acl_field_def ipv4_defs[NUM_FIELDS_IPV4] = { > > * dst mask 255.255.255.00 / udp src is 32 dst is 33 / end" > > */ > > static struct rte_flow_item_ipv4 ipv4_udp_spec_1 = { > > - { 0, 0, 0, 0, 0, 0, IPPROTO_UDP, 0, > > + { { .version_ihl = 0}, 0, 0, 0, 0, 0, IPPROTO_UDP, 0, > > RTE_IPV4(2, 2, 2, 3), RTE_IPV4(2, 2, 2, 7)} > > }; > > This ends up being an API change which was not announced. It was announced (commit f7383e7c7ec1). But that's a good point: - the removal of the deprecation is missing in the patch - the message notice also talks about union for fragment_offset