From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CD955A0C43;
	Wed, 20 Oct 2021 11:40:24 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id BDB36411BB;
	Wed, 20 Oct 2021 11:40:24 +0200 (CEST)
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by mails.dpdk.org (Postfix) with ESMTP id 4F93740142
 for <dev@dpdk.org>; Wed, 20 Oct 2021 11:40:23 +0200 (CEST)
X-IronPort-AV: E=McAfee;i="6200,9189,10142"; a="215904973"
X-IronPort-AV: E=Sophos;i="5.87,166,1631602800"; d="scan'208";a="215904973"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
 by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 20 Oct 2021 02:40:22 -0700
X-IronPort-AV: E=Sophos;i="5.87,166,1631602800"; d="scan'208";a="494545979"
Received: from bricha3-mobl.ger.corp.intel.com ([10.252.29.221])
 by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;
 20 Oct 2021 02:40:20 -0700
Date: Wed, 20 Oct 2021 10:40:17 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Ray Kinsella <mdr@ashroe.eu>,
 Chengwen Feng <fengchengwen@huawei.com>,
 Morten =?iso-8859-1?Q?Br=F8rup?= <mb@smartsharesystems.com>,
 Kevin Laatz <kevin.laatz@intel.com>, Conor Walsh <conor.walsh@intel.com>
Message-ID: <YW/kAb5ORPStJznE@bricha3-MOBL.ger.corp.intel.com>
References: <20211020065944.19617-1-david.marchand@redhat.com>
 <20211020065944.19617-2-david.marchand@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211020065944.19617-2-david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] dmadev: remove symbol versioning for
 inline helpers
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Oct 20, 2021 at 08:59:44AM +0200, David Marchand wrote:
> Inline helpers have no global symbols in shared libraries.
> There is no reason to ask for versioning (plus this library would not
> build on Windows).
> 
> Fixes: 91e581e5c924 ("dmadev: add data plane API")
> Fixes: ea8cf0f8536d ("dmadev: add burst capacity API")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>