From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA5F8A0C43; Mon, 18 Oct 2021 10:10:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 497E840141; Mon, 18 Oct 2021 10:10:46 +0200 (CEST) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mails.dpdk.org (Postfix) with ESMTP id 5D1A24003C for ; Mon, 18 Oct 2021 10:10:45 +0200 (CEST) Received: by mail-wm1-f53.google.com with SMTP id v127so7928488wme.5 for ; Mon, 18 Oct 2021 01:10:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=W4GhkHWo80pAuRu3fAV1x045A0YYKdgWOagI6N3/GHo=; b=Ym7pgrsQMm00ypW0gZ38gIrPNNjc71eKeY9V7SVBAXMvXRaqdcgRMuHasTofZALX6u ghPYePRiwcuKVrBob/rp/E+XiLH/48VjhbxfqaH81L81QSznKVG5IIVNQSBDTBM0H0s0 l8wNb0S3YnMjkQZrIDV23CsM0D52s0RqZ+X7sySJTZ6Lr5Re9JW47tGq18WcGtSty81s NL5nNK2qHfggOy7DvNZlAP+rfdio1IZ3W6ZoR2y/mrJB1OaaMgIEQtlsUT36bS4ylqc7 BeioWpqqeu8920orxwvjGXy68rGrA3W/6sCnpxHv66owsgW2xXNCBLFAgsQYeCBQik1l 7Fiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=W4GhkHWo80pAuRu3fAV1x045A0YYKdgWOagI6N3/GHo=; b=cuxmXz00gGIO+szPNyI2yzEWPpuwYH5Kr+2qsc39Q7M/l6CNqVD7/4dICiZ9H+r5lS ys2KSLkOBoPKy9WotR6R4jqWZSbWAFqTlvGMtzqR8bUB8iLn0hS+LUpRBB1VDsXLnLoq Aje4dtfj5fAMqIwqmbeaZEnVWv8yvDvZGe0ZTh1DJdRM69Dq4kmFLA7/hWRqKGuGwqSc 6aPono73RqZwvl3SWrF1Qc+KBKAfr7rnKmScym5V2RqPM4t7xfWg+KdXz/3Pm4cLoi/o 1Td/zVZUfTdszBSXNibYAIN39+KZGBEjB8wfKI7CXtyAMPwrKlMMr8YyyNv1nOx8htLK hArA== X-Gm-Message-State: AOAM533ypxZKX68STPbUsOn0mbvcpk9LOvZnJ1QtfearVn5wAJabHdeE NWgPWhJzXklYlq65C4bRHXq/Vg== X-Google-Smtp-Source: ABdhPJzkbxgS3U0xyEIoJCqZEhSKNLkR+8IpxojbLb95RZst3tU6K8r1+KdWPzt+PT8ngQsPGtXlHw== X-Received: by 2002:a1c:4c19:: with SMTP id z25mr28770347wmf.4.1634544645141; Mon, 18 Oct 2021 01:10:45 -0700 (PDT) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id k13sm17629075wmj.41.2021.10.18.01.10.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Oct 2021 01:10:44 -0700 (PDT) Date: Mon, 18 Oct 2021 10:10:43 +0200 From: Olivier Matz To: Andrew Rybchenko Cc: dev@dpdk.org, David Marchand Message-ID: References: <20210929214817.18082-1-olivier.matz@6wind.com> <20211015192408.21798-1-olivier.matz@6wind.com> <20211015192408.21798-3-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v2 2/4] mbuf: mark old VLAN offload flags as deprecated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Andrew, On Sat, Oct 16, 2021 at 10:50:50AM +0300, Andrew Rybchenko wrote: > On 10/15/21 10:24 PM, Olivier Matz wrote: > > The flags PKT_TX_VLAN_PKT and PKT_TX_QINQ_PKT are > > marked as deprecated since commit 380a7aab1ae2 ("mbuf: rename deprecated > > VLAN flags") (2017). But they were not using the RTE_DEPRECATED > > macro, because it did not exist at this time. Add it, and replace > > usage of these flags. > > > > Signed-off-by: Olivier Matz > > Acked-by: Andrew Rybchenko > > I'd remove these flags completely. 4 years is definitely > enough. Yes, I realize that because of missing > RTE_DEPRECATED markup users were not warning on build. I kept them because David pointed me that these flags are still used by other projects. Adding an explicit RTE_DEPRECATED() would prevent this, and... it doesn't bother to add one more year :) Thank you for the review.