From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9903AA0C43; Tue, 19 Oct 2021 12:37:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8220940E2D; Tue, 19 Oct 2021 12:37:48 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 20D9640683; Tue, 19 Oct 2021 12:37:46 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10141"; a="208578550" X-IronPort-AV: E=Sophos;i="5.85,384,1624345200"; d="scan'208";a="208578550" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2021 03:37:46 -0700 X-IronPort-AV: E=Sophos;i="5.85,384,1624345200"; d="scan'208";a="494038794" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.14.183]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 19 Oct 2021 03:37:43 -0700 Date: Tue, 19 Oct 2021 11:37:40 +0100 From: Bruce Richardson To: zhihongx.peng@intel.com Cc: david.marchand@redhat.com, anatoly.burakov@intel.com, konstantin.ananyev@intel.com, stephen@networkplumber.org, cristian.dumitrescu@intel.com, john.mcnamara@intel.com, dev@dpdk.org, xueqin.lin@intel.com, stable@dpdk.org Message-ID: References: <20211015151110.1876850-4-zhihongx.peng@intel.com> <20211019101207.1451058-1-zhihongx.peng@intel.com> <20211019101207.1451058-4-zhihongx.peng@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211019101207.1451058-4-zhihongx.peng@intel.com> Subject: Re: [dpdk-dev] [PATCH v11 4/4] performance-thread: Fix cross compilation failed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 19, 2021 at 06:12:07PM +0800, zhihongx.peng@intel.com wrote: > From: Zhihong Peng > > The gcc(arm-linux-gcc) will check code more stricter when ASan enabled. > "strncpy specified bound XX equals destination size" error occurs here. > > Fixes: 116819b9ed0d ("examples/performance-thread: add lthread subsystem") > Cc: stable@dpdk.org > > Signed-off-by: Xueqin Lin > Signed-off-by: Zhihong Peng > --- > v11: Use rte_strlcpy to replace strncpy. > --- +1 to using strlcpy, but it should be "strlcpy" rather than "rte_strlcpy" which should be used. Analysis tools are likely to be familiar with strlcpy but won't know the DPDK-specific version of it. With that change to remove the rte_ prefix Acked-by: Bruce Richardson /Bruce