From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AAE17A0C41; Tue, 19 Oct 2021 17:06:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8EF1741164; Tue, 19 Oct 2021 17:06:25 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id F1DCD4111D for ; Tue, 19 Oct 2021 17:06:23 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10142"; a="227310719" X-IronPort-AV: E=Sophos;i="5.87,164,1631602800"; d="scan'208";a="227310719" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2021 08:04:33 -0700 X-IronPort-AV: E=Sophos;i="5.87,164,1631602800"; d="scan'208";a="494139506" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.14.183]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 19 Oct 2021 08:04:31 -0700 Date: Tue, 19 Oct 2021 16:04:27 +0100 From: Bruce Richardson To: "Power, Ciara" Cc: Harman Kalra , "dev@dpdk.org" , "Burakov, Anatoly" Message-ID: References: <20210915095336.105635-1-hkalra@marvell.com> <20211008124407.24738-1-hkalra@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v2] eal: add telemetry callbacks for memory info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 15, 2021 at 09:28:43AM +0100, Power, Ciara wrote: > Hi Harman, > > >-----Original Message----- > >From: Harman Kalra > >Sent: Thursday 14 October 2021 18:17 > >To: Harman Kalra ; dev@dpdk.org; Richardson, Bruce > >; Power, Ciara ; > >Burakov, Anatoly > >Subject: RE: [PATCH v2] eal: add telemetry callbacks for memory info > > > >Ping... > > > >> -----Original Message----- > >> From: Harman Kalra > >> Sent: Friday, October 8, 2021 6:14 PM > >> To: dev@dpdk.org; bruce.richardson@intel.com; ciara.power@intel.com; > >> Anatoly Burakov > >> Cc: Harman Kalra > >> Subject: [PATCH v2] eal: add telemetry callbacks for memory info > >> > >> Registering new telemetry callbacks to list named (memzones) and > >> unnamed > >> (malloc) memory reserved and return information based on arguments > >> provided by user. > >> > >> Example: > >> Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2 > >> {"version": "DPDK 21.11.0-rc0", "pid": 59754, "max_output_len": 16384} > >> Connected to application: "dpdk-testpmd" > >> --> > >> --> /eal/memzone_list > >> {"/eal/memzone_list": [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13]} > >> --> > >> --> > >> --> /eal/memzone_info,0 > >> {"/eal/memzone_info": {"Zone": 0, "Name": "rte_eth_dev_data", \ > >> "Length": 225408, "Address": "0x13ffc0280", "Socket": 0, "Flags": 0, \ > >> "Hugepage_size": 536870912, "Hugepage_base": "0x120000000", \ > >> "Hugepage_used": 1}} > >> --> > >> --> > >> --> /eal/memzone_info,6 > >> {"/eal/memzone_info": {"Zone": 6, "Name": "MP_mb_pool_0_0", \ > >> "Length": 669918336, "Address": "0x15811db80", "Socket": 0, \ > >> "Flags": 0, "Hugepage_size": 536870912, "Hugepage_base": > >> "0x140000000", \ > >> "Hugepage_used": 2}} > >> --> > >> --> > >> --> /eal/memzone_info,14 > >> {"/eal/memzone_info": null} > >> --> > >> --> > >> --> /eal/heap_list > >> {"/eal/heap_list": [0]} > >> --> > >> --> > >> --> /eal/heap_info,0 > >> {"/eal/heap_info": {"Head id": 0, "Name": "socket_0", \ > >> "Heap_size": 1610612736, "Free_size": 927645952, \ > >> "Alloc_size": 682966784, "Greatest_free_size": 529153152, \ > >> "Alloc_count": 482, "Free_count": 2}} > >> > >> Signed-off-by: Harman Kalra > >> --- > > > From a Telemetry usage point of view, > > Acked-by: Ciara Power Agree, this patch is much more in keeping with the existing way of working than the v1. Acked-by: Bruce Richardson