From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C98DFA0C41; Tue, 19 Oct 2021 18:13:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B64B641109; Tue, 19 Oct 2021 18:13:56 +0200 (CEST) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mails.dpdk.org (Postfix) with ESMTP id C18BE41109 for <dev@dpdk.org>; Tue, 19 Oct 2021 18:13:54 +0200 (CEST) Received: by mail-wm1-f49.google.com with SMTP id z77-20020a1c7e50000000b0030db7b70b6bso3707419wmc.1 for <dev@dpdk.org>; Tue, 19 Oct 2021 09:13:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=77JbSTnj87JseW7twDrR70dgceKJg+LYBUwu35w28wA=; b=j4qfmuh1GznFgHH0Dj8SpfYiTfYcB9AOEk/Kd0pTprRTB6MlKjcWXrOG5VOsdjkV2q YCuREnoEwWoZ0CD7nfR3qFNbBFf3ylOpBIrrZxqMBxbXGviJO72P54KED98oHs1YUS+1 reN9QrbYcb2b7WOg0qy46W8rgGNMw5PqXYHphSGmZ29cp7Ybxw8vHn/biOlGyUkuruPf DOCsMkIQq+LOawvdEr+gnulCmarNONrIhQuY/gHQiyqUOrIBVub4Q+8MFe6X6+9I8+66 k5Tmq7P3VUnbqH/ijbM1cfwaipbLhAfKbdHCBtp8AatxMKboRCkV3Xs31hPdyIXShn62 /I+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=77JbSTnj87JseW7twDrR70dgceKJg+LYBUwu35w28wA=; b=jUw0/eUSX/mwl39T1djUSbDXqUMeeI7VLyKk6VyMPG0sGzkK1iIEsF9lRYqR0Eeswm ZpnMr9zrknXYx+Vym3vABLCcdXFRFVlEo2KQFdOFKgfJ6qbAFCCvUO7cXsOR0//0RXT/ Bp/JDGjquAcIUOH98NXc6plxlIu2jl3aDmCxkGL53g9Oe7YMhcax+p3NTusb7tmgp5ch KbiSkHnseERFcbGpVlpK5vvWTTPMYObNMHx1bl/xJ+cJPZvv5VR42Eb+vBnqgpV7jjP6 Y1tcJO1Q9L9qEIgk/IZJxI56nFdhVW/hOTqQyJicgIhAl1HFST4z9h/0YcUDFLtNpWAA epqw== X-Gm-Message-State: AOAM531hD3vbOmdzixidv5LbhnkVYuVub/EzG2/0oHDy3VImxsuXzg8F 9V6Un8QfCaFoZe3bw0g0Xn//zQ== X-Google-Smtp-Source: ABdhPJxAL/wEtn12lncFMuRqBb09HsmdRh7fStK5AMzqZTyvpueTaicvvQ6ZuDk7ivVEwuiivCTwdw== X-Received: by 2002:adf:bb09:: with SMTP id r9mr45619538wrg.238.1634660034575; Tue, 19 Oct 2021 09:13:54 -0700 (PDT) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id f10sm2455446wri.84.2021.10.19.09.13.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Oct 2021 09:13:54 -0700 (PDT) Date: Tue, 19 Oct 2021 18:13:53 +0200 From: Olivier Matz <olivier.matz@6wind.com> To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> Cc: David Marchand <david.marchand@redhat.com>, Maryam Tahhan <maryam.tahhan@intel.com>, Reshma Pattan <reshma.pattan@intel.com>, Xiaoyun Li <xiaoyun.li@intel.com>, Pavan Nikhilesh <pbhagavatula@marvell.com>, Shijith Thotton <sthotton@marvell.com>, Jerin Jacob <jerinj@marvell.com>, "Artem V. Andreev" <artem.andreev@oktetlabs.ru>, Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K <kirankumark@marvell.com>, Maciej Czekaj <mczekaj@marvell.com>, Maxime Coquelin <maxime.coquelin@redhat.com>, Chenbo Xia <chenbo.xia@intel.com>, dev@dpdk.org Message-ID: <YW7uwaJH0JQyntxW@platinum> References: <20211018144907.1145028-1-andrew.rybchenko@oktetlabs.ru> <20211019100845.1632332-1-andrew.rybchenko@oktetlabs.ru> <20211019100845.1632332-3-andrew.rybchenko@oktetlabs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211019100845.1632332-3-andrew.rybchenko@oktetlabs.ru> Subject: Re: [dpdk-dev] [PATCH v2 2/6] mempool: add namespace prefix to flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Tue, Oct 19, 2021 at 01:08:41PM +0300, Andrew Rybchenko wrote: > Fix the mempool flgas namespace by adding an RTE_ prefix to the name. nit: flgas -> flags > The old flags remain usable, to be deprecated in the future. > > Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> (...) > @@ -777,12 +777,12 @@ rte_mempool_cache_free(struct rte_mempool_cache *cache) > rte_free(cache); > } > > -#define MEMPOOL_KNOWN_FLAGS (MEMPOOL_F_NO_SPREAD \ > - | MEMPOOL_F_NO_CACHE_ALIGN \ > - | MEMPOOL_F_SP_PUT \ > - | MEMPOOL_F_SC_GET \ > - | MEMPOOL_F_POOL_CREATED \ > - | MEMPOOL_F_NO_IOVA_CONTIG \ > +#define MEMPOOL_KNOWN_FLAGS (RTE_MEMPOOL_F_NO_SPREAD \ > + | RTE_MEMPOOL_F_NO_CACHE_ALIGN \ > + | RTE_MEMPOOL_F_SP_PUT \ > + | RTE_MEMPOOL_F_SC_GET \ > + | RTE_MEMPOOL_F_POOL_CREATED \ > + | RTE_MEMPOOL_F_NO_IOVA_CONTIG \ > ) I guess MEMPOOL_KNOWN_FLAGS was kept as is on purpose.