From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E1AFA0C47; Tue, 12 Oct 2021 17:40:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C176410E4; Tue, 12 Oct 2021 17:40:41 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 0E1FD4119A for ; Tue, 12 Oct 2021 17:40:39 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10135"; a="214336381" X-IronPort-AV: E=Sophos;i="5.85,368,1624345200"; d="scan'208";a="214336381" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2021 08:40:39 -0700 X-IronPort-AV: E=Sophos;i="5.85,368,1624345200"; d="scan'208";a="591814649" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.13.155]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 12 Oct 2021 08:40:37 -0700 Date: Tue, 12 Oct 2021 16:40:34 +0100 From: Bruce Richardson To: "Power, Ciara" Cc: "dev@dpdk.org" , David Marchand , "Burakov, Anatoly" , Kevin Traynor Message-ID: References: <20210915141030.23514-1-bruce.richardson@intel.com> <20211008171852.736387-1-bruce.richardson@intel.com> <20211008171852.736387-4-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v7 3/5] telemetry: use unique socket paths for in-memory mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 12, 2021 at 04:37:07PM +0100, Power, Ciara wrote: > Hi Bruce, > > >-----Original Message----- > >From: Richardson, Bruce > >Sent: Friday 8 October 2021 18:19 > >To: dev@dpdk.org > >Cc: Power, Ciara ; David Marchand > >; Burakov, Anatoly > >; Kevin Traynor ; > >Richardson, Bruce > >Subject: [PATCH v7 3/5] telemetry: use unique socket paths for in-memory > >mode > > > >When running in in-memory mode, multiple processes can use the same > >runtime dir, leading to conflicts with the telemetry sockets in that directory. > >We can resolve this by appending a suffix to each socket beyond the first, > >with the suffix being an increasing counter value. > >Each process uses the first unused socket counter value. > > > >Signed-off-by: Bruce Richardson > >--- > > > Thanks, > > Acked-by: Ciara Power Thanks. I'm actually in two minds as to whether to this patch should be merged with the previous one. It was already reviewed and acked as a bugfix, but this patch also affects a lot of the same areas of code. What do you think? /Bruce