From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 185C2A0C4B; Fri, 15 Oct 2021 11:00:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D923040692; Fri, 15 Oct 2021 11:00:23 +0200 (CEST) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mails.dpdk.org (Postfix) with ESMTP id 2991640041 for <dev@dpdk.org>; Fri, 15 Oct 2021 11:00:22 +0200 (CEST) Received: by mail-wr1-f42.google.com with SMTP id r10so25141722wra.12 for <dev@dpdk.org>; Fri, 15 Oct 2021 02:00:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qQQtKC3WlFwZ9h3Jz7AR/Fup46i6OQuJ6MbZuUFLfUM=; b=Jt0EIyuOFk2uCpkr1P3x9ZdFlx+z+VXURliExiv4fOGI6wNeD2Cvrgn1FmyoeMsQ2I ZhzSgNjkvnTYMPwW9hpoErfk5WT1sDHWfcvcYb1WidSSdsXCNNuPe//H9eOm2gqNlHVw spSaZJZ5R7Nk/6bWmNcOnGhiBfCRtbT0xaSVyrX1uINOQpD0Y6CHiKJK3Nz7NShgFduU HDOT8hr0OZUA9yxQhBvt6/69yvSiBStA9fc2n+B9ns8o+nnETDyMxZaJVnEWNjmnyNYj GCIjwZndC0Di7ITdh4IY9hiwNt2rq40HPgcMvH3XcR+wEfSOGELqRTeUX9iRzXYExdXh ZbsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qQQtKC3WlFwZ9h3Jz7AR/Fup46i6OQuJ6MbZuUFLfUM=; b=ZAeHk6ZfkCevM08LiS8red1VGQpNBtFZ4R8FnXqR3S7Jq8R5Sxv+Did226/oouWebV 3sYNyHnmoarykWPoQ4yfGaia/fpLVjhgVdegLYz1mKC0hRuW9HObdEMRjoPmLo+AkA/J PUdHP4AgaYY9hwGPfFCSj0GFMnpjAzvm2dgu4Hc23NBUC14x3+rG0Fa1GwMc7Ixhhkdq xU+htcWZQ2zXfsTQ7obJwS13Iqd6YnQTHKBVFAl8VIv5fLMxpibFNJAQOsz0Le/k1FD9 4ZLKDMPM0VbZNVgm9iFSfDZH45tgpm4nF3bHfqmEEvCQ6kdMBROeWint9Mvx2R1rcszD ViYw== X-Gm-Message-State: AOAM5338JdFsd/vYFuLKntbewrAVhA9jdPOXfgrbHmQ2Q0iHF+SIg2DD VJNN32xHANxju87VEqD/B+4lmw== X-Google-Smtp-Source: ABdhPJymJQa1Car/JeCJhulN+hLqg2NTj3BHU5Lsk8Chkrl0a0Q+7b+HEVH+j2qS3eX9K0WO83nOgw== X-Received: by 2002:a05:6000:1567:: with SMTP id 7mr12975401wrz.408.1634288421900; Fri, 15 Oct 2021 02:00:21 -0700 (PDT) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id h206sm384070wmh.33.2021.10.15.02.00.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Oct 2021 02:00:21 -0700 (PDT) Date: Fri, 15 Oct 2021 11:00:20 +0200 From: Olivier Matz <olivier.matz@6wind.com> To: Sean Morrissey <sean.morrissey@intel.com> Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com Message-ID: <YWlDJLoVe+/rD5D3@platinum> References: <20211006111329.152938-1-sean.morrissey@intel.com> <20211007102557.188739-1-sean.morrissey@intel.com> <20211007102557.188739-5-sean.morrissey@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211007102557.188739-5-sean.morrissey@intel.com> Subject: Re: [dpdk-dev] [PATCH v3 4/5] lib/kvargs: remove unneeded header includes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Hi Sean, On Thu, Oct 07, 2021 at 10:25:56AM +0000, Sean Morrissey wrote: > These header includes have been flagged by the iwyu_tool > and removed. > > Signed-off-by: Sean Morrissey <sean.morrissey@intel.com> > --- > lib/kvargs/rte_kvargs.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/lib/kvargs/rte_kvargs.c b/lib/kvargs/rte_kvargs.c > index 38e9d5c1ca..4cce8e953b 100644 > --- a/lib/kvargs/rte_kvargs.c > +++ b/lib/kvargs/rte_kvargs.c > @@ -7,7 +7,6 @@ > #include <stdlib.h> > #include <stdbool.h> > > -#include <rte_os_shim.h> > #include <rte_string_fns.h> > > #include "rte_kvargs.h" > -- > 2.25.1 > Did you check that it still compiles for the Windows platform after this change? +CC Dmitry