From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 019A7A0C43; Wed, 20 Oct 2021 14:42:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8CC464118F; Wed, 20 Oct 2021 14:42:21 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id A23C240142 for <dev@dpdk.org>; Wed, 20 Oct 2021 14:42:19 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10142"; a="215933543" X-IronPort-AV: E=Sophos;i="5.87,166,1631602800"; d="scan'208";a="215933543" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2021 05:42:18 -0700 X-IronPort-AV: E=Sophos;i="5.87,166,1631602800"; d="scan'208";a="444922062" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.29.221]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 20 Oct 2021 05:42:16 -0700 Date: Wed, 20 Oct 2021 13:42:13 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: dev@dpdk.org Cc: david.marchand@redhat.com, dmitry.kozliuk@gmail.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, Chengwen Feng <fengchengwen@huawei.com> Message-ID: <YXAOpXYvBOdykDmi@bricha3-MOBL.ger.corp.intel.com> References: <20211019161537.2414549-1-bruce.richardson@intel.com> <20211020112554.2421080-1-bruce.richardson@intel.com> <20211020112554.2421080-3-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211020112554.2421080-3-bruce.richardson@intel.com> Subject: Re: [dpdk-dev] [PATCH v2 2/3] dmadev: enable build on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Wed, Oct 20, 2021 at 12:25:53PM +0100, Bruce Richardson wrote: > The dmadev library was not added to the list of libraries built on > Windows, meaning it was skipped in those builds and also that none of > the drivers were being considered for build. Adding dmadev to the list > fixes this, and also enables the skeleton dmadev driver to be built - > all-be-it with a small fix necessary. > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> > --- Adding missed reviewed tag from V1: Reviewed-by: Chengwen Feng <fengchengwen@huawei.com>